mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
125 lines
4 KiB
Python
125 lines
4 KiB
Python
"""Tests for the Chronos cron-fire webhook (POST /api/cron/fire) — Phase 4E.2.
|
|
|
|
The webhook authenticates a NAS-minted JWT via the pluggable fire-verifier
|
|
(NOT API_SERVER_KEY), then runs the job via the resolved provider's fire_due in
|
|
the background, returning 202. These tests monkeypatch the verifier and
|
|
resolve_cron_scheduler — the verifier itself is tested with real crypto in
|
|
test_chronos_verify.py.
|
|
"""
|
|
|
|
import asyncio
|
|
import threading
|
|
from types import SimpleNamespace
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
from aiohttp import web
|
|
from aiohttp.test_utils import TestClient, TestServer
|
|
|
|
from gateway.config import PlatformConfig
|
|
from gateway.platforms.api_server import APIServerAdapter, cors_middleware
|
|
|
|
_MOD = "gateway.platforms.api_server"
|
|
|
|
|
|
def _make_adapter() -> APIServerAdapter:
|
|
return APIServerAdapter(PlatformConfig(enabled=True, extra={"key": "sk-secret"}))
|
|
|
|
|
|
def _create_app(adapter: APIServerAdapter) -> web.Application:
|
|
app = web.Application(middlewares=[cors_middleware])
|
|
app["api_server_adapter"] = adapter
|
|
app.router.add_post("/api/cron/fire", adapter._handle_cron_fire)
|
|
return app
|
|
|
|
|
|
@pytest.fixture
|
|
def adapter():
|
|
return _make_adapter()
|
|
|
|
|
|
class _SpyProvider:
|
|
"""Records fire_due calls; stands in for the resolved provider."""
|
|
|
|
def __init__(self):
|
|
self.fired = []
|
|
|
|
def fire_due(self, job_id, *, adapters=None, loop=None):
|
|
self.fired.append(job_id)
|
|
return True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_valid_fire_reservation_blocks_drain_before_body_and_task(adapter, monkeypatch):
|
|
runner = SimpleNamespace(_draining=False, _external_drain_active=False)
|
|
body_started = asyncio.Event()
|
|
release_body = asyncio.Event()
|
|
fired = threading.Event()
|
|
release_fire = threading.Event()
|
|
|
|
class BlockingProvider:
|
|
def fire_due(self, job_id, *, adapters=None, loop=None):
|
|
fired.set()
|
|
release_fire.wait(timeout=2)
|
|
return True
|
|
|
|
original_json = web.Request.json
|
|
|
|
async def delayed_json(request):
|
|
body_started.set()
|
|
await release_body.wait()
|
|
return await original_json(request)
|
|
|
|
monkeypatch.setattr("cron.scheduler_provider.resolve_cron_scheduler", BlockingProvider)
|
|
monkeypatch.setattr(
|
|
"plugins.cron_providers.chronos.verify.get_fire_verifier",
|
|
lambda: (lambda **kw: {"purpose": "cron_fire"}),
|
|
)
|
|
app = _create_app(adapter)
|
|
with patch("gateway.run._gateway_runner_ref", lambda: runner), patch.object(
|
|
web.Request, "json", delayed_json
|
|
):
|
|
async with TestClient(TestServer(app)) as cli:
|
|
request_task = asyncio.create_task(
|
|
cli.post(
|
|
"/api/cron/fire",
|
|
headers={"Authorization": "Bearer good"},
|
|
json={"job_id": "abc123"},
|
|
)
|
|
)
|
|
await body_started.wait()
|
|
assert adapter.active_agent_work_count() == 1
|
|
|
|
release_body.set()
|
|
response = await request_task
|
|
assert response.status == 202
|
|
await asyncio.to_thread(fired.wait, 2)
|
|
assert adapter.active_agent_work_count() == 1
|
|
release_fire.set()
|
|
for _ in range(50):
|
|
if adapter.active_agent_work_count() == 0:
|
|
break
|
|
await asyncio.sleep(0.01)
|
|
|
|
assert adapter.active_agent_work_count() == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_missing_job_id_400(adapter, monkeypatch):
|
|
"""Valid token but no job_id → 400, no fire."""
|
|
spy = _SpyProvider()
|
|
monkeypatch.setattr("cron.scheduler_provider.resolve_cron_scheduler", lambda: spy)
|
|
monkeypatch.setattr(
|
|
"plugins.cron_providers.chronos.verify.get_fire_verifier",
|
|
lambda: (lambda **kw: {"purpose": "cron_fire"}),
|
|
)
|
|
|
|
app = _create_app(adapter)
|
|
async with TestClient(TestServer(app)) as cli:
|
|
resp = await cli.post("/api/cron/fire",
|
|
headers={"Authorization": "Bearer good"},
|
|
json={})
|
|
assert resp.status == 400
|
|
assert spy.fired == []
|
|
|
|
|