mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-03 02:11:48 +00:00
a7780fe05f
The audit of v4.1 surfaced ~70 issues across the five scripts and three
reference docs — most user-visible (silent file overwrites, status-error
misclassified as success, X-API-Key leaked to S3 on /api/view redirect,
Cloud endpoints that 404 because they were renamed). v5.0.0 fixes those
and fills the gaps that previously forced users to write their own glue
(WebSocket monitoring, batch/sweep, img2img upload helper, dep auto-fix,
log fetch, health check, example workflows).
Critical fixes
- run_workflow.py: poll_status now checks status_str==error BEFORE
completed:true, so a failed run no longer reports success
- run_workflow.py: download_output streams to disk via safe_path_join,
preserves server subfolder structure (no silent overwrites), and
retries with exponential backoff
- run_workflow.py: refuses to overwrite a link with a literal in
inject_params (would silently break wiring)
- _common.py: _StripSensitiveOnRedirectSession (subclasses
requests.Session.rebuild_auth) drops X-API-Key/Cookie on cross-host
redirects — fixes a real key-leak path through Cloud's signed-URL
download flow. Tested
- Cloud routing (verified live): /history → /history_v2,
/models/<f> → /experiment/models/<f>, plus folder aliases for the
unet ↔ diffusion_models and clip ↔ text_encoders rename
- check_deps.py: distinguishes 200/empty vs 404 folder_not_found vs
403 free-tier; emits concrete fix_command per missing dep
- extract_schema.py: prompt vs negative_prompt determined by tracing
KSampler.{positive,negative} connections (incl. through Reroute /
Primitive nodes) instead of meta-title heuristic; symmetric
duplicate-name resolution; cycle-safe trace_to_node
- hardware_check.py: multi-GPU pick-best, Apple variant detection,
Rosetta detection, WSL2, ROCm --json, disk-space check, optional
PyTorch probe; powershell preferred over deprecated wmic
- comfyui_setup.sh: prefers pipx → uvx → pip --user (with PEP-668
fallback); idempotent — skips relaunch if server already up;
configurable port/workspace; persistent log; SIGINT trap
New scripts
- run_batch.py — count or sweep (cartesian product), parallel up to
cloud tier limit
- ws_monitor.py — real-time WebSocket viewer; saves preview frames
- auto_fix_deps.py — runs comfy node install / model download for
whatever check_deps reports missing (with --dry-run)
- health_check.py — single command that runs the verification checklist
(comfy-cli + server + checkpoints + optional smoke test that cancels
itself to avoid burning compute)
- fetch_logs.py — pull traceback / status messages for a prompt_id
Coverage expansion
- Param patterns now cover Flux (BasicScheduler, BasicGuider,
RandomNoise, ModelSamplingFlux), SD3, Wan/Hunyuan/LTX video,
IPAdapter, rgthree, easy-use, AnimateDiff
- Embedding refs in CLIPTextEncode strings extracted as model deps
- ckpt_name / vae_name / lora_name / unet_name now controllable so
workflows can be retargeted per run
Examples
- workflows/{sd15,sdxl,flux_dev}_txt2img.json
- workflows/sdxl_{img2img,inpaint}.json
- workflows/upscale_4x.json
- workflows/{animatediff_video,wan_video_t2v}.json + README
Tests
- 117 tests (105 unit + 8 cloud integration + 4 cross-host security)
- Cloud tests auto-skip without COMFY_CLOUD_API_KEY; verified end-to-end
against live cloud API
Backwards compatibility
- All existing CLI flags continue to work; new behavior is opt-in
(--ws, --input-image, --randomize-seed, --flat-output, etc.)
50 lines
2.1 KiB
Markdown
50 lines
2.1 KiB
Markdown
# ComfyUI Skill Tests
|
|
|
|
Pytest suite covering the skill's scripts. Pure-stdlib unit tests run
|
|
without any setup; cloud integration tests need a Comfy Cloud API key.
|
|
|
|
## Running
|
|
|
|
```bash
|
|
# Unit tests only (no network required) — runs in <1s
|
|
python3 -m pytest tests/ -c tests/pytest.ini -o addopts="-p no:xdist"
|
|
|
|
# Including cloud integration tests
|
|
COMFY_CLOUD_API_KEY="comfyui-..." python3 -m pytest tests/ \
|
|
-c tests/pytest.ini -o addopts="-p no:xdist"
|
|
|
|
# Just cloud tests
|
|
COMFY_CLOUD_API_KEY="comfyui-..." python3 -m pytest tests/test_cloud_integration.py \
|
|
-c tests/pytest.ini -o addopts="-p no:xdist" -v
|
|
```
|
|
|
|
The `-c` and `-o` overrides isolate this suite from any parent
|
|
`pyproject.toml` pytest config (e.g. the `-n auto` from a parent repo).
|
|
|
|
## Test files
|
|
|
|
| File | Coverage |
|
|
|------|----------|
|
|
| `test_common.py` | Cloud detection, URL routing, format validation, embeddings, paths, seeds, model-list parsing, folder aliases |
|
|
| `test_extract_schema.py` | Connection tracing, positive/negative prompt detection, dedup logic, embedding deps |
|
|
| `test_run_workflow.py` | Param injection (incl. -1 seed, link refusal), output download walk, runner construction |
|
|
| `test_check_deps.py` | Model-name fuzzy matching, install command suggestions |
|
|
| `test_cloud_integration.py` | Live cloud API contract tests (auto-skipped without API key) |
|
|
|
|
## Adding tests
|
|
|
|
When you change a script:
|
|
|
|
1. Add a unit test if the change is pure logic (cloud detection, parsing, etc.)
|
|
2. Add a cloud integration test if the change depends on cloud API behavior
|
|
(use `pytestmark = pytest.mark.cloud` so it auto-skips without a key)
|
|
3. Workflow fixtures live in `conftest.py` (`sd15_workflow`, `flux_workflow`,
|
|
`video_workflow`)
|
|
|
|
## Why the explicit `-c` / `-o`?
|
|
|
|
The parent hermes-agent repo's `pyproject.toml` enables `pytest-xdist` by
|
|
default (`-n auto`). This suite is small enough that parallelism isn't
|
|
worth the complexity, and pytest-xdist isn't always installed in the user's
|
|
environment. The `-c tests/pytest.ini -o addopts="-p no:xdist"` flags make
|
|
the suite run identically regardless of the parent project's config.
|