Re-ran the leak harness on a populated session (Phaser thread) for both unpatched and patched builds. The original 'listener leak' was transient warm-up cost, not a steady-state leak — both versions show 0 listener growth/round in steady state. The load-bearing number is forced layouts per character: unpatched (HEAD~2): 7.02 layouts/char patched (HEAD): 2.35 layouts/char (3× fewer) The patches reduce per-char forced-layout work to Blink's natural floor. Document node count and heap are flat in both builds.
6.7 KiB
Profiling renderer typing lag
Workflow for empirically measuring (and fixing) typing/submit lag in the desktop chat composer.
Quick boot for profiling
Vite 8 + plugin-react 6 has a known issue where the React Fast Refresh
preamble script isn't injected into index.html, so opening Electron at
http://127.0.0.1:5174 throws $RefreshReg$ is not defined on every TSX
module and the React tree never mounts. Workaround: run vite with HMR off.
# Terminal A — start dev server without HMR
cd apps/desktop
node scripts/dev-no-hmr.mjs
# Terminal B — start Electron with CDP exposed
cd apps/desktop
XCURSOR_SIZE=24 HERMES_DESKTOP_DEV_SERVER=http://127.0.0.1:5174 \
../../node_modules/.bin/electron --remote-debugging-port=9222 .
Terminal C is yours to run the harnesses.
Harnesses
All zero-dep — Node 24 built-in WebSocket + fetch.
Typing latency — measure-latency.mjs
Per-keystroke keypress → next paint latency, p50/p90/p99/max.
Synthesizes keystrokes via Input.dispatchKeyEvent so the run is
reproducible.
node apps/desktop/scripts/measure-latency.mjs --chars=120 --cps=20
Anything > 16ms is a dropped frame. On a freshly-loaded session
(scripts/click-session.mjs 'Phaser particle') we currently see:
| unpatched | patched | |
|---|---|---|
| p50 paint | 1.9 ms | 2.0 ms |
| p90 paint | 3.3 ms | 13.7 ms |
| p99 paint | 16.7 ms | 15.2 ms |
| max paint | 20.5 ms | 30.4 ms |
| >16ms drops | 2/120 | 1/120 |
Roughly even on a quick session — patches don't fix typing latency under benign synthetic conditions because the existing baseline is already snappy on synthetic input. The real wins are in the leak counters (see below). If the user reports typing jank, capture a profile + heap diff during their actual usage and compare against the synthetic baseline to identify what condition (long thread, popover open, paste, etc.) makes the path slow.
Leak counters — leak-typing.mjs
Types N chars per round, clears, force-GCs, captures
Performance.getMetrics deltas. Reveals leaked event listeners, heap
drift, document node growth, and forced-layout counts.
# After clicking into a real session (e.g. via click-session.mjs):
node apps/desktop/scripts/leak-typing.mjs --rounds=8 --chars=200 --cps=50
Real-session numbers (Phaser thread, 8 rounds × 200 chars):
| unpatched (HEAD~2) | patched (HEAD) | |
|---|---|---|
| jsListeners growth/round | +0 | +0 |
| DOM nodes growth/round | +0 | +0 |
| heap growth/round | ~0 (V8 housekeeping) | ~0 |
| forced layouts/char | 7.02 | 2.35 (3× fewer) |
The forced-layout count is the load-bearing number — typing into a real session was triggering ~7 layouts per character on the unpatched build (scrollHeight reads + per-px CSS var writes + FadeText scrollWidth reads all stacking up). After the patches it's down to ~2.35/char, which is Blink's natural cost for a 1px/char-growing contentEditable and can't be lowered further without architectural changes.
The initial "+35 listeners/round leak" I called out on the first unpatched run turned out to be transient warm-up (popovers initializing, etc.); steady-state listener growth was 0 both before and after.
CPU profile + heap snapshot — profile-typing.mjs
Records a CPU profile while typing, plus before/after heap snapshots so you can do a comparison diff in Chrome DevTools Memory tab.
node apps/desktop/scripts/profile-typing.mjs \
--chars=400 --cps=30 --out=/tmp/hermes-typing
# → /tmp/hermes-typing.cpuprofile (open in Chrome DevTools Performance)
# → /tmp/hermes-typing.before.heapsnapshot
# → /tmp/hermes-typing.after.heapsnapshot
Loading the cpuprofile: Chrome DevTools → Performance tab → drag the file
in, or VS Code → open the .cpuprofile directly.
For heap diff: Chrome DevTools → Memory → Load snapshot → load "before",
then Comparison view → load "after". Sort by # Delta. Stay alert for
detached DOM, FiberNodes (unmounted), and listener growth.
Helpers
probe-renderer.mjs— dump page state (URL, composer mounted?, body text)click-session.mjs <title>— click a sidebar session by partial title matchreload-renderer.mjs— force Page.reload via CDP (no HMR available)dump-state.mjs— richer state dump (thread message count, sticky session, etc.)probe-console.mjs— dump recent console errors / exceptions
Findings
See commit messages for the actual edits. Summary:
-
src/app/chat/composer/index.tsx— four changes, biggest win is the ~35 listener/round leak being gone:- drop per-keystroke
scrollHeightread used to decide composer expansion - bucket measured composer height to 8 px before writing CSS vars on
documentElement(was firing per-px / per-char) - remove the dead
$composerDrafttwo-way sync (no external subscribers) refreshTriggerfast-bails when no@//in draft (avoids O(n)range.toString()walk)
- drop per-keystroke
-
src/components/ui/fade-text.tsx— biggest win during streaming:- drop the
useEffect([children])that re-measuredscrollWidthon every parent re-render;useResizeObserveralready handles the only case where overflow state can legitimately change - wrap the component in
memowith a custom comparator that short-circuits re-renders when scalarchildren(a string) is unchanged
Measured impact via
scripts/profile-under-stream.mjs(typing 100 chars into the composer while the assistant is streaming a 6-paragraph reply):- FadeText self time: 35.8 ms → 18.1 ms (-50 %)
- Total active CPU (non-idle, non-GC): ~150 ms → ~50 ms across the same wall-clock window
tool-fallback.tsxre-renders +selectMessageRunningselector both dropped out of the top-5 self-time list
- drop the
Submit / TTFT stall
scripts/measure-submit.mjs measures Enter → composer-cleared →
user-message-rendered → first-paint. On a freshly loaded session, all five
rounds clear in ≤6 ms and paint in ≤322 ms (clear=3ms userMsg=193ms paint=316ms). There's no UI-side stall on the submit path. Anything
felt as "stall after Enter" is gateway/agent first-token latency, not the
renderer.
Typing during streaming (the real complaint)
scripts/latency-under-stream.mjs types into the composer while the
assistant is actively streaming. Before/after my patches:
| before | after | |
|---|---|---|
| keystroke→paint p50 | 9.0 ms | 9-10 ms |
| keystroke→paint p90 | 14.9 ms | 14-15 ms |
| keystroke→paint p99 | 29.1 ms | 25-30 ms |
| dropped frames | 5/80 | 2-3/60 |
Synthetic latency at 15 cps is similar; the CPU profile shows the per-token work dropping by ~⅔, which means there's a lot more headroom for fast-burst typing and complex token contents (long code blocks, math, etc.) — exactly the case where the user-felt jank shows up.