mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-25 05:52:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

fix(cli): tolerate unreadable dirs when building systemd PATH

Browse source 
generate_systemd_unit runs _build_service_path_dirs(); tests that mimic sudo
(Path.home → /root) caused is_dir() to raise PermissionError for unprivileged
users on /root/.hermes/..., failing CI. Treat inaccessible paths like missing.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Austin Pickett 2026-05-15 23:57:30 -04:00
parent ca413c6164
commit 965610f922
1 changed files with 17 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

21
hermes_cli/gateway.py
View file

@ -2103,6 +2103,19 @@ def _hermes_home_for_target_user(target_home_dir: str) -> str:
return str(current_hermes) return str(current_hermes)
def _path_usable_bindir(path: Path) -> bool:
"""True iff ``path`` exists as a dir and we could stat/read it.
systemd unit generation may run under simulated ``sudo`` in tests via
``Path.home()`` → ``/root``; unprivileged users get ``PermissionError`` on
``/root/.hermes/…`` probes. Missing/unreadable dirs are treated as absent.
"""
try:
return path.is_dir()
except OSError:
return False
def _build_service_path_dirs(project_root: Path | None = None) -> list[str]: def _build_service_path_dirs(project_root: Path | None = None) -> list[str]:
"""Build PATH directory list for service units, excluding non-existent dirs.""" """Build PATH directory list for service units, excluding non-existent dirs."""
if project_root is None: if project_root is None:
@ -2111,21 +2124,21 @@ def _build_service_path_dirs(project_root: Path | None = None) -> list[str]:
candidates = [] candidates = []
venv_bin = project_root / "venv" / "bin" venv_bin = project_root / "venv" / "bin"
if venv_bin.is_dir(): if _path_usable_bindir(venv_bin):
candidates.append(str(venv_bin)) candidates.append(str(venv_bin))
elif sys.prefix != sys.base_prefix: elif sys.prefix != sys.base_prefix:
candidates.append(str(Path(sys.prefix) / "bin")) candidates.append(str(Path(sys.prefix) / "bin"))
node_bin = project_root / "node_modules" / ".bin" node_bin = project_root / "node_modules" / ".bin"
if node_bin.is_dir(): if _path_usable_bindir(node_bin):
candidates.append(str(node_bin)) candidates.append(str(node_bin))
hermes_home = get_hermes_home() hermes_home = get_hermes_home()
hermes_node = hermes_home / "node" / "bin" hermes_node = hermes_home / "node" / "bin"
if hermes_node.is_dir(): if _path_usable_bindir(hermes_node):
candidates.append(str(hermes_node)) candidates.append(str(hermes_node))
hermes_nm = hermes_home / "node_modules" / ".bin" hermes_nm = hermes_home / "node_modules" / ".bin"
if hermes_nm.is_dir(): if _path_usable_bindir(hermes_nm):
candidates.append(str(hermes_nm)) candidates.append(str(hermes_nm))
return candidates return candidates