mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-14 04:02:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(dashboard): finish resumeId -> resumeParam rename in ChatPage (#21317)

Browse source 
Commit b12a5a72b renamed the local variable resumeId -> resumeParam at
line 157 but left two call sites referencing the old name at lines 555
and 660. tsc -b fails with two TS2304 errors, which tanks npm run build,
which makes `hermes dashboard` print "Web UI build failed" with no
further detail.

Finishes the rename at both call sites instead of re-introducing the
old name via an alias.

Co-authored-by: qiuqfang <qiuqfang98@qq.com>
This commit is contained in:
Teknium 2026-05-07 07:05:03 -07:00 • committed by GitHub
parent e0a2b08768
commit 12a0f5901c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
web/src/pages/ChatPage.tsx
View file

@ -552,7 +552,7 @@ export default function ChatPage({ isActive = true }: { isActive?: boolean }) {
}); });
// WebSocket // WebSocket
const url = buildWsUrl(token, resumeId, channel); const url = buildWsUrl(token, resumeParam, channel);
const ws = new WebSocket(url); const ws = new WebSocket(url);
ws.binaryType = "arraybuffer"; ws.binaryType = "arraybuffer";
wsRef.current = ws; wsRef.current = ws;
@ -657,7 +657,7 @@ export default function ChatPage({ isActive = true }: { isActive?: boolean }) {
copyResetRef.current = null; copyResetRef.current = null;
} }
}; };
}, [channel, resumeId]); }, [channel, resumeParam]);
// When the user returns to the chat tab (isActive: false → true), the // When the user returns to the chat tab (isActive: false → true), the
// terminal host just transitioned from display:none to display:flex. // terminal host just transitioned from display:none to display:flex.