From 12a0f5901cd0fc798adba374af0aefdaa0c7c34f Mon Sep 17 00:00:00 2001 From: Teknium <127238744+teknium1@users.noreply.github.com> Date: Thu, 7 May 2026 07:05:03 -0700 Subject: [PATCH] fix(dashboard): finish resumeId -> resumeParam rename in ChatPage (#21317) Commit b12a5a72b renamed the local variable resumeId -> resumeParam at line 157 but left two call sites referencing the old name at lines 555 and 660. tsc -b fails with two TS2304 errors, which tanks npm run build, which makes `hermes dashboard` print "Web UI build failed" with no further detail. Finishes the rename at both call sites instead of re-introducing the old name via an alias. Co-authored-by: qiuqfang --- web/src/pages/ChatPage.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/src/pages/ChatPage.tsx b/web/src/pages/ChatPage.tsx index ab1dd0eacb..0d092c72c0 100644 --- a/web/src/pages/ChatPage.tsx +++ b/web/src/pages/ChatPage.tsx @@ -552,7 +552,7 @@ export default function ChatPage({ isActive = true }: { isActive?: boolean }) { }); // WebSocket - const url = buildWsUrl(token, resumeId, channel); + const url = buildWsUrl(token, resumeParam, channel); const ws = new WebSocket(url); ws.binaryType = "arraybuffer"; wsRef.current = ws; @@ -657,7 +657,7 @@ export default function ChatPage({ isActive = true }: { isActive?: boolean }) { copyResetRef.current = null; } }; - }, [channel, resumeId]); + }, [channel, resumeParam]); // When the user returns to the chat tab (isActive: false → true), the // terminal host just transitioned from display:none to display:flex.