mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-23 10:42:00 +00:00
5bf23ff251
The welcome banner's 'Available Tools' merged in every toolset from the global check_tool_availability() registry walk, regardless of whether it was enabled for the current platform. On a Blank Slate CLI (file + terminal only) that surfaced discord / feishu / kanban tools the agent was never actually given — they are not in the agent's tool schema, but the banner displayed them, making it look like they were exposed. - Filter the unavailable-toolset merge to toolsets actually in enabled_toolsets (a toolset that's enabled but has unmet deps still legitimately shows as disabled/lazy). - Gate the 'Available Skills' section on the skills toolset being enabled — when it's off, the agent can't load any skill, so show 'Skills toolset disabled' instead of the on-disk catalog. When enabled_toolsets is empty (older callers), behavior is unchanged. Validation: blank-slate banner now shows only file + terminal and 'Skills toolset disabled'; a skills-enabled banner still lists the catalog. Added regression tests; full banner suite green (15/15).
280 lines
11 KiB
Python
280 lines
11 KiB
Python
"""Tests for banner toolset name normalization and skin color usage."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
from rich.console import Console
|
|
|
|
import hermes_cli.banner as banner
|
|
import model_tools
|
|
import tools.mcp_tool
|
|
|
|
|
|
def test_display_toolset_name_strips_legacy_suffix():
|
|
assert banner._display_toolset_name("homeassistant_tools") == "homeassistant"
|
|
assert banner._display_toolset_name("honcho_tools") == "honcho"
|
|
assert banner._display_toolset_name("web_tools") == "web"
|
|
|
|
|
|
def test_display_toolset_name_preserves_clean_names():
|
|
assert banner._display_toolset_name("browser") == "browser"
|
|
assert banner._display_toolset_name("file") == "file"
|
|
assert banner._display_toolset_name("terminal") == "terminal"
|
|
|
|
|
|
def test_display_toolset_name_handles_empty():
|
|
assert banner._display_toolset_name("") == "unknown"
|
|
assert banner._display_toolset_name(None) == "unknown"
|
|
|
|
|
|
def test_build_welcome_banner_uses_normalized_toolset_names():
|
|
"""Unavailable toolsets should not have '_tools' appended in banner output."""
|
|
with (
|
|
patch.object(
|
|
model_tools,
|
|
"check_tool_availability",
|
|
return_value=(
|
|
["web"],
|
|
[
|
|
{"name": "homeassistant", "tools": ["ha_call_service"]},
|
|
{"name": "honcho", "tools": ["honcho_conclude"]},
|
|
],
|
|
),
|
|
),
|
|
patch.object(banner, "get_available_skills", return_value={}),
|
|
patch.object(banner, "get_update_result", return_value=None),
|
|
patch.object(tools.mcp_tool, "get_mcp_status", return_value=[]),
|
|
):
|
|
console = Console(
|
|
record=True, force_terminal=False, color_system=None, width=160
|
|
)
|
|
banner.build_welcome_banner(
|
|
console=console,
|
|
model="anthropic/test-model",
|
|
cwd="/tmp/project",
|
|
tools=[
|
|
{"function": {"name": "web_search"}},
|
|
{"function": {"name": "read_file"}},
|
|
],
|
|
get_toolset_for_tool=lambda name: {
|
|
"web_search": "web_tools",
|
|
"read_file": "file",
|
|
}.get(name),
|
|
)
|
|
|
|
output = console.export_text()
|
|
assert "homeassistant:" in output
|
|
assert "honcho:" in output
|
|
assert "web:" in output
|
|
assert "homeassistant_tools:" not in output
|
|
assert "honcho_tools:" not in output
|
|
assert "web_tools:" not in output
|
|
|
|
|
|
def test_build_welcome_banner_title_is_hyperlinked_to_release():
|
|
"""Panel title (version label) is wrapped in an OSC-8 hyperlink to the GitHub release."""
|
|
import io
|
|
from unittest.mock import patch as _patch
|
|
import hermes_cli.banner as _banner
|
|
import model_tools as _mt
|
|
import tools.mcp_tool as _mcp
|
|
|
|
_banner._latest_release_cache = None
|
|
tag_url = ("v2026.4.23", "https://github.com/NousResearch/hermes-agent/releases/tag/v2026.4.23")
|
|
|
|
buf = io.StringIO()
|
|
with (
|
|
_patch.object(_mt, "check_tool_availability", return_value=(["web"], [])),
|
|
_patch.object(_banner, "get_available_skills", return_value={}),
|
|
_patch.object(_banner, "get_update_result", return_value=None),
|
|
_patch.object(_mcp, "get_mcp_status", return_value=[]),
|
|
_patch.object(_banner, "get_latest_release_tag", return_value=tag_url),
|
|
):
|
|
console = Console(file=buf, force_terminal=True, color_system="truecolor", width=160)
|
|
_banner.build_welcome_banner(
|
|
console=console, model="x", cwd="/tmp",
|
|
session_id="abc123",
|
|
tools=[{"function": {"name": "read_file"}}],
|
|
get_toolset_for_tool=lambda n: "file",
|
|
)
|
|
|
|
raw = buf.getvalue()
|
|
# The existing version label must still be present in the title
|
|
assert "Hermes Agent v" in raw, "Version label missing from title"
|
|
# OSC-8 hyperlink escape sequence present with the release URL
|
|
assert "\x1b]8;" in raw, "OSC-8 hyperlink not emitted"
|
|
assert "releases/tag/v2026.4.23" in raw, "Release URL missing from banner output"
|
|
|
|
|
|
def test_build_welcome_banner_title_falls_back_when_no_tag():
|
|
"""Without a resolvable tag, the panel title renders as plain text (no hyperlink escape)."""
|
|
import io
|
|
from unittest.mock import patch as _patch
|
|
import hermes_cli.banner as _banner
|
|
import model_tools as _mt
|
|
import tools.mcp_tool as _mcp
|
|
|
|
_banner._latest_release_cache = None
|
|
buf = io.StringIO()
|
|
with (
|
|
_patch.object(_mt, "check_tool_availability", return_value=(["web"], [])),
|
|
_patch.object(_banner, "get_available_skills", return_value={}),
|
|
_patch.object(_banner, "get_update_result", return_value=None),
|
|
_patch.object(_mcp, "get_mcp_status", return_value=[]),
|
|
_patch.object(_banner, "get_latest_release_tag", return_value=None),
|
|
):
|
|
console = Console(file=buf, force_terminal=True, color_system="truecolor", width=160)
|
|
_banner.build_welcome_banner(
|
|
console=console, model="x", cwd="/tmp",
|
|
session_id="abc123",
|
|
tools=[{"function": {"name": "read_file"}}],
|
|
get_toolset_for_tool=lambda n: "file",
|
|
)
|
|
|
|
raw = buf.getvalue()
|
|
assert "Hermes Agent v" in raw, "Version label missing from title"
|
|
assert "\x1b]8;" not in raw, "OSC-8 hyperlink should not be emitted without a tag"
|
|
|
|
|
|
def test_build_welcome_banner_disabled_mcp_shows_disabled_not_failed():
|
|
"""A disabled MCP server renders '— disabled' (dim), not '— failed' (red)."""
|
|
with (
|
|
patch.object(model_tools, "check_tool_availability", return_value=(["web"], [])),
|
|
patch.object(banner, "get_available_skills", return_value={}),
|
|
patch.object(banner, "get_update_result", return_value=None),
|
|
patch.object(
|
|
tools.mcp_tool,
|
|
"get_mcp_status",
|
|
return_value=[
|
|
{"name": "linear", "transport": "http", "tools": 0,
|
|
"connected": False, "disabled": True},
|
|
{"name": "broken", "transport": "stdio", "tools": 0,
|
|
"connected": False, "disabled": False},
|
|
],
|
|
),
|
|
):
|
|
console = Console(record=True, force_terminal=False, color_system=None, width=160)
|
|
banner.build_welcome_banner(
|
|
console=console, model="anthropic/test-model", cwd="/tmp/project",
|
|
tools=[{"function": {"name": "read_file"}}],
|
|
get_toolset_for_tool=lambda n: "file",
|
|
)
|
|
|
|
output = console.export_text()
|
|
# Disabled server is labeled "disabled", not "failed"
|
|
assert "linear" in output
|
|
assert "disabled" in output
|
|
# A genuinely unreachable server still reads "failed"
|
|
assert "broken" in output
|
|
assert "failed" in output
|
|
|
|
|
|
def test_build_welcome_banner_configured_mcp_is_not_failed():
|
|
"""A configured MCP server with no connection attempt yet is not a failure."""
|
|
with (
|
|
patch.object(model_tools, "check_tool_availability", return_value=(["web"], [])),
|
|
patch.object(banner, "get_available_skills", return_value={}),
|
|
patch.object(banner, "get_update_result", return_value=None),
|
|
patch.object(
|
|
tools.mcp_tool,
|
|
"get_mcp_status",
|
|
return_value=[
|
|
{
|
|
"name": "docker-profile",
|
|
"transport": "stdio",
|
|
"tools": 0,
|
|
"connected": False,
|
|
"disabled": False,
|
|
"status": "configured",
|
|
},
|
|
],
|
|
),
|
|
):
|
|
console = Console(record=True, force_terminal=False, color_system=None, width=160)
|
|
banner.build_welcome_banner(
|
|
console=console, model="anthropic/test-model", cwd="/tmp/project",
|
|
tools=[{"function": {"name": "read_file"}}],
|
|
get_toolset_for_tool=lambda n: "file",
|
|
)
|
|
|
|
output = console.export_text()
|
|
assert "docker-profile" in output
|
|
assert "configured" in output
|
|
assert "failed" not in output
|
|
|
|
|
|
def test_banner_hides_toolsets_not_enabled_for_platform():
|
|
"""A globally-registered toolset that isn't enabled for this agent (e.g.
|
|
discord / feishu on a CLI session) must NOT appear in 'Available Tools'.
|
|
|
|
Regression: check_tool_availability() walks the global registry, so the
|
|
banner used to merge in every unavailable toolset regardless of whether it
|
|
was part of this platform's set. On a Blank Slate CLI (file + terminal only)
|
|
that surfaced discord/feishu tools the agent was never given.
|
|
"""
|
|
with (
|
|
patch.object(
|
|
model_tools,
|
|
"check_tool_availability",
|
|
return_value=(
|
|
["file", "terminal"],
|
|
[
|
|
{"name": "discord", "tools": ["discord_fetch_messages"]},
|
|
{"name": "feishu_doc", "tools": ["feishu_doc_read"]},
|
|
],
|
|
),
|
|
),
|
|
patch.object(banner, "get_available_skills", return_value={}),
|
|
patch.object(banner, "get_update_result", return_value=None),
|
|
patch.object(tools.mcp_tool, "get_mcp_status", return_value=[]),
|
|
):
|
|
console = Console(record=True, force_terminal=False, color_system=None, width=160)
|
|
banner.build_welcome_banner(
|
|
console=console,
|
|
model="anthropic/test-model",
|
|
cwd="/tmp/project",
|
|
tools=[{"function": {"name": "read_file"}}],
|
|
enabled_toolsets=["file", "terminal"],
|
|
get_toolset_for_tool=lambda n: "file",
|
|
)
|
|
|
|
output = console.export_text()
|
|
assert "discord" not in output
|
|
assert "feishu" not in output
|
|
|
|
|
|
def test_banner_skills_section_reflects_disabled_skills_toolset():
|
|
"""When the `skills` toolset is disabled (Blank Slate), the banner must not
|
|
advertise the on-disk skill catalog — the agent can't load any of them."""
|
|
fake_skills = {"creative": ["ascii-art", "p5js"], "devops": ["bug-triage-work"]}
|
|
|
|
# skills toolset DISABLED -> catalog hidden, "disabled" message shown
|
|
with (
|
|
patch.object(model_tools, "check_tool_availability", return_value=(["file", "terminal"], [])),
|
|
patch.object(banner, "get_available_skills", return_value=fake_skills),
|
|
patch.object(banner, "get_update_result", return_value=None),
|
|
patch.object(tools.mcp_tool, "get_mcp_status", return_value=[]),
|
|
):
|
|
console = Console(record=True, force_terminal=False, color_system=None, width=160)
|
|
banner.build_welcome_banner(
|
|
console=console, model="m", cwd="/tmp", tools=[{"function": {"name": "read_file"}}],
|
|
enabled_toolsets=["file", "terminal"], get_toolset_for_tool=lambda n: "file",
|
|
)
|
|
out_disabled = console.export_text()
|
|
assert "Skills toolset disabled" in out_disabled
|
|
assert "ascii-art" not in out_disabled
|
|
|
|
# skills toolset ENABLED -> catalog listed as before
|
|
with (
|
|
patch.object(model_tools, "check_tool_availability", return_value=(["file", "terminal", "skills"], [])),
|
|
patch.object(banner, "get_available_skills", return_value=fake_skills),
|
|
patch.object(banner, "get_update_result", return_value=None),
|
|
patch.object(tools.mcp_tool, "get_mcp_status", return_value=[]),
|
|
):
|
|
console = Console(record=True, force_terminal=False, color_system=None, width=160)
|
|
banner.build_welcome_banner(
|
|
console=console, model="m", cwd="/tmp", tools=[{"function": {"name": "read_file"}}],
|
|
enabled_toolsets=["file", "terminal", "skills"], get_toolset_for_tool=lambda n: "file",
|
|
)
|
|
out_enabled = console.export_text()
|
|
assert "Skills toolset disabled" not in out_enabled
|
|
assert "ascii-art" in out_enabled
|