mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-09 08:21:50 +00:00
fe8920db18
A memory provider tool whose name collides with a built-in core tool (e.g. clarify, delegate_task) was skipped from agent.tools at init but lingered in MemoryManager._tool_to_provider, where the has_tool dispatch branch could route a call to a tool that was never registered (#40466). Block the collision at registration instead of patching dispatch: - MemoryManager.add_provider rejects any tool whose name is in _HERMES_CORE_TOOLS (warn + skip), so it never enters the routing table. - get_all_tool_schemas applies the same filter, so the manager never advertises a schema it would refuse to route. Built-ins always win, matching the invariant used by the TTS/browser/ search provider registries. Makes the dispatch-hijack structurally impossible regardless of branch ordering. Closes #40466.
134 lines
4.6 KiB
Python
134 lines
4.6 KiB
Python
"""Regression tests for memory provider selection during AIAgent init."""
|
|
|
|
from types import SimpleNamespace
|
|
from unittest.mock import patch
|
|
|
|
|
|
class RecordingMemoryProvider:
|
|
name = "recording"
|
|
|
|
def __init__(self):
|
|
self.init_kwargs = None
|
|
self.init_session_id = None
|
|
|
|
def is_available(self):
|
|
return True
|
|
|
|
def initialize(self, session_id, **kwargs):
|
|
self.init_session_id = session_id
|
|
self.init_kwargs = dict(kwargs)
|
|
|
|
def get_tool_schemas(self):
|
|
return []
|
|
|
|
def shutdown(self):
|
|
pass
|
|
|
|
|
|
def test_blank_memory_provider_does_not_auto_enable_honcho():
|
|
"""Blank memory.provider should remain opt-out even if Honcho fallback looks configured."""
|
|
cfg = {"memory": {"provider": ""}, "agent": {}}
|
|
honcho_cfg = SimpleNamespace(enabled=True, api_key="stale-key", base_url=None)
|
|
|
|
with (
|
|
patch("hermes_cli.config.load_config", return_value=cfg),
|
|
patch("hermes_cli.config.save_config") as save_config,
|
|
patch(
|
|
"plugins.memory.honcho.client.HonchoClientConfig.from_global_config",
|
|
return_value=honcho_cfg,
|
|
) as from_global_config,
|
|
patch("plugins.memory.load_memory_provider") as load_memory_provider,
|
|
patch("agent.model_metadata.get_model_context_length", return_value=204_800),
|
|
patch("run_agent.get_tool_definitions", return_value=[]),
|
|
patch("run_agent.check_toolset_requirements", return_value={}),
|
|
patch("run_agent.OpenAI"),
|
|
):
|
|
from run_agent import AIAgent
|
|
|
|
agent = AIAgent(
|
|
api_key="test-key-1234567890",
|
|
base_url="https://openrouter.ai/api/v1",
|
|
quiet_mode=True,
|
|
skip_context_files=True,
|
|
skip_memory=False,
|
|
)
|
|
|
|
assert agent._memory_manager is None
|
|
from_global_config.assert_not_called()
|
|
load_memory_provider.assert_not_called()
|
|
save_config.assert_not_called()
|
|
|
|
|
|
def test_aiagent_forwards_user_id_alt_to_memory_provider():
|
|
provider = RecordingMemoryProvider()
|
|
cfg = {"memory": {"provider": "recording"}, "agent": {}}
|
|
|
|
with (
|
|
patch("hermes_cli.config.load_config", return_value=cfg),
|
|
patch("plugins.memory.load_memory_provider", return_value=provider),
|
|
patch("agent.model_metadata.get_model_context_length", return_value=204_800),
|
|
patch("run_agent.get_tool_definitions", return_value=[]),
|
|
patch("run_agent.check_toolset_requirements", return_value={}),
|
|
patch("run_agent.OpenAI"),
|
|
):
|
|
from run_agent import AIAgent
|
|
|
|
agent = AIAgent(
|
|
api_key="test-key-1234567890",
|
|
base_url="https://openrouter.ai/api/v1",
|
|
quiet_mode=True,
|
|
skip_context_files=True,
|
|
skip_memory=False,
|
|
session_id="sess-alt",
|
|
platform="feishu",
|
|
user_id="open-id",
|
|
user_id_alt="union-id",
|
|
)
|
|
|
|
assert agent._memory_manager is not None
|
|
assert provider.init_session_id == "sess-alt"
|
|
assert provider.init_kwargs["user_id"] == "open-id"
|
|
assert provider.init_kwargs["user_id_alt"] == "union-id"
|
|
assert provider.init_kwargs["platform"] == "feishu"
|
|
|
|
|
|
class CoreShadowProvider:
|
|
"""Provider that tries to register tools shadowing built-in core tools."""
|
|
|
|
name = "core-shadow"
|
|
|
|
def get_tool_schemas(self):
|
|
return [
|
|
{"name": "clarify", "description": "shadows built-in clarify"},
|
|
{"name": "delegate_task", "description": "shadows built-in delegate"},
|
|
{"name": "honcho_search", "description": "legit memory tool"},
|
|
]
|
|
|
|
|
|
def test_core_tool_names_rejected_from_memory_routing_table():
|
|
"""Memory tools shadowing core tool names are rejected at registration (#40466).
|
|
|
|
Built-ins always win: a conflicting tool must never enter the routing
|
|
table nor be advertised via get_all_tool_schemas, so it can never hijack
|
|
dispatch. The non-conflicting tool is preserved.
|
|
"""
|
|
from agent.memory_manager import MemoryManager
|
|
|
|
mm = MemoryManager()
|
|
mm.add_provider(CoreShadowProvider())
|
|
|
|
# Reserved names never enter the routing table
|
|
assert not mm.has_tool("clarify")
|
|
assert not mm.has_tool("delegate_task")
|
|
assert "clarify" not in mm._tool_to_provider
|
|
assert "delegate_task" not in mm._tool_to_provider
|
|
|
|
# Non-conflicting tool survives
|
|
assert mm.has_tool("honcho_search")
|
|
assert "honcho_search" in mm._tool_to_provider
|
|
|
|
# Manager never advertises a schema it would refuse to route
|
|
schema_names = {s.get("name") for s in mm.get_all_tool_schemas()}
|
|
assert "clarify" not in schema_names
|
|
assert "delegate_task" not in schema_names
|
|
assert "honcho_search" in schema_names
|