mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-01 12:02:05 +00:00
97640fd9ad
The plain-Linux overlay re-enable (#53185) left nativeOverlayWidth() at 0 for plain Linux, so the native min/max/close buttons painted on top of the app's right-edge titlebar tools. Reserve the fallback width everywhere the WCO overlay is painted (Windows, WSLg, plain Linux); macOS still reserves 0 since it uses traffic lights.
36 lines
1.6 KiB
JavaScript
36 lines
1.6 KiB
JavaScript
const assert = require('node:assert/strict')
|
|
const test = require('node:test')
|
|
|
|
const { OVERLAY_FALLBACK_WIDTH, nativeOverlayWidth } = require('./titlebar-overlay-width.cjs')
|
|
|
|
// This static reservation is only the pre-layout FALLBACK. Once laid out the
|
|
// renderer reads the exact width from navigator.windowControlsOverlay
|
|
// (use-window-controls-overlay-width.ts) and uses these values only when the WCO
|
|
// API is unavailable.
|
|
|
|
test('Windows reserves the overlay fallback width', () => {
|
|
assert.equal(nativeOverlayWidth({ isWindows: true }), OVERLAY_FALLBACK_WIDTH)
|
|
})
|
|
|
|
test('WSLg paints the same WCO, so it reserves the same fallback width', () => {
|
|
// The original bug: WSL fell through to 0, so the right tools sat under the
|
|
// controls and the title overran into them.
|
|
assert.equal(nativeOverlayWidth({ isWsl: true }), OVERLAY_FALLBACK_WIDTH)
|
|
})
|
|
|
|
test('plain Linux paints the WCO too, so it reserves the fallback width', () => {
|
|
// Regression #53185: re-enabling the overlay on plain Linux (KDE/GNOME)
|
|
// without reserving its width left the native min/max/close buttons painting
|
|
// on top of the app's right-edge titlebar tools.
|
|
assert.equal(nativeOverlayWidth({ isWindows: false, isWsl: false }), OVERLAY_FALLBACK_WIDTH)
|
|
assert.equal(nativeOverlayWidth(), OVERLAY_FALLBACK_WIDTH)
|
|
assert.equal(nativeOverlayWidth({}), OVERLAY_FALLBACK_WIDTH)
|
|
})
|
|
|
|
test('macOS uses traffic lights, not a WCO overlay, so it reserves nothing', () => {
|
|
assert.equal(nativeOverlayWidth({ isMac: true }), 0)
|
|
})
|
|
|
|
test('the fallback width is a sane positive pixel value', () => {
|
|
assert.ok(Number.isInteger(OVERLAY_FALLBACK_WIDTH) && OVERLAY_FALLBACK_WIDTH > 0)
|
|
})
|