mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-08 13:12:08 +00:00
fdc0d19566
Manual testing of the salvaged draft persistence showed none of it worked end-to-end. Three distinct bugs, all invisible to the store-level unit tests: 1. New-chat drafts were never written. The skip-one-persist sentinel was reset to null after consuming, but null IS a real scope (the unsaved new-session draft) — so in a new chat every persist run matched the "consumed" sentinel and bailed. This silently killed the headline #38498 fix. Use undefined as the no-skip sentinel, which can never collide with a scope. 2. Cmd+R inside the debounce window dropped the trailing text. React does not run effect cleanups on a page reload, so the flush-on-unmount never fired; with the 400ms debounce that meant type-then-reload lost the draft every time. Flush pending writes on pagehide. 3. Session switch/new/resume/branch paths in use-session-actions cleared the composer stores synchronously with the session-id updates. React batches those, so by the time ChatBar's scope-change cleanup ran to stash the departing session's attachments, the store was already empty — the stash recorded [] and the chips were lost anyway. The composer's per-scope restore now owns composer contents wholesale on scope change, so drop the upstream clears (clearComposerDraft only touched the vestigial $composerDraft atom nothing reads). Co-authored-by: mollusk <roger@roger.local> Co-authored-by: Teknium <127238744+teknium1@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| use-context-suggestions.ts | ||
| use-cwd-actions.ts | ||
| use-hermes-config.ts | ||
| use-message-stream.ts | ||
| use-model-controls.test.tsx | ||
| use-model-controls.ts | ||
| use-preview-routing.test.tsx | ||
| use-preview-routing.ts | ||
| use-prompt-actions.test.tsx | ||
| use-prompt-actions.ts | ||
| use-route-resume.test.tsx | ||
| use-route-resume.ts | ||
| use-session-actions.ts | ||
| use-session-state-cache.test.tsx | ||
| use-session-state-cache.ts | ||