mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
fd9b692d33
YAML parses bare keys like `agent:` or `display:` as None. `dict.get(key, {})`
returns that None instead of the default (defaults only fire on missing keys),
so every `cfg.get("agent", {}).get(...)` chain in tui_gateway/server.py
crashed agent init with `'NoneType' object has no attribute 'get'`.
Guard all 21 sites with `(cfg.get(X) or {})`. Regression test covers the
null-section init path reported on Twitter against the new TUI.
76 lines
3 KiB
Python
76 lines
3 KiB
Python
"""Regression test for #11884: _make_agent must resolve runtime provider.
|
|
|
|
Without resolve_runtime_provider(), bare-slug models in config
|
|
(e.g. ``claude-opus-4-6`` with ``model.provider: anthropic``) leave
|
|
provider/base_url/api_key empty in AIAgent, causing HTTP 404.
|
|
"""
|
|
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
|
|
def test_make_agent_passes_resolved_provider():
|
|
"""_make_agent forwards provider/base_url/api_key/api_mode from
|
|
resolve_runtime_provider to AIAgent."""
|
|
|
|
fake_runtime = {
|
|
"provider": "anthropic",
|
|
"base_url": "https://api.anthropic.com",
|
|
"api_key": "sk-test-key",
|
|
"api_mode": "anthropic_messages",
|
|
"command": None,
|
|
"args": None,
|
|
"credential_pool": None,
|
|
}
|
|
|
|
fake_cfg = {
|
|
"model": {"default": "claude-opus-4-6", "provider": "anthropic"},
|
|
"agent": {"system_prompt": "test"},
|
|
}
|
|
|
|
with patch("tui_gateway.server._load_cfg", return_value=fake_cfg), \
|
|
patch("tui_gateway.server._get_db", return_value=MagicMock()), \
|
|
patch("tui_gateway.server._load_tool_progress_mode", return_value="compact"), \
|
|
patch("tui_gateway.server._load_reasoning_config", return_value=None), \
|
|
patch("tui_gateway.server._load_service_tier", return_value=None), \
|
|
patch("tui_gateway.server._load_enabled_toolsets", return_value=None), \
|
|
patch("hermes_cli.runtime_provider.resolve_runtime_provider", return_value=fake_runtime) as mock_resolve, \
|
|
patch("run_agent.AIAgent") as mock_agent:
|
|
|
|
from tui_gateway.server import _make_agent
|
|
_make_agent("sid-1", "key-1")
|
|
|
|
mock_resolve.assert_called_once_with(requested=None)
|
|
|
|
call_kwargs = mock_agent.call_args
|
|
assert call_kwargs.kwargs["provider"] == "anthropic"
|
|
assert call_kwargs.kwargs["base_url"] == "https://api.anthropic.com"
|
|
assert call_kwargs.kwargs["api_key"] == "sk-test-key"
|
|
assert call_kwargs.kwargs["api_mode"] == "anthropic_messages"
|
|
|
|
|
|
def test_make_agent_tolerates_null_config_sections():
|
|
"""Bare `agent:` / `display:` keys in ~/.hermes/config.yaml parse as
|
|
None. cfg.get("agent", {}) returns None (default only fires on missing
|
|
key), so downstream .get() chains must be guarded. Reported via Twitter
|
|
against the new TUI; CLI path is unaffected."""
|
|
|
|
fake_runtime = {
|
|
"provider": "openrouter",
|
|
"base_url": "https://api.synthetic.new/v1",
|
|
"api_key": "sk-test",
|
|
"api_mode": "chat_completions",
|
|
"command": None,
|
|
"args": None,
|
|
"credential_pool": None,
|
|
}
|
|
null_cfg = {"agent": None, "display": None, "model": {"default": "glm-5"}}
|
|
|
|
with patch("tui_gateway.server._load_cfg", return_value=null_cfg), \
|
|
patch("tui_gateway.server._get_db", return_value=MagicMock()), \
|
|
patch("hermes_cli.runtime_provider.resolve_runtime_provider", return_value=fake_runtime), \
|
|
patch("run_agent.AIAgent") as mock_agent:
|
|
|
|
from tui_gateway.server import _make_agent
|
|
_make_agent("sid-null", "key-null")
|
|
|
|
assert mock_agent.called
|