mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-11 13:41:53 +00:00
fc02b1c276
Since safe mode already landed on main via #45488, reduce this branch to cleanup: centralize env setup, remove duplicated comments, and tighten tests.
132 lines
4.1 KiB
Python
132 lines
4.1 KiB
Python
"""Tests for `hermes chat --safe-mode` isolation."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import sys
|
|
import types
|
|
|
|
import pytest
|
|
|
|
|
|
_VARS = ("HERMES_SAFE_MODE", "HERMES_IGNORE_USER_CONFIG", "HERMES_IGNORE_RULES")
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _clean_env(monkeypatch):
|
|
for var in _VARS:
|
|
monkeypatch.delenv(var, raising=False)
|
|
yield
|
|
for var in _VARS:
|
|
os.environ.pop(var, None)
|
|
|
|
|
|
def test_cmd_chat_safe_mode_sets_env_before_startup(monkeypatch):
|
|
import hermes_cli.main as main_mod
|
|
from hermes_cli._parser import build_top_level_parser
|
|
|
|
parser, _subparsers, chat_parser = build_top_level_parser()
|
|
chat_parser.set_defaults(func=main_mod.cmd_chat)
|
|
args = parser.parse_args(["chat", "--safe-mode"])
|
|
captured: dict[str, object] = {}
|
|
fake_cli = types.ModuleType("cli")
|
|
|
|
def fake_has_provider() -> bool:
|
|
assert os.environ["HERMES_SAFE_MODE"] == "1"
|
|
assert os.environ["HERMES_IGNORE_USER_CONFIG"] == "1"
|
|
assert os.environ["HERMES_IGNORE_RULES"] == "1"
|
|
return True
|
|
|
|
def fake_main(**kwargs):
|
|
captured.update(kwargs)
|
|
|
|
monkeypatch.setattr(main_mod, "_has_any_provider_configured", fake_has_provider)
|
|
monkeypatch.setattr(main_mod, "_pin_kanban_board_env", lambda: None)
|
|
monkeypatch.setattr(main_mod, "_sync_bundled_skills_for_startup", lambda: None)
|
|
monkeypatch.setattr(main_mod, "_termux_should_prefetch_update_check", lambda: False)
|
|
setattr(fake_cli, "main", fake_main)
|
|
monkeypatch.setitem(sys.modules, "cli", fake_cli)
|
|
|
|
main_mod.cmd_chat(args)
|
|
|
|
assert captured["ignore_user_config"] is True
|
|
assert captured["ignore_rules"] is True
|
|
|
|
|
|
def test_prepare_agent_startup_applies_safe_mode_before_plugin_discovery(monkeypatch):
|
|
import hermes_cli.main as main_mod
|
|
|
|
args = types.SimpleNamespace(command="chat", safe_mode=True, tui=False)
|
|
plugins = types.ModuleType("hermes_cli.plugins")
|
|
|
|
def discover_plugins() -> None:
|
|
assert os.environ["HERMES_SAFE_MODE"] == "1"
|
|
assert os.environ["HERMES_IGNORE_USER_CONFIG"] == "1"
|
|
assert os.environ["HERMES_IGNORE_RULES"] == "1"
|
|
|
|
setattr(plugins, "discover_plugins", discover_plugins)
|
|
monkeypatch.setitem(sys.modules, "hermes_cli.plugins", plugins)
|
|
monkeypatch.setattr(main_mod, "_should_background_mcp_startup", lambda _args: False)
|
|
monkeypatch.setattr(main_mod, "_command_has_dedicated_mcp_startup", lambda _args: True)
|
|
|
|
main_mod._prepare_agent_startup(args)
|
|
|
|
|
|
def test_plugin_discovery_skipped(monkeypatch):
|
|
monkeypatch.setenv("HERMES_SAFE_MODE", "1")
|
|
from hermes_cli.plugins import PluginManager
|
|
|
|
mgr = PluginManager()
|
|
called = []
|
|
monkeypatch.setattr(mgr, "_discover_and_load_inner", lambda: called.append(True))
|
|
|
|
mgr.discover_and_load()
|
|
|
|
assert called == []
|
|
assert mgr._discovered is True
|
|
assert mgr._plugins == {}
|
|
|
|
|
|
def test_plugin_discovery_runs_without_safe_mode(monkeypatch):
|
|
from hermes_cli.plugins import PluginManager
|
|
|
|
mgr = PluginManager()
|
|
called = []
|
|
monkeypatch.setattr(mgr, "_discover_and_load_inner", lambda: called.append(True))
|
|
|
|
mgr.discover_and_load()
|
|
|
|
assert called == [True]
|
|
|
|
|
|
def test_mcp_servers_empty(monkeypatch):
|
|
monkeypatch.setenv("HERMES_SAFE_MODE", "1")
|
|
from tools.mcp_tool import _load_mcp_config
|
|
|
|
monkeypatch.setattr(
|
|
"hermes_cli.config.load_config",
|
|
lambda: {"mcp_servers": {"github": {"url": "https://example.com/mcp"}}},
|
|
)
|
|
|
|
assert _load_mcp_config() == {}
|
|
|
|
|
|
def test_mcp_servers_load_without_safe_mode(monkeypatch):
|
|
from tools.mcp_tool import _load_mcp_config
|
|
|
|
monkeypatch.setattr(
|
|
"hermes_cli.config.load_config",
|
|
lambda: {"mcp_servers": {"github": {"url": "https://example.com/mcp"}}},
|
|
)
|
|
|
|
assert "github" in _load_mcp_config()
|
|
|
|
|
|
def test_parser_accepts_safe_mode_on_root_and_chat():
|
|
from hermes_cli._parser import build_top_level_parser
|
|
|
|
parser, _subparsers, _chat = build_top_level_parser()
|
|
|
|
assert parser.parse_args(["--safe-mode"]).safe_mode is True
|
|
assert parser.parse_args(["chat", "--safe-mode"]).safe_mode is True
|
|
assert parser.parse_args(["chat"]).safe_mode is False
|