mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
99 lines
3.7 KiB
Python
99 lines
3.7 KiB
Python
"""Tests for tools.environments.local.build_subprocess_env — the single
|
|
factory for child-process environments (profile-home + secret-scrub owner).
|
|
"""
|
|
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
|
|
import pytest
|
|
|
|
from tools.environments.local import build_subprocess_env
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Unit: scrub path delegates to _sanitize_subprocess_env semantics
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def test_scrub_on_strips_provider_key(monkeypatch):
|
|
monkeypatch.setenv("ANTHROPIC_API_KEY", "sk-secret")
|
|
env = build_subprocess_env()
|
|
assert "ANTHROPIC_API_KEY" not in env
|
|
|
|
|
|
def test_scrub_on_strips_dynamic_internal_secret(monkeypatch):
|
|
monkeypatch.setenv("AUXILIARY_VISION_API_KEY", "sk-aux")
|
|
monkeypatch.setenv("GATEWAY_RELAY_FOO_TOKEN", "tok")
|
|
env = build_subprocess_env()
|
|
assert "AUXILIARY_VISION_API_KEY" not in env
|
|
assert "GATEWAY_RELAY_FOO_TOKEN" not in env
|
|
|
|
|
|
def test_scrub_on_forwards_extra_like_sanitize_extra_env(monkeypatch):
|
|
env = build_subprocess_env(extra={"MY_HARMLESS_VAR": "1"})
|
|
assert env.get("MY_HARMLESS_VAR") == "1"
|
|
# extra still goes through the blocklist on the scrub path
|
|
env2 = build_subprocess_env(extra={"ANTHROPIC_API_KEY": "sk"})
|
|
assert "ANTHROPIC_API_KEY" not in env2
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Unit: no-scrub path preserves content exactly
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_no_scrub_inherit_profile_home_bridges_context_override(tmp_path):
|
|
from hermes_constants import set_hermes_home_override, reset_hermes_home_override
|
|
|
|
token = set_hermes_home_override(str(tmp_path))
|
|
try:
|
|
env = build_subprocess_env(
|
|
{"PATH": "/bin"}, scrub_secrets=False, inherit_profile_home=True
|
|
)
|
|
finally:
|
|
reset_hermes_home_override(token)
|
|
assert env["HERMES_HOME"] == str(tmp_path)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# E2E: real subprocess sees the factory's contract
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def test_e2e_child_sees_hermes_home_and_no_planted_secret(tmp_path, monkeypatch):
|
|
"""A real child spawned with a factory-built env must see HERMES_HOME
|
|
propagated and (with scrub on) a planted provider-style key absent."""
|
|
hermes_home = tmp_path / "hermes-home"
|
|
hermes_home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
monkeypatch.setenv("ANTHROPIC_API_KEY", "sk-FAKE-planted")
|
|
monkeypatch.setenv("AUXILIARY_FAKE_API_KEY", "sk-FAKE-aux")
|
|
|
|
env = build_subprocess_env() # scrub on (default)
|
|
|
|
code = (
|
|
"import os, json; "
|
|
"print(json.dumps({'home': os.environ.get('HERMES_HOME'), "
|
|
"'k1': 'ANTHROPIC_API_KEY' in os.environ, "
|
|
"'k2': 'AUXILIARY_FAKE_API_KEY' in os.environ}))"
|
|
)
|
|
out = subprocess.run(
|
|
[sys.executable, "-c", code],
|
|
env=env, capture_output=True, text=True, timeout=60, check=True,
|
|
)
|
|
import json
|
|
|
|
result = json.loads(out.stdout)
|
|
assert result["home"] == str(hermes_home)
|
|
assert result["k1"] is False
|
|
assert result["k2"] is False
|
|
|
|
|
|
def test_e2e_no_scrub_child_keeps_planted_secret(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("ANTHROPIC_API_KEY", "sk-FAKE-planted")
|
|
env = build_subprocess_env(scrub_secrets=False, inherit_profile_home=False)
|
|
out = subprocess.run(
|
|
[sys.executable, "-c",
|
|
"import os; print(os.environ.get('ANTHROPIC_API_KEY', ''))"],
|
|
env=env, capture_output=True, text=True, timeout=60, check=True,
|
|
)
|
|
assert out.stdout.strip() == "sk-FAKE-planted"
|