mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
48 lines
2.1 KiB
Python
48 lines
2.1 KiB
Python
"""Tests for credential exclusion during profile export.
|
|
|
|
Profile exports should NEVER include auth.json or .env — these contain
|
|
API keys, OAuth tokens, and credential pool data. Users share exported
|
|
profiles; leaking credentials in the archive is a security issue.
|
|
"""
|
|
|
|
import tarfile
|
|
|
|
from hermes_cli.profiles import export_profile, _DEFAULT_EXPORT_EXCLUDE_ROOT
|
|
|
|
|
|
class TestCredentialExclusion:
|
|
|
|
def test_auth_json_in_default_exclude_set(self):
|
|
"""auth.json must be in the default export exclusion set."""
|
|
assert "auth.json" in _DEFAULT_EXPORT_EXCLUDE_ROOT
|
|
|
|
|
|
def test_named_profile_export_excludes_auth(self, tmp_path, monkeypatch):
|
|
"""Named profile export must not contain auth.json or .env."""
|
|
profiles_root = tmp_path / "profiles"
|
|
profile_dir = profiles_root / "testprofile"
|
|
profile_dir.mkdir(parents=True)
|
|
|
|
# Create a profile with credentials
|
|
(profile_dir / "config.yaml").write_text("model: gpt-4\n")
|
|
(profile_dir / "auth.json").write_text('{"tokens": {"access": "sk-secret"}}')
|
|
(profile_dir / ".env").write_text("OPENROUTER_API_KEY=sk-secret-key\n")
|
|
(profile_dir / "SOUL.md").write_text("I am helpful.\n")
|
|
(profile_dir / "memories").mkdir()
|
|
(profile_dir / "memories" / "MEMORY.md").write_text("# Memories\n")
|
|
|
|
monkeypatch.setattr("hermes_cli.profiles._get_profiles_root", lambda: profiles_root)
|
|
monkeypatch.setattr("hermes_cli.profiles.get_profile_dir", lambda n: profile_dir)
|
|
monkeypatch.setattr("hermes_cli.profiles.validate_profile_name", lambda n: None)
|
|
|
|
output = tmp_path / "export.tar.gz"
|
|
result = export_profile("testprofile", str(output))
|
|
|
|
# Check archive contents
|
|
with tarfile.open(result, "r:gz") as tf:
|
|
names = tf.getnames()
|
|
|
|
assert any("config.yaml" in n for n in names), "config.yaml should be in export"
|
|
assert any("SOUL.md" in n for n in names), "SOUL.md should be in export"
|
|
assert not any("auth.json" in n for n in names), "auth.json must NOT be in export"
|
|
assert not any(".env" in n for n in names), ".env must NOT be in export"
|