mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
95 lines
3.4 KiB
Python
95 lines
3.4 KiB
Python
"""Tests for opencode-go / opencode-zen flat-namespace model handling.
|
|
|
|
OpenCode Go is NOT a vendor/model aggregator like OpenRouter — its
|
|
``/v1/models`` endpoint returns bare IDs (``minimax-m2.7``, ``deepseek-v4-flash``)
|
|
and the inference API rejects vendor-prefixed names with HTTP 401
|
|
"Model not supported".
|
|
|
|
Two bugs this exercises:
|
|
|
|
1. ``switch_model('deepseek-v4-flash', current_provider='opencode-go')`` used
|
|
to silently switch the user off opencode-go to native ``deepseek`` because
|
|
``detect_provider_for_model`` matched the bare name against the static
|
|
deepseek catalog. Fix: once step d matches the model in the current
|
|
aggregator's live catalog, skip ``detect_provider_for_model``.
|
|
|
|
2. ``normalize_model_for_provider('minimax/minimax-m2.7', 'opencode-go')``
|
|
used to pass the ``minimax/`` prefix through unchanged. When user configs
|
|
contained prefixed fallback entries (commonly copied from aggregator slugs),
|
|
the fallback activation path sent ``minimax/minimax-m2.7`` to opencode-go
|
|
which returned HTTP 401. Fix: opencode-go/opencode-zen strip ANY leading
|
|
``vendor/`` prefix because their APIs are flat-namespace.
|
|
"""
|
|
|
|
from unittest.mock import patch
|
|
|
|
from hermes_cli.model_normalize import normalize_model_for_provider
|
|
from hermes_cli.model_switch import switch_model
|
|
|
|
|
|
# Live catalog opencode-go currently returns from /v1/models (snapshot).
|
|
_OPENCODE_GO_LIVE = [
|
|
"minimax-m2.7", "minimax-m2.5",
|
|
"kimi-k2.6", "kimi-k2.5",
|
|
"glm-5.1", "glm-5",
|
|
"deepseek-v4-pro", "deepseek-v4-flash",
|
|
"qwen3.6-plus", "qwen3.5-plus",
|
|
"mimo-v2-pro", "mimo-v2-omni", "mimo-v2.5-pro", "mimo-v2.5",
|
|
]
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# normalize_model_for_provider: strip vendor prefix for flat-namespace providers
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_opencode_go_strips_deepseek_prefix():
|
|
assert normalize_model_for_provider(
|
|
"deepseek/deepseek-v4-flash", "opencode-go"
|
|
) == "deepseek-v4-flash"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# switch_model: live-catalog match on opencode-go must not trigger
|
|
# cross-provider auto-switch via detect_provider_for_model
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _run_switch(raw_input: str, **extra):
|
|
"""Call switch_model with opencode-go as current provider, mocking the
|
|
live catalog so the test doesn't hit the network."""
|
|
defaults = dict(
|
|
current_provider="opencode-go",
|
|
current_model="kimi-k2.6",
|
|
current_base_url="https://opencode.ai/zen/go/v1",
|
|
current_api_key="sk-test-opencode-go",
|
|
is_global=False,
|
|
)
|
|
defaults.update(extra)
|
|
|
|
def fake_list_provider_models(provider: str):
|
|
if provider == "opencode-go":
|
|
return list(_OPENCODE_GO_LIVE)
|
|
# For other providers, return empty so tests don't depend on them.
|
|
return []
|
|
|
|
with patch(
|
|
"hermes_cli.model_switch.list_provider_models",
|
|
side_effect=fake_list_provider_models,
|
|
):
|
|
return switch_model(raw_input=raw_input, **defaults)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_kimi_k2_6_stays_on_opencode_go():
|
|
"""Regression guard: this path was always working, keep it working."""
|
|
result = _run_switch("kimi-k2.6", current_model="deepseek-v4-pro")
|
|
assert result.target_provider == "opencode-go"
|
|
assert result.new_model == "kimi-k2.6"
|