mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-27 11:22:03 +00:00
Addresses review on #51077 (kxee). The continuable-cron mirror reused
gateway.mirror.mirror_to_session, which writes role=assistant — re-
introducing the exact alternation violation #2313 (37a997945)
deliberately removed: a cron brief landing as assistant after the
agent's last turn yields assistant->assistant, which breaks strict-
alternation providers (OpenAI/OpenRouter) per issue #2221. The mirror/
mirror_source metadata is also dropped at the SQLite boundary, so the
[Delivered from cron] label is lost on replay.
This is an intentional, opt-in (default OFF) reversal of #2313's
'cron output does not belong in interactive history' for the reply-to-
cron use case — gated behind cron.mirror_delivery / attach_to_session.
Fixes:
- mirror_to_session gains a role param (default 'assistant' — interactive
send_message mirror unchanged, it IS the agent speaking). Cron paths
pass role='user' with a '[Cron delivery: <task>]' prefix so the brief
collapses via repair_message_sequence's consecutive-user merge on every
provider, and stays distinguishable on replay despite the metadata drop.
- thread_seeded: defer seeding + the flag until delivery into the new
thread actually succeeds. Previously set pre-delivery, so an open-
succeeds / deliver-fails case both stranded a seeded-but-unseen brief
AND suppressed the DM-fallback mirror.
- seed mirror now passes user_id='system:cron' to resolve the exact
thread-keyed session row it just created.
- dedupe the duplicate BasePlatformAdapter import in _deliver_result.
- trim oversized docstrings to non-obvious WHY (AGENTS.md).
- docs: document cron.mirror_delivery / attach_to_session in
website/docs/user-guide/features/cron.md.
- test: assert the cron mirror writes role='user' with the label prefix.
204 cron+mirror tests pass.
184 lines
5.9 KiB
Python
184 lines
5.9 KiB
Python
"""
|
|
Session mirroring for cross-platform message delivery.
|
|
|
|
When a message is sent to a platform (via send_message or cron delivery),
|
|
this module appends a "delivery-mirror" record to the target session's
|
|
transcript so the receiving-side agent has context about what was sent.
|
|
|
|
Standalone -- works from CLI, cron, and gateway contexts without needing
|
|
the full SessionStore machinery.
|
|
"""
|
|
|
|
import json
|
|
import logging
|
|
from datetime import datetime
|
|
from typing import Optional
|
|
|
|
from hermes_cli.config import get_hermes_home
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
_SESSIONS_DIR = get_hermes_home() / "sessions"
|
|
_SESSIONS_INDEX = _SESSIONS_DIR / "sessions.json"
|
|
|
|
|
|
def mirror_to_session(
|
|
platform: str,
|
|
chat_id: str,
|
|
message_text: str,
|
|
source_label: str = "cli",
|
|
thread_id: Optional[str] = None,
|
|
user_id: Optional[str] = None,
|
|
role: str = "assistant",
|
|
) -> bool:
|
|
"""
|
|
Append a delivery-mirror message to the target session's transcript.
|
|
|
|
Finds the gateway session that matches the given platform + chat_id,
|
|
then writes a mirror entry to both the JSONL transcript and SQLite DB.
|
|
|
|
``role`` defaults to ``"assistant"`` — correct for the interactive
|
|
``send_message`` mirror, where the mirrored text is the agent's own
|
|
outgoing reply (a genuine assistant turn). Callers mirroring text that is
|
|
NOT the agent speaking — e.g. a cron brief delivered out-of-band — must
|
|
pass ``role="user"``: the ``mirror``/``mirror_source`` metadata is dropped
|
|
at the SQLite boundary (only role+content persist), so on replay an
|
|
assistant-role mirror is indistinguishable from a real assistant turn and
|
|
produces ``assistant → assistant`` pairs that break strict-alternation
|
|
providers (issue #2221). A user-role mirror collapses safely via
|
|
``repair_message_sequence``'s consecutive-user merge on every provider.
|
|
|
|
Returns True if mirrored successfully, False if no matching session or error.
|
|
All errors are caught -- this is never fatal.
|
|
"""
|
|
try:
|
|
session_id = _find_session_id(
|
|
platform,
|
|
str(chat_id),
|
|
thread_id=thread_id,
|
|
user_id=user_id,
|
|
)
|
|
if not session_id:
|
|
logger.debug(
|
|
"Mirror: no session found for %s:%s:%s:%s",
|
|
platform,
|
|
chat_id,
|
|
thread_id,
|
|
user_id,
|
|
)
|
|
return False
|
|
|
|
mirror_msg = {
|
|
"role": role,
|
|
"content": message_text,
|
|
"timestamp": datetime.now().isoformat(),
|
|
"mirror": True,
|
|
"mirror_source": source_label,
|
|
}
|
|
|
|
_append_to_sqlite(session_id, mirror_msg)
|
|
|
|
logger.debug("Mirror: wrote to session %s (from %s)", session_id, source_label)
|
|
return True
|
|
|
|
except Exception as e:
|
|
logger.debug(
|
|
"Mirror failed for %s:%s:%s:%s: %s",
|
|
platform,
|
|
chat_id,
|
|
thread_id,
|
|
user_id,
|
|
e,
|
|
)
|
|
return False
|
|
|
|
|
|
def _find_session_id(
|
|
platform: str,
|
|
chat_id: str,
|
|
thread_id: Optional[str] = None,
|
|
user_id: Optional[str] = None,
|
|
) -> Optional[str]:
|
|
"""
|
|
Find the active session_id for a platform + chat_id pair.
|
|
|
|
Scans sessions.json entries and matches where origin.chat_id == chat_id
|
|
on the right platform. DM session keys don't embed the chat_id
|
|
(e.g. "agent:main:telegram:dm"), so we check the origin dict.
|
|
|
|
When *user_id* is provided, prefer exact sender matches. If multiple
|
|
same-chat candidates exist and none matches the user, return None instead
|
|
of guessing and contaminating another participant's session.
|
|
"""
|
|
if not _SESSIONS_INDEX.exists():
|
|
return None
|
|
|
|
try:
|
|
with open(_SESSIONS_INDEX, encoding="utf-8") as f:
|
|
data = json.load(f)
|
|
except Exception:
|
|
return None
|
|
|
|
platform_lower = platform.lower()
|
|
candidates = []
|
|
|
|
for _key, entry in data.items():
|
|
# Skip documentation/metadata sentinels (keys starting with "_", e.g.
|
|
# the gateway's "_README" note) — they are not session entries.
|
|
if str(_key).startswith("_") or not isinstance(entry, dict):
|
|
continue
|
|
origin = entry.get("origin") or {}
|
|
entry_platform = (origin.get("platform") or entry.get("platform", "")).lower()
|
|
|
|
if entry_platform != platform_lower:
|
|
continue
|
|
|
|
origin_chat_id = str(origin.get("chat_id", ""))
|
|
if origin_chat_id == str(chat_id):
|
|
origin_thread_id = origin.get("thread_id")
|
|
if thread_id is not None and str(origin_thread_id or "") != str(thread_id):
|
|
continue
|
|
candidates.append(entry)
|
|
|
|
if not candidates:
|
|
return None
|
|
|
|
if user_id:
|
|
exact_user_matches = [
|
|
entry for entry in candidates
|
|
if str((entry.get("origin") or {}).get("user_id") or "") == str(user_id)
|
|
]
|
|
if exact_user_matches:
|
|
candidates = exact_user_matches
|
|
elif len(candidates) > 1:
|
|
return None
|
|
elif len(candidates) > 1:
|
|
distinct_user_ids = {
|
|
str((entry.get("origin") or {}).get("user_id") or "").strip()
|
|
for entry in candidates
|
|
if str((entry.get("origin") or {}).get("user_id") or "").strip()
|
|
}
|
|
if len(distinct_user_ids) > 1:
|
|
return None
|
|
|
|
best_entry = max(candidates, key=lambda entry: entry.get("updated_at", ""))
|
|
return best_entry.get("session_id")
|
|
|
|
|
|
|
|
def _append_to_sqlite(session_id: str, message: dict) -> None:
|
|
"""Append a message to the SQLite session database."""
|
|
db = None
|
|
try:
|
|
from hermes_state import SessionDB
|
|
db = SessionDB()
|
|
db.append_message(
|
|
session_id=session_id,
|
|
role=message.get("role", "assistant"),
|
|
content=message.get("content"),
|
|
)
|
|
except Exception as e:
|
|
logger.debug("Mirror SQLite write failed: %s", e)
|
|
finally:
|
|
if db is not None:
|
|
db.close()
|