mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
132 lines
5 KiB
Python
132 lines
5 KiB
Python
#!/usr/bin/env python3
|
|
"""Tests for the FAL.ai image generation plugin.
|
|
|
|
The plugin is a thin registration adapter — actual FAL pipeline logic
|
|
lives in ``tools.image_generation_tool`` and is exercised by
|
|
``tests/tools/test_image_generation.py``. These tests focus on:
|
|
|
|
* the ``ImageGenProvider`` ABC surface (name, models, schema)
|
|
* call-time indirection (``_it`` resolution at ``generate()`` time so
|
|
``monkeypatch.setattr(image_tool, ...)`` keeps working)
|
|
* response shape stamping (provider/prompt/aspect_ratio/model)
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from unittest.mock import MagicMock
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Provider surface
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestFalImageGenProviderSurface:
|
|
def test_name(self):
|
|
from plugins.image_gen.fal import FalImageGenProvider
|
|
|
|
assert FalImageGenProvider().name == "fal"
|
|
|
|
def test_display_name(self):
|
|
from plugins.image_gen.fal import FalImageGenProvider
|
|
|
|
assert FalImageGenProvider().display_name == "FAL.ai"
|
|
|
|
def test_default_model_matches_legacy(self):
|
|
from plugins.image_gen.fal import FalImageGenProvider
|
|
from tools.image_generation_tool import DEFAULT_MODEL
|
|
|
|
assert FalImageGenProvider().default_model() == DEFAULT_MODEL
|
|
|
|
def test_list_models_uses_legacy_catalog(self):
|
|
from plugins.image_gen.fal import FalImageGenProvider
|
|
from tools.image_generation_tool import FAL_MODELS
|
|
|
|
provider = FalImageGenProvider()
|
|
models = provider.list_models()
|
|
ids = {m["id"] for m in models}
|
|
# Whatever FAL_MODELS ships, the provider mirrors verbatim.
|
|
assert ids == set(FAL_MODELS.keys())
|
|
# Spot-check the expected first-class fields are present.
|
|
for entry in models:
|
|
for field in ("id", "display", "speed", "strengths", "price"):
|
|
assert field in entry
|
|
|
|
def test_setup_schema_advertises_fal_key(self):
|
|
from plugins.image_gen.fal import FalImageGenProvider
|
|
|
|
schema = FalImageGenProvider().get_setup_schema()
|
|
assert schema["name"] == "FAL.ai"
|
|
assert schema["badge"] == "paid"
|
|
env_keys = {entry["key"] for entry in schema.get("env_vars", [])}
|
|
assert "FAL_KEY" in env_keys
|
|
|
|
|
|
class TestFalImageGenProviderAvailability:
|
|
def test_is_available_when_legacy_check_passes(self, monkeypatch):
|
|
import tools.image_generation_tool as image_tool
|
|
from plugins.image_gen.fal import FalImageGenProvider
|
|
|
|
monkeypatch.setattr(image_tool, "check_fal_api_key", lambda: True)
|
|
assert FalImageGenProvider().is_available() is True
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# generate() — call-time indirection
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestFalImageGenProviderGenerate:
|
|
def test_generate_delegates_to_legacy_image_generate_tool(self, monkeypatch):
|
|
"""Plugin must look up ``image_generate_tool`` at call time so
|
|
``monkeypatch.setattr(image_tool, "image_generate_tool", ...)``
|
|
takes effect."""
|
|
import tools.image_generation_tool as image_tool
|
|
from plugins.image_gen.fal import FalImageGenProvider
|
|
|
|
captured = {}
|
|
|
|
def fake_image_generate_tool(prompt, aspect_ratio, **kwargs):
|
|
captured["prompt"] = prompt
|
|
captured["aspect_ratio"] = aspect_ratio
|
|
captured["kwargs"] = kwargs
|
|
return json.dumps({"success": True, "image": "https://fake/image.png"})
|
|
|
|
monkeypatch.setattr(image_tool, "image_generate_tool", fake_image_generate_tool)
|
|
monkeypatch.setattr(image_tool, "_resolve_fal_model",
|
|
lambda: ("fal-ai/flux-2/klein/9b", {}))
|
|
|
|
result = FalImageGenProvider().generate(
|
|
"a serene mountain landscape",
|
|
aspect_ratio="square",
|
|
seed=42,
|
|
)
|
|
|
|
assert captured["prompt"] == "a serene mountain landscape"
|
|
assert captured["aspect_ratio"] == "square"
|
|
assert captured["kwargs"] == {"seed": 42}
|
|
assert result["success"] is True
|
|
assert result["image"] == "https://fake/image.png"
|
|
# Stamped fields for the unified response shape
|
|
assert result["provider"] == "fal"
|
|
assert result["prompt"] == "a serene mountain landscape"
|
|
assert result["aspect_ratio"] == "square"
|
|
assert result["model"] == "fal-ai/flux-2/klein/9b"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Registry wiring
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestFalImageGenPluginRegistration:
|
|
def test_register_wires_provider_into_registry(self):
|
|
from plugins.image_gen.fal import FalImageGenProvider, register
|
|
|
|
ctx = MagicMock()
|
|
register(ctx)
|
|
|
|
ctx.register_image_gen_provider.assert_called_once()
|
|
(registered,), _ = ctx.register_image_gen_provider.call_args
|
|
assert isinstance(registered, FalImageGenProvider)
|