mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
57 lines
2 KiB
Python
57 lines
2 KiB
Python
"""Tests for Vertex AI runtime-provider resolution and profile registration.
|
|
|
|
Covers: provider-profile registration + aliases, alias canonicalization,
|
|
resolve_runtime_provider(vertex) minting an OAuth token, and the friendly
|
|
AuthError when credentials can't be resolved. No network calls.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_resolve_runtime_provider_raises_autherror_when_unresolved(monkeypatch):
|
|
import agent.vertex_adapter as va
|
|
from hermes_cli import runtime_provider as rp
|
|
from hermes_cli.auth import AuthError
|
|
|
|
monkeypatch.setattr(va, "get_vertex_config", lambda: (None, None))
|
|
with pytest.raises(AuthError) as exc:
|
|
rp.resolve_runtime_provider(requested="vertex")
|
|
msg = str(exc.value)
|
|
assert "OAuth2" in msg
|
|
assert "not a static API key" in msg
|
|
|
|
|
|
def test_vertex_registered_in_provider_registry():
|
|
"""PROVIDER_REGISTRY (hermes_cli.auth) is what agent/auxiliary_client.py's
|
|
resolve_provider_client() looks up before dispatching on auth_type. Without
|
|
an entry here, the ``elif pconfig.auth_type == "vertex":`` branch there is
|
|
unreachable dead code — every auxiliary Vertex call (vision, title
|
|
generation, MoA reference/aggregator slots, ...) fails at the
|
|
``pconfig is None`` guard before ever reaching it."""
|
|
from hermes_cli.auth import PROVIDER_REGISTRY
|
|
|
|
cfg = PROVIDER_REGISTRY.get("vertex")
|
|
assert cfg is not None
|
|
assert cfg.auth_type == "vertex"
|
|
|
|
|
|
def test_vertex_registered_in_hermes_overlays():
|
|
"""hermes_cli.providers.get_provider("vertex") backs
|
|
_preserve_provider_with_base_url() in agent/auxiliary_client.py, which
|
|
decides whether a MoA slot's resolved Vertex (base_url, api_key) pair
|
|
keeps its "vertex" provider identity or silently collapses to "custom" —
|
|
losing the identity _refresh_provider_credentials() needs to re-mint an
|
|
expired OAuth2 token on a 401."""
|
|
from hermes_cli.providers import get_provider
|
|
|
|
resolved = get_provider("vertex")
|
|
assert resolved is not None
|
|
assert resolved.auth_type == "vertex"
|