hermes-agent/tests/hermes_cli/test_configured_builtin_models.py
Teknium 6b81590c55
test: prune low-value tests suite-wide (wave 1) — 46,820 → 28,106 test functions
Systematic prune per AGENTS.md test policy, one pass over every major
test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli,
cron, tui_gateway, honcho/openviking, root-level):

- DELETE: source-reading tests (read_text/getsource on prod files),
  change-detector tests (exact catalog counts, model-name snapshots,
  config version literals), mock-echo tests (assert a mock returns what
  it was told), assertion-free/trivial tests, near-duplicate
  parametrizations (boundaries + one representative kept), async/sync
  twin duplicates, cosmetic within-file variations.
- KEEP (mandatory): security/redaction/approval guards, message-role
  alternation invariants, prompt-caching/deterministic-call-id
  invariants, issue-number regression tests (deduped), E2E tests.
- 6 test files deleted outright (script-style/no-assert or fully
  redundant); conftest.py, fakes/, fixtures/ untouched.
- tests/acp/conftest.py added: autouse fixture stubs the live
  models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server
  tests performed on every session create — test_server.py 147s → 3.4s,
  and the tests are now genuinely hermetic.
- Sleep-based slowness shrunk where safe (codex_ttfb_watchdog,
  compression_concurrent_fork, etc.); no wall-clock assertion tightened.

Verification: full hermetic suite via scripts/run_tests.sh —
2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall
(baseline: 583s wall, 13,564s subprocess CPU).
2026-07-29 13:10:23 -07:00

39 lines
1.3 KiB
Python

"""Configured models extend built-in picker rows."""
from unittest.mock import patch
from hermes_cli.model_switch import list_authenticated_providers
def _provider_row(configured_models, *, max_models=None):
with (
patch(
"agent.models_dev.fetch_models_dev",
return_value={"deepseek": {"env": ["DEEPSEEK_API_KEY"], "name": "DeepSeek"}},
),
patch(
"agent.models_dev.PROVIDER_TO_MODELS_DEV",
{"deepseek": "deepseek"},
),
patch(
"hermes_cli.models.cached_provider_model_ids",
return_value=["live-a", "shared"],
),
patch("hermes_cli.providers.HERMES_OVERLAYS", {}),
patch.dict("os.environ", {"DEEPSEEK_API_KEY": "test-key"}),
):
rows = list_authenticated_providers(
current_provider="deepseek",
user_providers={"deepseek": {"models": configured_models}},
max_models=max_models,
)
return next(row for row in rows if row["slug"] == "deepseek")
def test_configured_models_precede_and_deduplicate_discovered_models():
row = _provider_row({"configured-x": {}, "shared": {}})
assert row["models"] == ["configured-x", "shared", "live-a"]
assert row["total_models"] == 3