mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
52 lines
1.5 KiB
Python
52 lines
1.5 KiB
Python
"""Config `${env:VAR}` SecretRef parity (salvaged from PR #59516).
|
|
|
|
`${env:VAR}` already resolved in MCP server config (mcp_tool._env_ref_name);
|
|
config.yaml's expander treated it as a literal. These tests pin the parity
|
|
plus the cache-snapshot tracking and the non-env-source warning behavior.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.config import (
|
|
_env_ref_snapshot,
|
|
_env_ref_var_name,
|
|
_expand_env_vars,
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_value_containing_colon_is_not_a_source_ref(monkeypatch):
|
|
"""URL-ish or uppercase-colon refs are legacy bare names, not sources —
|
|
only a lowercase ident prefix counts as a SecretRef source."""
|
|
monkeypatch.delenv("MY:WEIRD", raising=False)
|
|
# Uppercase before ':' → treated as a bare (unset) var, kept verbatim,
|
|
# no misleading source warning.
|
|
assert _expand_env_vars("${MY:WEIRD}") == "${MY:WEIRD}"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _env_ref_var_name + snapshot tracking
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_snapshot_detects_rotation_for_env_prefixed(monkeypatch):
|
|
"""The #58514 cache-invalidation contract must hold for ${env:VAR} refs:
|
|
the snapshot records the value under the REAL var name, so a rotation
|
|
changes the snapshot."""
|
|
monkeypatch.setenv("PARITY_ROT", "before")
|
|
snap1 = _env_ref_snapshot({"k": "${env:PARITY_ROT}"})
|
|
monkeypatch.setenv("PARITY_ROT", "after")
|
|
snap2 = _env_ref_snapshot({"k": "${env:PARITY_ROT}"})
|
|
assert snap1 != snap2
|