mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
49 lines
1.7 KiB
Python
49 lines
1.7 KiB
Python
"""Tests for _clear_stale_openai_base_url() cleanup after provider switch (#5161)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
from hermes_cli.config import load_config, save_config, save_env_value, get_env_value
|
|
|
|
|
|
def _write_provider(provider: str, model: str = "test-model"):
|
|
"""Helper: write a provider + model to config.yaml."""
|
|
cfg = load_config()
|
|
model_cfg = cfg.get("model", {})
|
|
if not isinstance(model_cfg, dict):
|
|
model_cfg = {}
|
|
model_cfg["provider"] = provider
|
|
model_cfg["default"] = model
|
|
cfg["model"] = model_cfg
|
|
save_config(cfg)
|
|
|
|
|
|
class TestClearStaleOpenaiBaseUrl:
|
|
"""_clear_stale_openai_base_url() removes OPENAI_BASE_URL when provider is not custom."""
|
|
|
|
def test_clears_when_provider_is_named(self, monkeypatch):
|
|
"""OPENAI_BASE_URL is cleared when config provider is a named provider."""
|
|
from hermes_cli.main import _clear_stale_openai_base_url
|
|
|
|
_write_provider("openrouter")
|
|
save_env_value("OPENAI_BASE_URL", "http://localhost:11434/v1")
|
|
|
|
_clear_stale_openai_base_url()
|
|
|
|
result = get_env_value("OPENAI_BASE_URL")
|
|
assert not result, f"Expected OPENAI_BASE_URL to be cleared, got: {result!r}"
|
|
|
|
def test_preserves_when_provider_is_custom(self, monkeypatch):
|
|
"""OPENAI_BASE_URL is NOT cleared when config provider is 'custom'."""
|
|
from hermes_cli.main import _clear_stale_openai_base_url
|
|
|
|
_write_provider("custom")
|
|
save_env_value("OPENAI_BASE_URL", "http://localhost:11434/v1")
|
|
|
|
_clear_stale_openai_base_url()
|
|
|
|
result = get_env_value("OPENAI_BASE_URL")
|
|
assert result == "http://localhost:11434/v1", \
|
|
f"Expected OPENAI_BASE_URL to be preserved, got: {result!r}"
|
|
|
|
|