mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
69 lines
2 KiB
Python
69 lines
2 KiB
Python
"""Integration test: LSP layer is skipped on non-local backends.
|
|
|
|
The host-side LSP server can't see files inside a Docker/Modal/SSH
|
|
sandbox. When the agent's terminal env isn't ``LocalEnvironment``,
|
|
the file_operations layer must skip both ``snapshot_baseline`` and
|
|
``get_diagnostics_sync`` calls — falling back to the in-process
|
|
syntax check exactly as if LSP were disabled.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
|
|
from agent.lsp import eventlog
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset():
|
|
eventlog.reset_announce_caches()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_maybe_lsp_diagnostics_returns_empty_for_non_local(monkeypatch):
|
|
from tools.file_operations import ShellFileOperations
|
|
|
|
fake_env = MagicMock()
|
|
fake_env.execute = MagicMock(return_value=MagicMock(exit_code=0, stdout=""))
|
|
fake_env.cwd = "/sandbox"
|
|
fops = ShellFileOperations(fake_env)
|
|
|
|
called = []
|
|
|
|
class FakeService:
|
|
def enabled_for(self, path):
|
|
called.append(("enabled_for", path))
|
|
return True
|
|
def get_diagnostics_sync(self, path, **kw):
|
|
called.append(("get_diagnostics_sync", path))
|
|
return [{"severity": 1, "message": "should not see this"}]
|
|
|
|
monkeypatch.setattr("agent.lsp.get_service", lambda: FakeService())
|
|
|
|
result = fops._maybe_lsp_diagnostics("/sandbox/x.py")
|
|
assert result == ""
|
|
assert called == [], "service must not be queried for non-local backends"
|
|
|
|
|
|
def test_snapshot_baseline_called_for_local_env(tmp_path, monkeypatch):
|
|
from tools.environments.local import LocalEnvironment
|
|
from tools.file_operations import ShellFileOperations
|
|
|
|
fops = ShellFileOperations(LocalEnvironment(cwd=str(tmp_path)))
|
|
|
|
snapshot_called = []
|
|
|
|
class FakeService:
|
|
def snapshot_baseline(self, path):
|
|
snapshot_called.append(path)
|
|
|
|
monkeypatch.setattr("agent.lsp.get_service", lambda: FakeService())
|
|
|
|
fops._snapshot_lsp_baseline(str(tmp_path / "x.py"))
|
|
assert snapshot_called == [str(tmp_path / "x.py")]
|