mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-01 12:02:05 +00:00
a10113658b
Add a `pre_verify` user/plugin/shell hook fired once per turn when the agent
edited code and is about to finish, after the existing verify-on-stop guard. A
hook can keep the agent going one more turn (run a check, defer it, tidy the
diff) by returning {"action":"continue","message":...} (the Claude-Code Stop
shape {"decision":"block","reason":...} is accepted too). Hooks receive coding,
attempt, final_response, and sorted changed_paths so they can self-scope and
self-throttle; the path is bounded by agent.max_verify_nudges and preserves
message-role alternation.
Hermes still ships its default coding guidance (agent.verify_guidance, on by
default), but it now rides the evidence-based verify-on-stop missing-evidence
nudge instead of a separate default pre_verify continuation, so it costs no
extra model turn of its own. Guidance reuses the shared utils.is_truthy_value
parser rather than a local copy.
69 lines
2.6 KiB
Python
69 lines
2.6 KiB
Python
"""Verification-loop helpers for the ``pre_verify`` round-end gate.
|
|
|
|
When the agent has edited code and is about to verify/finish, the loop fires the
|
|
``pre_verify`` hook (user directives resolved by
|
|
:func:`hermes_cli.plugins.get_pre_verify_continue_message`). A directive keeps
|
|
the agent going one more turn — run a check, defer it, tidy the diff — instead of
|
|
stopping immediately.
|
|
|
|
The shipped coding guidance lives on the evidence-based verification-stop nudge
|
|
(``agent/verification_stop.py``), not as a second default stop gate. That keeps
|
|
the default token cost tied to the existing "missing verification evidence"
|
|
decision while preserving ``pre_verify`` for user/plugin policy.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import Any, Optional
|
|
|
|
from utils import is_truthy_value
|
|
|
|
DEFAULT_MAX_VERIFY_NUDGES = 3
|
|
|
|
# Shipped guidance appended to the verification-stop nudge when code lacks fresh
|
|
# verification evidence. Wording mirrors the user-facing "clean your work"
|
|
# workflow, but does not create its own extra model turn.
|
|
CODING_VERIFY_GUIDANCE = (
|
|
"[Coding] Before you run tests/linters or call this done: if this is "
|
|
"creative UI/visual work, hold off on tests and linters until the user says "
|
|
"they like the result or you're about to commit. And before every commit, "
|
|
"clean your work: keep it KISS/DRY, match the surrounding code style, and be "
|
|
"elitist, shorthand, clever, concise, efficient, and elegant."
|
|
)
|
|
|
|
|
|
def max_verify_nudges(config: Optional[dict[str, Any]] = None) -> int:
|
|
"""Bound on consecutive ``pre_verify`` continue directives per turn (>= 0)."""
|
|
agent_cfg = _agent_cfg(config)
|
|
raw = agent_cfg.get("max_verify_nudges")
|
|
try:
|
|
return max(0, int(raw))
|
|
except (TypeError, ValueError):
|
|
return DEFAULT_MAX_VERIFY_NUDGES
|
|
|
|
|
|
def coding_verify_guidance(config: Optional[dict[str, Any]] = None) -> Optional[str]:
|
|
"""Return the optional guidance appended to verification-stop nudges."""
|
|
if not is_truthy_value(_agent_cfg(config).get("verify_guidance", True), default=True):
|
|
return None
|
|
return CODING_VERIFY_GUIDANCE
|
|
|
|
|
|
def _agent_cfg(config: Optional[dict[str, Any]]) -> dict[str, Any]:
|
|
if config is None:
|
|
try:
|
|
from hermes_cli.config import load_config
|
|
|
|
config = load_config()
|
|
except Exception:
|
|
config = {}
|
|
agent_cfg = (config or {}).get("agent") if isinstance(config, dict) else None
|
|
return agent_cfg if isinstance(agent_cfg, dict) else {}
|
|
|
|
|
|
__all__ = [
|
|
"CODING_VERIFY_GUIDANCE",
|
|
"DEFAULT_MAX_VERIFY_NUDGES",
|
|
"coding_verify_guidance",
|
|
"max_verify_nudges",
|
|
]
|