mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-22 10:32:00 +00:00
f9ffe0bc3f
Native notifications (approval / sudo / secret / clarify) are tagged with the gateway *runtime* session id — the key under which the session lives in the gateway's in-memory `_sessions` map and the id every event carries (`tui_gateway/server.py` `_emit(event, sid, ...)`). The chat route, however, is keyed by the *stored* session id (`stored_session_id`), which is a different value: a new chat gets its runtime id immediately but its stored id only once the first turn persists. `onFocusSession` navigated straight to `sessionRoute(<runtime id>)`, so clicking a notification (e.g. an approval prompt) sent the route-resume path a runtime id where it expects a stored id. `useRouteResume` then resumed it as a stored session -> REST `/api/sessions/<runtime id>` 404 "session not found", and the running session was navigated away, which the user experiences as the session being destroyed. Translate runtime -> stored before navigating via the existing `runtimeIdByStoredSessionId` map (new `storedSessionIdForNotification` helper), falling back to the id as-is when no mapping is known. The Approve/Reject notification button path is untouched: `approval.respond` is routed by the runtime id (`_sess()` -> `_sessions[session_id]`), so it must keep carrying the runtime id.
26 lines
1.2 KiB
TypeScript
26 lines
1.2 KiB
TypeScript
// The gateway tags every event — and therefore every native notification —
|
|
// with the *runtime* session id (the key under which the session lives in the
|
|
// gateway's in-memory `_sessions` map). The chat route, however, is keyed by
|
|
// the *stored* session id (`stored_session_id`), which is a different value:
|
|
// a brand-new chat gets a runtime id immediately but its stored id is assigned
|
|
// when the first turn persists. Navigating to a runtime id therefore tries to
|
|
// resume a stored session that does not exist ("session not found") and
|
|
// strands the user, who experiences it as the running session being destroyed.
|
|
//
|
|
// `runtimeIdByStoredSessionId` maps stored -> runtime; this resolves the
|
|
// reverse so notification-click navigation lands on the real route. The id is
|
|
// returned unchanged when no mapping is known — it may already be a stored id
|
|
// (e.g. a notification for a session this window never opened), in which case
|
|
// the normal resume/REST lookup handles it.
|
|
export function storedSessionIdForNotification(
|
|
id: string,
|
|
runtimeIdByStoredSessionId: ReadonlyMap<string, string>
|
|
): string {
|
|
for (const [storedId, runtimeId] of runtimeIdByStoredSessionId) {
|
|
if (runtimeId === id) {
|
|
return storedId
|
|
}
|
|
}
|
|
|
|
return id
|
|
}
|