mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-29 18:46:59 +00:00
725c7ba534
The concept 'never send a turn that strict wire validation rejects as empty' was forked across four sites, each with its own predicate and its own blind spots: 1. build_assistant_message write-time ' ' pad — broke codex commentary turns (content:'' is a designed state), and a DB-side pad can't survive _rows_to_conversation's whitespace strip anyway. REMOVED. 2. conversation_loop send-time ' ' pad — main-loop only (summary path uncovered), ordering-fragile (had to run after whitespace normalization), assistant-only. REMOVED. 3. stream-stub '[response interrupted]' substitution — defeated the loop's empty-stub guard (the stub no longer looked empty, entered history, and the placeholder leaked into the stitched final response via truncated_response_parts). REMOVED. 4. repair_empty_non_final_messages in sanitize_api_messages — the unconditional pre-send chokepoint shared by the main loop AND the summary path, covers user and assistant turns, non-final only, copy-on-write. This is now the SINGLE OWNER. The owner's payload predicate (_msg_has_payload) is extended to treat codex_message_items / codex_reasoning_items as payload, so designed-empty codex commentary turns are never rewritten on any api_mode — the failure shape that broke site 1 in CI is encoded in the owner, not special-cased at a call site. Tests updated to pin the new contracts: builder stores textless turns as-is; the empty stream stub stays recognizably empty for the loop guard; poisoned resumed histories are repaired to the placeholder at the send boundary; codex item carriers are never rewritten. Sabotage-verified: unwiring the owner fails 3 regression tests.
1 line
8 B
Text
1 line
8 B
Text
aweiker
|