mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-08 13:12:08 +00:00
f0f8c84d1b
`serve` (added in #54568) reused cmd_dashboard wholesale, so it still behaved like a dashboard: it ran a full vite build every launch, mounted and served the SPA whenever a stray web_dist/ existed, printed "Hermes Web UI →", and announced HERMES_DASHBOARD_READY. It's the headless JSON-RPC/WS backend the desktop app and remote clients run — pure socket clients that never load the browser SPA. Mark serve with headless_backend=True (resolved once in cmd_dashboard) and: - skip _build_web_ui entirely on the serve path - export HERMES_SERVE_HEADLESS=1 so mount_spa() disables the SPA even when a dist is present — only the JSON-RPC/WS/API surface is reachable - announce the bind ("Hermes backend listening on host:port") instead of a browser/auth-gated URL - print a neutral HERMES_BACKEND_READY sentinel; dashboard keeps the legacy one and the desktop port-discovery regex matches either - preserve serve across the named-profile re-exec so it can't rebuild as dashboard `hermes dashboard` is unchanged (builds + serves the browser UI). Backward compatible: old apps only ever spawn dashboard (legacy token + UI intact) and never invoke serve; the ready-file side channel is name-agnostic. The one behavior change is that a remote `hermes serve` no longer serves the browser dashboard as a side effect — that's `hermes dashboard`'s job. Tests: serve headless_backend contract, SPA-disabled-with-dist, the HERMES_BACKEND_READY desktop parse (17/17 node), and the existing serve/dashboard/web_server suites. AGENTS.md documents the behavior.
70 lines
2.5 KiB
Python
70 lines
2.5 KiB
Python
"""Contract for the headless ``hermes serve`` backend command.
|
|
|
|
``serve`` is what the desktop app and remote backends launch — the same gateway
|
|
as ``dashboard`` (shared handler) but always headless, and decoupled in name so
|
|
the desktop never invokes ``dashboard``. These tests pin that contract:
|
|
|
|
- ``serve`` routes to the same handler as ``dashboard``;
|
|
- ``serve`` is headless by default, ``dashboard`` is not;
|
|
- both expose the identical server-runtime flag surface.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
|
|
from hermes_cli.subcommands.dashboard import build_dashboard_parser
|
|
|
|
|
|
def _dash(args): # sentinel handler — identity-compared, never invoked
|
|
return args
|
|
|
|
|
|
def _register(args):
|
|
return args
|
|
|
|
|
|
def _parser() -> argparse.ArgumentParser:
|
|
parser = argparse.ArgumentParser()
|
|
build_dashboard_parser(
|
|
parser.add_subparsers(dest="command"),
|
|
cmd_dashboard=_dash,
|
|
cmd_dashboard_register=_register,
|
|
)
|
|
return parser
|
|
|
|
|
|
def test_serve_routes_to_the_shared_dashboard_handler():
|
|
args = _parser().parse_args(["serve"])
|
|
assert args.func is _dash
|
|
|
|
|
|
def test_serve_is_headless_by_default_but_dashboard_is_not():
|
|
assert _parser().parse_args(["serve"]).no_open is True
|
|
assert _parser().parse_args(["dashboard"]).no_open is False
|
|
|
|
|
|
def test_serve_accepts_the_legacy_no_open_flag_as_a_noop():
|
|
# The desktop backend spawn (and old shells) may still pass --no-open;
|
|
# serve must tolerate it rather than erroring on an unknown argument.
|
|
assert _parser().parse_args(["serve", "--no-open"]).no_open is True
|
|
|
|
|
|
def test_serve_takes_the_same_runtime_flags_as_dashboard():
|
|
argv = ["--host", "0.0.0.0", "--port", "0", "--insecure", "--skip-build", "--isolated"]
|
|
serve = _parser().parse_args(["serve", *argv])
|
|
dash = _parser().parse_args(["dashboard", *argv])
|
|
for field in ("host", "port", "insecure", "skip_build", "isolated"):
|
|
assert getattr(serve, field) == getattr(dash, field)
|
|
|
|
|
|
def test_serve_supports_the_lifecycle_flags():
|
|
for flag in ("--stop", "--status"):
|
|
assert getattr(_parser().parse_args(["serve", flag]), flag.lstrip("-")) is True
|
|
|
|
|
|
def test_serve_is_a_headless_backend_but_dashboard_is_not():
|
|
# `headless_backend` is the flag cmd_dashboard reads to skip the web UI
|
|
# build; only `serve` carries it.
|
|
assert getattr(_parser().parse_args(["serve"]), "headless_backend", False) is True
|
|
assert getattr(_parser().parse_args(["dashboard"]), "headless_backend", False) is False
|