mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-20 15:33:54 +00:00
244f70aae5
Follow-up on the salvaged #64611 commit: the original guard blocked the install tree unconditionally, which would have broken the legitimate 'developing Hermes from a source clone' CLI flow (launching hermes inside the repo and getting its AGENTS.md as project context). Refined policy: - resolve_context_cwd(): validates configured paths (missing dir -> None + warning) but honors an EXPLICIT install-tree cwd verbatim — deliberate user choice. - build_context_files_prompt(): blocks only the cwd=None -> os.getcwd() FALLBACK into the install tree, with a new allow_install_tree_fallback param. system_prompt.py passes it for platform cli/tui (launch dir is the user's real shell cwd there); desktop/gateway surfaces keep the guard (their fallback dir is self-spawned, never user-picked). - Warning log names the resolved dir and the terminal.cwd remedy. E2E-verified all five scenarios: desktop fallback blocked, in-tree CLI dev keeps AGENTS.md, explicit install-tree cwd honored, invalid TERMINAL_CWD falls to None then blocked, normal workspace loads.
100 lines
3.6 KiB
Python
100 lines
3.6 KiB
Python
"""Single source of truth for the agent working directory.
|
|
|
|
`TERMINAL_CWD` is the runtime carrier for the configured working directory
|
|
(design #19214/#19242: `terminal.cwd` is bridged once to `TERMINAL_CWD` at
|
|
gateway/cron startup). The local-CLI backend deliberately leaves it unset and
|
|
relies on the launch dir. Reading it in one place keeps the system prompt, the
|
|
tool surfaces, and context-file discovery agreeing on where the agent lives.
|
|
|
|
Multi-session gateways can pin a logical cwd via the `_SESSION_CWD`
|
|
contextvar; CLI/cron fall through to `TERMINAL_CWD`/launch cwd.
|
|
"""
|
|
|
|
import logging
|
|
import os
|
|
from contextvars import ContextVar, Token
|
|
from pathlib import Path
|
|
from typing import Any
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
_UNSET: Any = object()
|
|
|
|
_SESSION_CWD: ContextVar = ContextVar("HERMES_SESSION_CWD", default=_UNSET)
|
|
|
|
# The Python package/source root (this file lives at <root>/agent/runtime_cwd.py).
|
|
# When a backend is launched from, or self-spawns into, this tree (the desktop
|
|
# app default), an os.getcwd() fallback would inject this repo's contributor
|
|
# AGENTS.md as authoritative project context. Context discovery must never
|
|
# resolve here.
|
|
_PACKAGE_ROOT = Path(__file__).resolve().parent.parent
|
|
|
|
|
|
def _is_install_tree(p: Path) -> bool:
|
|
# True only when p IS the package root or sits inside it. Ancestors of the
|
|
# package root (a user home that happens to contain the checkout, a --user
|
|
# site-packages parent) are legitimate workspaces and must not be blocked.
|
|
try:
|
|
p = p.resolve()
|
|
except Exception:
|
|
return False
|
|
return p == _PACKAGE_ROOT or _PACKAGE_ROOT in p.parents
|
|
|
|
|
|
def set_session_cwd(cwd: str | None) -> Token:
|
|
"""Pin the logical cwd for the current context."""
|
|
return _SESSION_CWD.set((cwd or "").strip())
|
|
|
|
|
|
def clear_session_cwd() -> None:
|
|
_SESSION_CWD.set("")
|
|
|
|
|
|
def _session_cwd_override() -> str:
|
|
value = _SESSION_CWD.get()
|
|
if value is _UNSET:
|
|
return ""
|
|
return str(value).strip()
|
|
|
|
|
|
def resolve_agent_cwd() -> Path:
|
|
override = _session_cwd_override()
|
|
if override:
|
|
p = Path(override).expanduser()
|
|
if p.is_dir():
|
|
return p
|
|
logger.warning("configured working directory does not exist: %s", override)
|
|
raw = os.environ.get("TERMINAL_CWD", "").strip()
|
|
if raw:
|
|
p = Path(raw).expanduser()
|
|
if p.is_dir():
|
|
return p
|
|
logger.warning("TERMINAL_CWD does not exist: %s", raw)
|
|
return Path(os.getcwd())
|
|
|
|
|
|
def resolve_context_cwd() -> Path | None:
|
|
# None means "no configured cwd": build_context_files_prompt then falls back
|
|
# to the launch dir (os.getcwd()), correct for a local CLI launched inside a
|
|
# real project. A configured path is validated here (previously it was passed
|
|
# through unchecked, diverging from resolve_agent_cwd). An explicitly
|
|
# configured path is otherwise honored verbatim — including the Hermes
|
|
# source tree itself, which is a legitimate workspace when the user is
|
|
# developing Hermes (per-surface policy for fallback-picked directories
|
|
# lives in build_context_files_prompt; see #64590).
|
|
override = _session_cwd_override()
|
|
if override:
|
|
p = Path(override).expanduser()
|
|
if not p.is_dir():
|
|
logger.warning("configured working directory does not exist: %s", override)
|
|
else:
|
|
return p
|
|
return None
|
|
raw = os.environ.get("TERMINAL_CWD", "").strip()
|
|
if raw:
|
|
p = Path(raw).expanduser()
|
|
if not p.is_dir():
|
|
logger.warning("TERMINAL_CWD does not exist: %s", raw)
|
|
else:
|
|
return p
|
|
return None
|