mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
69 lines
2.7 KiB
Python
69 lines
2.7 KiB
Python
"""Tests for cloud browser provider runtime fallback to local Chromium.
|
|
|
|
Covers the fallback logic in _get_session_info() when a cloud provider
|
|
is configured but fails at runtime (issue #10883).
|
|
"""
|
|
import logging
|
|
from unittest.mock import Mock
|
|
|
|
import pytest
|
|
|
|
import tools.browser_tool as browser_tool
|
|
|
|
|
|
def _reset_session_state(monkeypatch):
|
|
"""Clear caches so each test starts fresh."""
|
|
monkeypatch.setattr(browser_tool, "_active_sessions", {})
|
|
monkeypatch.setattr(browser_tool, "_cached_cloud_provider", None)
|
|
monkeypatch.setattr(browser_tool, "_cloud_provider_resolved", False)
|
|
monkeypatch.setattr(browser_tool, "_start_browser_cleanup_thread", lambda: None)
|
|
monkeypatch.setattr(browser_tool, "_update_session_activity", lambda t: None)
|
|
|
|
|
|
class TestCloudProviderRuntimeFallback:
|
|
"""Tests for _get_session_info cloud → local fallback."""
|
|
|
|
def test_cloud_failure_falls_back_to_local(self, monkeypatch):
|
|
"""When cloud provider.create_session raises, fall back to local."""
|
|
_reset_session_state(monkeypatch)
|
|
|
|
provider = Mock()
|
|
provider.create_session.side_effect = RuntimeError("401 Unauthorized")
|
|
monkeypatch.setattr(browser_tool, "_get_cloud_provider", lambda: provider)
|
|
monkeypatch.setattr(browser_tool, "_get_cdp_override", lambda: None)
|
|
|
|
session = browser_tool._get_session_info("task-1")
|
|
|
|
assert session["fallback_from_cloud"] is True
|
|
assert "401 Unauthorized" in session["fallback_reason"]
|
|
assert session["fallback_provider"] == "Mock"
|
|
assert session["features"]["local"] is True
|
|
assert session["cdp_url"] is None
|
|
|
|
|
|
def test_no_provider_uses_local_directly(self, monkeypatch):
|
|
"""When no cloud provider is configured, local mode is used with no fallback markers."""
|
|
_reset_session_state(monkeypatch)
|
|
|
|
monkeypatch.setattr(browser_tool, "_get_cloud_provider", lambda: None)
|
|
monkeypatch.setattr(browser_tool, "_get_cdp_override", lambda: None)
|
|
|
|
session = browser_tool._get_session_info("task-4")
|
|
|
|
assert session["features"]["local"] is True
|
|
assert "fallback_from_cloud" not in session
|
|
|
|
|
|
def test_cloud_returns_invalid_session_triggers_fallback(self, monkeypatch):
|
|
"""Cloud provider returning None or empty dict triggers fallback."""
|
|
_reset_session_state(monkeypatch)
|
|
|
|
provider = Mock()
|
|
provider.create_session.return_value = None
|
|
monkeypatch.setattr(browser_tool, "_get_cloud_provider", lambda: provider)
|
|
monkeypatch.setattr(browser_tool, "_get_cdp_override", lambda: None)
|
|
|
|
session = browser_tool._get_session_info("task-7")
|
|
|
|
assert session["fallback_from_cloud"] is True
|
|
assert "invalid session" in session["fallback_reason"]
|