mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-11 13:41:53 +00:00
b080b93ad8
Add platforms.slack.extra.rich_blocks (default off). When enabled, the final agent message is sent as Slack Block Kit blocks — section headers, dividers, and true nested lists via rich_text — instead of flat mrkdwn. - New plugins/platforms/slack/block_kit.py: pure markdown->blocks renderer (headers, dividers, nested ordered/bullet lists, blockquotes, fenced code; pipe-tables as aligned monospace since Block Kit has no robust table block). Enforces Slack's 50-block / 3000-char section limits and returns None to fall back to plain text on empty/oversized/unexpected input. Never raises. - adapter.send(): render blocks on the single-chunk primary message; a text= fallback is ALWAYS sent alongside (notifications/accessibility). - adapter.edit_message(): blocks only on finalize=True, so intermediate streaming edits stay plain mrkdwn (no per-flush block re-derivation). - Docs (EN + zh-Hans) + config example. Send-side only: no app reinstall. Tests: pure-renderer unit suite + adapter integration suite (blocks present when on, plain text when off, text fallback always set, finalize gating, multi-chunk fallback). Prove-failed against a stubbed renderer.
102 lines
4 KiB
Python
102 lines
4 KiB
Python
"""Integration tests: SlackAdapter wiring of Block Kit into send paths.
|
|
|
|
Verifies the opt-in behaviour contract:
|
|
* rich_blocks off (default) => no ``blocks`` kwarg, plain ``text`` only
|
|
* rich_blocks on => ``blocks`` present AND ``text`` fallback set
|
|
* edit_message: blocks only on finalize (streaming edits stay plain)
|
|
* multi-chunk (>39k) messages fall back to plain text
|
|
"""
|
|
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
|
|
from gateway.config import PlatformConfig
|
|
from plugins.platforms.slack.adapter import SlackAdapter
|
|
|
|
|
|
def _make_adapter(extra=None):
|
|
config = PlatformConfig(enabled=True, token="xoxb-fake", extra=extra or {})
|
|
a = SlackAdapter(config)
|
|
a._app = MagicMock()
|
|
client = AsyncMock()
|
|
client.chat_postMessage = AsyncMock(return_value={"ts": "111.222"})
|
|
client.chat_update = AsyncMock(return_value={"ts": "111.222"})
|
|
a._get_client = MagicMock(return_value=client)
|
|
a.stop_typing = AsyncMock()
|
|
a._running = True
|
|
return a, client
|
|
|
|
|
|
RICH_MD = "# Title\n\n- a\n - nested\n\n---\n\nbody text"
|
|
|
|
|
|
class TestSendMessageBlocks:
|
|
@pytest.mark.asyncio
|
|
async def test_disabled_by_default_no_blocks(self):
|
|
adapter, client = _make_adapter()
|
|
await adapter.send("C1", RICH_MD)
|
|
kwargs = client.chat_postMessage.await_args.kwargs
|
|
assert "blocks" not in kwargs
|
|
assert kwargs["text"] # plain text still sent
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_enabled_sends_blocks_with_text_fallback(self):
|
|
adapter, client = _make_adapter({"rich_blocks": True})
|
|
await adapter.send("C1", RICH_MD)
|
|
kwargs = client.chat_postMessage.await_args.kwargs
|
|
assert "blocks" in kwargs and kwargs["blocks"]
|
|
# text fallback is ALWAYS present alongside blocks (notifications/a11y)
|
|
assert kwargs["text"]
|
|
types = [b["type"] for b in kwargs["blocks"]]
|
|
assert "header" in types
|
|
assert "divider" in types
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_enabled_but_unrenderable_falls_back_to_text(self):
|
|
# 60 dividers -> renderer returns None -> no blocks kwarg, text stands
|
|
adapter, client = _make_adapter({"rich_blocks": True})
|
|
await adapter.send("C1", "\n\n".join(["---"] * 60))
|
|
kwargs = client.chat_postMessage.await_args.kwargs
|
|
assert "blocks" not in kwargs
|
|
assert kwargs["text"]
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_string_true_coerced(self):
|
|
adapter, client = _make_adapter({"rich_blocks": "true"})
|
|
await adapter.send("C1", RICH_MD)
|
|
assert "blocks" in client.chat_postMessage.await_args.kwargs
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_multichunk_message_no_blocks(self):
|
|
adapter, client = _make_adapter({"rich_blocks": True})
|
|
huge = "word " * 20000 # well over MAX_MESSAGE_LENGTH -> chunked
|
|
await adapter.send("C1", huge)
|
|
# every posted chunk is plain text, none carry blocks
|
|
for c in client.chat_postMessage.await_args_list:
|
|
assert "blocks" not in c.kwargs
|
|
assert c.kwargs["text"]
|
|
|
|
|
|
class TestEditMessageBlocks:
|
|
@pytest.mark.asyncio
|
|
async def test_intermediate_edit_no_blocks(self):
|
|
adapter, client = _make_adapter({"rich_blocks": True})
|
|
await adapter.edit_message("C1", "111.222", RICH_MD, finalize=False)
|
|
kwargs = client.chat_update.await_args.kwargs
|
|
assert "blocks" not in kwargs
|
|
assert kwargs["text"]
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_finalize_edit_gets_blocks(self):
|
|
adapter, client = _make_adapter({"rich_blocks": True})
|
|
await adapter.edit_message("C1", "111.222", RICH_MD, finalize=True)
|
|
kwargs = client.chat_update.await_args.kwargs
|
|
assert "blocks" in kwargs and kwargs["blocks"]
|
|
assert kwargs["text"]
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_finalize_edit_disabled_no_blocks(self):
|
|
adapter, client = _make_adapter() # rich_blocks off
|
|
await adapter.edit_message("C1", "111.222", RICH_MD, finalize=True)
|
|
assert "blocks" not in client.chat_update.await_args.kwargs
|