mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-30 06:41:51 +00:00
Condenses the substance of PRs #16453, #17453, #16451, #17600, and #13373 into a minimal generic host contract that external context engine plugins (e.g. hermes-lcm) need to integrate cleanly. Drops scaffolding that duplicated existing infrastructure or had marginal value. Five concrete changes: 1. `_transition_context_engine_session()` on AIAgent — generic lifecycle helper that fires on_session_end → on_session_reset → on_session_start → optional carry_over_new_session_context. Engines implement only the hooks they need; missing hooks are skipped. Built-in compressor keeps its existing reset-only behavior because callers default to no metadata. `reset_session_state()` now optionally accepts previous_messages / old_session_id / carry_over_context and delegates to the transition helper when provided. (#16453) 2. `conversation_id` passed to `on_session_start()` — both the agent-init call site and the compression-boundary call site now forward `self._gateway_session_key` so plugin engines have a stable conversation identity that survives session_id rotation (compression splits, /new, resume). The key already existed on AIAgent; it just wasn't reaching engines. (#16453) 3. Canonical cache buckets forwarded to engines — the usage dict passed to `update_from_response()` now includes input_tokens, output_tokens, cache_read_tokens, cache_write_tokens, and reasoning_tokens on top of the legacy prompt/completion/total keys. Engines can make decisions on cache-hit ratios and reasoning costs instead of only aggregates. ABC docstring updated. (#17453) 4. Plugin-registered context engines visible in the picker — `_discover_context_engines()` in plugins_cmd.py now also includes engines registered via `ctx.register_context_engine()` from plugin manifests, deduplicating by name so repo-shipped descriptions win on collision. (#16451) 5. `_EngineCollector.register_command()` — context engines using the standard `register(ctx)` pattern can now expose slash commands (e.g. `/lcm`). Routes to the global plugin command registry with the same conflict-rejection policy regular plugins use (no shadowing built-ins, no clobbering other plugins). Previously these calls hit a no-op and the slash commands silently never appeared. (#17600) Dropped from the original 5 PRs: - Compression boundary signal (`boundary_reason="compression"`) from #16453 — already on main at `agent/conversation_compression.py:412-424`, landed via the bg-review extraction. - `discover_plugins()` before fallback in run_agent.py from #16451 — redundant: `get_plugin_context_engine()` already routes through `_ensure_plugins_discovered()` which is idempotent. - Runtime identity diagnostics method + helpers from #13373 (+251 LOC) — operators can already read engine state via `engine.get_status()`; the diagnostics view added marginal value relative to its surface area. - The 553-LOC slash-command machinery from #17600 — replaced with a 20-LOC `register_command` method on the collector that reuses the existing plugin command registry instead of building a parallel one. Net: ~215 LOC of host-contract changes + 282 LOC of focused tests, vs ~1,176 LOC across the original 5 PRs. Co-authored-by: Tosko4 <1294707+Tosko4@users.noreply.github.com> Closes #16453. Closes #17453. Closes #16451. Closes #17600. Closes #13373. Related: stephenschoettler/hermes-lcm#68.
285 lines
10 KiB
Python
285 lines
10 KiB
Python
"""Context engine plugin discovery.
|
|
|
|
Scans ``plugins/context_engine/<name>/`` directories for context engine
|
|
plugins. Each subdirectory must contain ``__init__.py`` with a class
|
|
implementing the ContextEngine ABC.
|
|
|
|
Context engines are separate from the general plugin system — they live
|
|
in the repo and are always available without user installation. Only ONE
|
|
can be active at a time, selected via ``context.engine`` in config.yaml.
|
|
The default engine is ``"compressor"`` (the built-in ContextCompressor).
|
|
|
|
Usage:
|
|
from plugins.context_engine import discover_context_engines, load_context_engine
|
|
|
|
available = discover_context_engines() # [(name, desc, available), ...]
|
|
engine = load_context_engine("lcm") # ContextEngine instance
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib
|
|
import importlib.util
|
|
import logging
|
|
import sys
|
|
from pathlib import Path
|
|
from typing import List, Optional, Tuple
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
_CONTEXT_ENGINE_PLUGINS_DIR = Path(__file__).parent
|
|
|
|
|
|
def discover_context_engines() -> List[Tuple[str, str, bool]]:
|
|
"""Scan plugins/context_engine/ for available engines.
|
|
|
|
Returns list of (name, description, is_available) tuples.
|
|
Does NOT import the engines — just reads plugin.yaml for metadata
|
|
and does a lightweight availability check.
|
|
"""
|
|
results = []
|
|
if not _CONTEXT_ENGINE_PLUGINS_DIR.is_dir():
|
|
return results
|
|
|
|
for child in sorted(_CONTEXT_ENGINE_PLUGINS_DIR.iterdir()):
|
|
if not child.is_dir() or child.name.startswith(("_", ".")):
|
|
continue
|
|
init_file = child / "__init__.py"
|
|
if not init_file.exists():
|
|
continue
|
|
|
|
# Read description from plugin.yaml if available
|
|
desc = ""
|
|
yaml_file = child / "plugin.yaml"
|
|
if yaml_file.exists():
|
|
try:
|
|
import yaml
|
|
with open(yaml_file, encoding="utf-8-sig") as f:
|
|
meta = yaml.safe_load(f) or {}
|
|
desc = meta.get("description", "")
|
|
except Exception:
|
|
pass
|
|
|
|
# Quick availability check — try loading and calling is_available()
|
|
available = True
|
|
try:
|
|
engine = _load_engine_from_dir(child)
|
|
if engine is None:
|
|
available = False
|
|
elif hasattr(engine, "is_available"):
|
|
available = engine.is_available()
|
|
except Exception:
|
|
available = False
|
|
|
|
results.append((child.name, desc, available))
|
|
|
|
return results
|
|
|
|
|
|
def load_context_engine(name: str) -> Optional["ContextEngine"]:
|
|
"""Load and return a ContextEngine instance by name.
|
|
|
|
Returns None if the engine is not found or fails to load.
|
|
"""
|
|
engine_dir = _CONTEXT_ENGINE_PLUGINS_DIR / name
|
|
if not engine_dir.is_dir():
|
|
logger.debug("Context engine '%s' not found in %s", name, _CONTEXT_ENGINE_PLUGINS_DIR)
|
|
return None
|
|
|
|
try:
|
|
engine = _load_engine_from_dir(engine_dir)
|
|
if engine:
|
|
return engine
|
|
logger.warning("Context engine '%s' loaded but no engine instance found", name)
|
|
return None
|
|
except Exception as e:
|
|
logger.warning("Failed to load context engine '%s': %s", name, e)
|
|
return None
|
|
|
|
|
|
def _load_engine_from_dir(engine_dir: Path) -> Optional["ContextEngine"]:
|
|
"""Import an engine module and extract the ContextEngine instance.
|
|
|
|
The module must have either:
|
|
- A register(ctx) function (plugin-style) — we simulate a ctx
|
|
- A top-level class that extends ContextEngine — we instantiate it
|
|
"""
|
|
name = engine_dir.name
|
|
module_name = f"plugins.context_engine.{name}"
|
|
init_file = engine_dir / "__init__.py"
|
|
|
|
if not init_file.exists():
|
|
return None
|
|
|
|
# Check if already loaded
|
|
if module_name in sys.modules:
|
|
mod = sys.modules[module_name]
|
|
else:
|
|
# Handle relative imports within the plugin
|
|
# First ensure the parent packages are registered
|
|
for parent in ("plugins", "plugins.context_engine"):
|
|
if parent not in sys.modules:
|
|
parent_path = Path(__file__).parent
|
|
if parent == "plugins":
|
|
parent_path = parent_path.parent
|
|
parent_init = parent_path / "__init__.py"
|
|
if parent_init.exists():
|
|
spec = importlib.util.spec_from_file_location(
|
|
parent, str(parent_init),
|
|
submodule_search_locations=[str(parent_path)]
|
|
)
|
|
if spec:
|
|
parent_mod = importlib.util.module_from_spec(spec)
|
|
sys.modules[parent] = parent_mod
|
|
try:
|
|
spec.loader.exec_module(parent_mod)
|
|
except Exception:
|
|
pass
|
|
|
|
# Now load the engine module
|
|
spec = importlib.util.spec_from_file_location(
|
|
module_name, str(init_file),
|
|
submodule_search_locations=[str(engine_dir)]
|
|
)
|
|
if not spec:
|
|
return None
|
|
|
|
mod = importlib.util.module_from_spec(spec)
|
|
sys.modules[module_name] = mod
|
|
|
|
# Register submodules so relative imports work
|
|
for sub_file in engine_dir.glob("*.py"):
|
|
if sub_file.name == "__init__.py":
|
|
continue
|
|
sub_name = sub_file.stem
|
|
full_sub_name = f"{module_name}.{sub_name}"
|
|
if full_sub_name not in sys.modules:
|
|
sub_spec = importlib.util.spec_from_file_location(
|
|
full_sub_name, str(sub_file)
|
|
)
|
|
if sub_spec:
|
|
sub_mod = importlib.util.module_from_spec(sub_spec)
|
|
sys.modules[full_sub_name] = sub_mod
|
|
try:
|
|
sub_spec.loader.exec_module(sub_mod)
|
|
except Exception as e:
|
|
logger.debug("Failed to load submodule %s: %s", full_sub_name, e)
|
|
|
|
try:
|
|
spec.loader.exec_module(mod)
|
|
except Exception as e:
|
|
logger.debug("Failed to exec_module %s: %s", module_name, e)
|
|
sys.modules.pop(module_name, None)
|
|
return None
|
|
|
|
# Try register(ctx) pattern first (how plugins are written)
|
|
if hasattr(mod, "register"):
|
|
collector = _EngineCollector(engine_name=name)
|
|
try:
|
|
mod.register(collector)
|
|
if collector.engine:
|
|
return collector.engine
|
|
except Exception as e:
|
|
logger.debug("register() failed for %s: %s", name, e)
|
|
|
|
# Fallback: find a ContextEngine subclass and instantiate it
|
|
from agent.context_engine import ContextEngine
|
|
for attr_name in dir(mod):
|
|
attr = getattr(mod, attr_name, None)
|
|
if (isinstance(attr, type) and issubclass(attr, ContextEngine)
|
|
and attr is not ContextEngine):
|
|
try:
|
|
return attr()
|
|
except Exception:
|
|
pass
|
|
|
|
return None
|
|
|
|
|
|
class _EngineCollector:
|
|
"""Fake plugin context that captures register_context_engine calls.
|
|
|
|
Plugin context engines using the standard ``register(ctx)`` pattern may
|
|
also call ``ctx.register_command(...)`` to expose slash commands (e.g.
|
|
``/lcm``). Forward those to the global plugin command registry so they
|
|
behave identically to commands registered by normal plugins.
|
|
"""
|
|
|
|
def __init__(self, engine_name: str = ""):
|
|
self.engine = None
|
|
self._engine_name = engine_name or "context_engine"
|
|
self._registered_commands: list[str] = []
|
|
|
|
def register_context_engine(self, engine):
|
|
self.engine = engine
|
|
|
|
def register_command(
|
|
self,
|
|
name: str,
|
|
handler,
|
|
description: str = "",
|
|
args_hint: str = "",
|
|
) -> None:
|
|
"""Forward to the global plugin command registry."""
|
|
clean = (name or "").lower().strip().lstrip("/").replace(" ", "-")
|
|
if not clean:
|
|
logger.warning(
|
|
"Context engine '%s' tried to register a command with an empty name.",
|
|
self._engine_name,
|
|
)
|
|
return
|
|
|
|
# Reject conflicts with built-in commands.
|
|
try:
|
|
from hermes_cli.commands import resolve_command
|
|
if resolve_command(clean) is not None:
|
|
logger.warning(
|
|
"Context engine '%s' tried to register command '/%s' which conflicts "
|
|
"with a built-in command. Skipping.",
|
|
self._engine_name, clean,
|
|
)
|
|
return
|
|
except Exception:
|
|
pass
|
|
|
|
try:
|
|
from hermes_cli.plugins import get_plugin_manager
|
|
manager = get_plugin_manager()
|
|
if clean in manager._plugin_commands:
|
|
# Don't clobber a regular plugin's command — same conflict
|
|
# policy the plugin system uses for plugin-vs-plugin collisions.
|
|
logger.warning(
|
|
"Context engine '%s' tried to register command '/%s' which "
|
|
"is already registered by a plugin. Skipping.",
|
|
self._engine_name, clean,
|
|
)
|
|
return
|
|
manager._plugin_commands[clean] = {
|
|
"handler": handler,
|
|
"description": description or "Context engine command",
|
|
"plugin": f"context-engine:{self._engine_name}",
|
|
"args_hint": (args_hint or "").strip(),
|
|
}
|
|
self._registered_commands.append(clean)
|
|
logger.debug(
|
|
"Context engine '%s' registered command: /%s",
|
|
self._engine_name, clean,
|
|
)
|
|
except Exception as exc:
|
|
logger.debug(
|
|
"Context engine '%s' could not register /%s: %s",
|
|
self._engine_name, clean, exc,
|
|
)
|
|
|
|
# No-op for other registration methods
|
|
def register_tool(self, *args, **kwargs):
|
|
pass
|
|
|
|
def register_hook(self, *args, **kwargs):
|
|
pass
|
|
|
|
def register_cli_command(self, *args, **kwargs):
|
|
pass
|
|
|
|
def register_memory_provider(self, *args, **kwargs):
|
|
pass
|