mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-08 13:12:08 +00:00
* fix(windows): stop terminal-window popups from background spawns Native-Windows desktop/gateway users saw cmd/conhost windows flash on gateway restart, image paste, the dashboard Projects tree, voice notes, and ~5 min after closing the app (detached cron). Two root causes: - Console-subsystem exes (taskkill, schtasks, wmic, netstat, tasklist, agent-browser, git, ffmpeg, powershell, git-bash) spawned via raw subprocess allocate a fresh console when the launching process has none (pythonw desktop backend / detached gateway) - even with output captured. - uv venv pythonw shims re-exec console python.exe, so Python children get a console regardless of how they're launched. Fixes: - Single hidden-spawn primitive (_subprocess_compat.run/.popen) that ORs CREATE_NO_WINDOW on Windows, no-op on POSIX. Route every Hermes-owned console-exe spawn through it. - FreeConsole() catch-all in hermes_bootstrap: any Python child that exclusively owns an auto-allocated console detaches it at startup (GetConsoleProcessList()==1 gate leaves shared interactive consoles untouched). - Replace PowerShell/wmic gateway PID scans with in-process psutil. - Skip schtasks queries on non-interactive desktop restarts. - Prefer native agent-browser .exe over .cmd shims. - Guard test bans raw subprocess spawns of the Windows-only console tools repo-wide so the popup class can't regress. * fix(windows): scope FreeConsole to background entry points; fix merge fallout Console detach review (per #53810 feedback): GetConsoleProcessList()==1 can't tell a uv pythonw->python phantom console apart from a user opening the interactive CLI/TUI in its own fresh console (double-click, shortcut, ConPTY) — both report a single attached process with a tty. Running FreeConsole() in the import-time bootstrap therefore risked detaching a legitimately-interactive terminal. - Extract FreeConsole into explicit hermes_bootstrap.detach_orphan_console(); remove it from apply_windows_utf8_bootstrap() (import side effect). - Call it only from known background mains: gateway run, dashboard backend (start_server, what the desktop spawns), cron standalone, tui_gateway entry, slash worker. Interactive CLI/TUI never calls it. - Behavior-contract tests: frees only when solo owner, leaves shared console, no-op without console / on POSIX, and asserts it's not an import side effect. Merge fallout from origin/main (#53791): - local.py: 3-way merge left a dangling **_popen_kwargs (NameError crashing every terminal init). _subprocess_compat.popen already hides the window, so drop it. - discord adapter: merge stacked an undefined windows_hide_flags() onto the primitive call; drop the redundant arg. - test_gateway: scan now goes psutil-first (zero spawn); rewrite the case-variant test to drive that production path. * test(claw): mock _subprocess_compat.run seam for Windows process scan claw.py's Windows tasklist/powershell scan routes through the hidden-spawn primitive; the tests still patched claw_mod.subprocess, so on win32 the mock was never hit and real spawns returned nothing. Patch the actual seam.
145 lines
4.6 KiB
Python
145 lines
4.6 KiB
Python
"""Persistent slash-command worker — one HermesCLI per TUI session.
|
|
|
|
Protocol: reads JSON lines from stdin {id, command}, writes {id, ok, output|error} to stdout.
|
|
"""
|
|
|
|
import argparse
|
|
import contextlib
|
|
import io
|
|
import json
|
|
import os
|
|
import sys
|
|
import threading
|
|
import time
|
|
|
|
import psutil
|
|
|
|
import cli as cli_mod
|
|
from cli import HermesCLI
|
|
from rich.console import Console
|
|
|
|
# Env-overridable so the integration test can drive sub-second timing.
|
|
def _env_float(name: str, default: float) -> float:
|
|
"""Parse a float env knob, falling back to ``default`` on absent/malformed
|
|
values. A bare ``float(os.environ.get(...))`` would raise ValueError at
|
|
import time on a typo (e.g. ``HERMES_SLASH_WATCHDOG_POLL_S=2s``) and kill
|
|
the worker before it can serve a single command."""
|
|
raw = os.environ.get(name)
|
|
if not raw:
|
|
return default
|
|
try:
|
|
return float(raw)
|
|
except (TypeError, ValueError):
|
|
return default
|
|
|
|
|
|
_WATCHDOG_POLL_S = max(0.05, _env_float("HERMES_SLASH_WATCHDOG_POLL_S", 2.0))
|
|
_ORPHAN_GRACE_S = max(0.0, _env_float("HERMES_SLASH_WATCHDOG_GRACE_S", 5.0))
|
|
_in_flight = threading.Event() # set while a command is executing
|
|
|
|
|
|
def _is_orphaned(original_ppid, parent_create_time, getppid=os.getppid) -> bool:
|
|
"""True once our spawning gateway is gone. Compare to the ORIGINAL ppid
|
|
(never ==1: Linux reparents to a subreaper) and guard PID reuse via
|
|
create_time."""
|
|
if getppid() != original_ppid:
|
|
return True
|
|
try:
|
|
if not psutil.pid_exists(original_ppid):
|
|
return True
|
|
return psutil.Process(original_ppid).create_time() != parent_create_time
|
|
except psutil.Error:
|
|
return True
|
|
|
|
|
|
def _start_parent_death_watchdog(original_ppid, parent_create_time) -> None:
|
|
def _loop():
|
|
while not _is_orphaned(original_ppid, parent_create_time):
|
|
time.sleep(_WATCHDOG_POLL_S)
|
|
deadline = time.monotonic() + _ORPHAN_GRACE_S
|
|
while _in_flight.is_set() and time.monotonic() < deadline:
|
|
time.sleep(0.05) # let an in-flight command finish/flush
|
|
os._exit(0)
|
|
|
|
threading.Thread(target=_loop, daemon=True).start()
|
|
|
|
|
|
def _run(cli: HermesCLI, command: str) -> str:
|
|
cmd = (command or "").strip()
|
|
if not cmd:
|
|
return ""
|
|
if not cmd.startswith("/"):
|
|
cmd = f"/{cmd}"
|
|
|
|
buf = io.StringIO()
|
|
|
|
# Rich Console captures its file handle at construction time, so
|
|
# contextlib.redirect_stdout won't affect it. Swap the console's
|
|
# underlying file to our buffer so self.console.print() is captured.
|
|
cli.console = Console(file=buf, force_terminal=True, width=120)
|
|
|
|
old = getattr(cli_mod, "_cprint", None)
|
|
if old is not None:
|
|
cli_mod._cprint = lambda text: print(text)
|
|
|
|
try:
|
|
with contextlib.redirect_stdout(buf), contextlib.redirect_stderr(buf):
|
|
cli.process_command(cmd)
|
|
finally:
|
|
if old is not None:
|
|
cli_mod._cprint = old
|
|
|
|
return buf.getvalue().rstrip()
|
|
|
|
|
|
def main():
|
|
# Stdio worker spawned by the gateway: drop any console a uv pythonw→python
|
|
# re-exec auto-allocated. No-op on POSIX.
|
|
try:
|
|
import hermes_bootstrap
|
|
hermes_bootstrap.detach_orphan_console()
|
|
except Exception:
|
|
pass
|
|
|
|
p = argparse.ArgumentParser(add_help=False)
|
|
p.add_argument("--session-key", required=True)
|
|
p.add_argument("--model", default="")
|
|
args = p.parse_args()
|
|
|
|
os.environ["HERMES_SESSION_KEY"] = args.session_key
|
|
os.environ["HERMES_INTERACTIVE"] = "1"
|
|
|
|
# Start before the (hundreds-of-ms) HermesCLI build — that window is itself
|
|
# an orphan risk if the gateway dies mid-spawn.
|
|
orig_ppid = os.getppid()
|
|
try:
|
|
parent_create_time = psutil.Process(orig_ppid).create_time()
|
|
except psutil.Error:
|
|
parent_create_time = 0.0
|
|
_start_parent_death_watchdog(orig_ppid, parent_create_time)
|
|
|
|
with contextlib.redirect_stdout(io.StringIO()), contextlib.redirect_stderr(io.StringIO()):
|
|
cli = HermesCLI(model=args.model or None, compact=True, resume=args.session_key, verbose=False)
|
|
|
|
for raw in sys.stdin:
|
|
line = raw.strip()
|
|
if not line:
|
|
continue
|
|
|
|
_in_flight.set()
|
|
rid = None
|
|
try:
|
|
req = json.loads(line)
|
|
rid = req.get("id")
|
|
out = _run(cli, req.get("command", ""))
|
|
sys.stdout.write(json.dumps({"id": rid, "ok": True, "output": out}) + "\n")
|
|
sys.stdout.flush()
|
|
except Exception as e:
|
|
sys.stdout.write(json.dumps({"id": rid, "ok": False, "error": str(e)}) + "\n")
|
|
sys.stdout.flush()
|
|
finally:
|
|
_in_flight.clear()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|