mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-10 13:31:38 +00:00
d3c8667462
Slack Workflow Builder posts (and other app/bot messages) arrive as subtype=bot_message with user=None. _is_user_authorized rejected them at the `if not user_id: return False` guard, which runs *before* the #4466 {PLATFORM}_ALLOW_BOTS bypass — so @mentioning the bot from a Slack workflow silently did nothing, even with SLACK_ALLOW_BOTS (or SLACK_ALLOW_ALL_USERS) set. The chat-scoped allowlist for Telegram/QQ already runs before that guard for the same reason (channel broadcasts with no from_user); Slack was both missing from the bot-bypass map and had the bypass running too late. - gateway/authz_mixin: move the {PLATFORM}_ALLOW_BOTS bypass ahead of the no-user-id guard and add Platform.SLACK -> SLACK_ALLOW_BOTS. - plugins/platforms/slack/adapter: set is_bot=True on inbound bot_message events so the gateway can identify workflow/app senders (they carry no user_id to match against the allowlist). Tested: new tests/gateway/test_slack_bot_auth_bypass.py plus the existing Discord/Feishu bot-auth and gateway authz/gating suites all pass.
92 lines
2.8 KiB
Python
92 lines
2.8 KiB
Python
"""Regression guard for Slack bot/workflow-sender authorization bypass.
|
|
|
|
Mirrors tests/gateway/test_feishu_bot_auth_bypass.py for Platform.SLACK.
|
|
|
|
Slack Workflow Builder posts (and other app/bot messages) arrive as
|
|
``subtype=bot_message`` with ``user=None``, so the SessionSource carries
|
|
``is_bot=True`` and ``user_id=None``. Without the #4466 bot bypass running
|
|
*before* the no-user-id guard, these senders are rejected at
|
|
``_is_user_authorized`` even when the operator enabled ``SLACK_ALLOW_BOTS`` --
|
|
the bug that makes @mentioning the bot from a Slack workflow do nothing.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
from gateway.session import Platform, SessionSource
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _isolate_slack_env(monkeypatch):
|
|
for var in (
|
|
"SLACK_ALLOW_BOTS",
|
|
"SLACK_ALLOWED_USERS",
|
|
"SLACK_ALLOW_ALL_USERS",
|
|
"GATEWAY_ALLOW_ALL_USERS",
|
|
"GATEWAY_ALLOWED_USERS",
|
|
):
|
|
monkeypatch.delenv(var, raising=False)
|
|
|
|
|
|
def _make_bare_runner():
|
|
from gateway.run import GatewayRunner
|
|
|
|
runner = object.__new__(GatewayRunner)
|
|
runner.pairing_store = SimpleNamespace(is_approved=lambda *_a, **_kw: False)
|
|
return runner
|
|
|
|
|
|
def _make_slack_bot_source():
|
|
# Workflow Builder / app posts: subtype=bot_message, user=None.
|
|
return SessionSource(
|
|
platform=Platform.SLACK,
|
|
chat_id="C0123",
|
|
chat_type="group",
|
|
user_id=None,
|
|
user_name="",
|
|
is_bot=True,
|
|
)
|
|
|
|
|
|
def _make_slack_human_source(user_id="U_human"):
|
|
return SessionSource(
|
|
platform=Platform.SLACK,
|
|
chat_id="C0123",
|
|
chat_type="group",
|
|
user_id=user_id,
|
|
user_name="Human",
|
|
is_bot=False,
|
|
)
|
|
|
|
|
|
def test_slack_bot_authorized_when_allow_bots_all(monkeypatch):
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("SLACK_ALLOW_BOTS", "all")
|
|
assert runner._is_user_authorized(_make_slack_bot_source()) is True
|
|
|
|
|
|
def test_slack_bot_authorized_when_allow_bots_mentions(monkeypatch):
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("SLACK_ALLOW_BOTS", "mentions")
|
|
assert runner._is_user_authorized(_make_slack_bot_source()) is True
|
|
|
|
|
|
def test_slack_bot_denied_when_allow_bots_unset(monkeypatch):
|
|
# No SLACK_ALLOW_BOTS + no user_id => denied (no bypass, hits guard).
|
|
runner = _make_bare_runner()
|
|
assert runner._is_user_authorized(_make_slack_bot_source()) is False
|
|
|
|
|
|
def test_slack_bot_denied_when_allow_bots_none(monkeypatch):
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("SLACK_ALLOW_BOTS", "none")
|
|
assert runner._is_user_authorized(_make_slack_bot_source()) is False
|
|
|
|
|
|
def test_slack_human_unaffected_by_bot_bypass(monkeypatch):
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("SLACK_ALLOW_ALL_USERS", "true")
|
|
assert runner._is_user_authorized(_make_slack_human_source()) is True
|