mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-14 14:12:44 +00:00
e3819a4143
Review follow-up on the anthropic_adapter batch salvage: 1. #52145 shipped no behavior test for the adjacency rewrite. Add test_strips_tool_use_when_result_not_immediately_adjacent (a tool_use whose result appears later but NOT in the immediately-following user message must be stripped — the exact case the old global id-match got wrong) plus an adjacent-pair control. Mutation-checked: reverting to a global match fails the non-adjacent test. 2. test_token_refresh_ua_prefix was vacuous — it bound to _refresh_oauth_token (a wrapper with no urllib.request.Request), so its assert never ran and it did NOT guard the real refresh UA site. Retarget it at refresh_anthropic_oauth_pure (:1048) with the header-scoped check. Mutation- checked: reverting :1048 to claude-cli/ now fails it.
94 lines
4 KiB
Python
94 lines
4 KiB
Python
"""Regression tests for the OAuth User-Agent header in anthropic_adapter.py.
|
|
|
|
Anthropic now 404s the OAuth token endpoint for any ``claude-cli/`` UA prefix
|
|
(issue #48534). The adapter must use ``claude-code/`` instead.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
class TestOAuthUserAgentPrefix:
|
|
"""All OAuth-related HTTP requests must use ``claude-code/`` UA, not ``claude-cli/``."""
|
|
|
|
def test_build_anthropic_client_oauth_ua(self):
|
|
"""build_anthropic_client with OAuth token must use claude-code UA."""
|
|
from agent.anthropic_adapter import build_anthropic_client
|
|
|
|
mock_sdk = MagicMock()
|
|
with patch("agent.anthropic_adapter._get_anthropic_sdk", return_value=mock_sdk):
|
|
build_anthropic_client("sk-ant-oauth-abc123", "https://api.anthropic.com")
|
|
|
|
# Inspect the kwargs passed to Anthropic()
|
|
call_kwargs = mock_sdk.Anthropic.call_args[1]
|
|
headers = call_kwargs.get("default_headers", {})
|
|
ua = headers.get("user-agent", "") or headers.get("User-Agent", "")
|
|
|
|
assert "claude-code/" in ua, f"Expected claude-code/ in UA, got: {ua}"
|
|
assert "claude-cli/" not in ua, f"Must not use claude-cli/ prefix: {ua}"
|
|
|
|
def test_no_claude_cli_in_source(self):
|
|
"""Source file must not contain claude-cli/ UA pattern (blocks OAuth)."""
|
|
import inspect
|
|
import agent.anthropic_adapter as mod
|
|
|
|
source = inspect.getsource(mod)
|
|
# Allow claude-cli in comments/strings that reference the old behavior
|
|
# but not in actual header assignments
|
|
lines = source.split("\n")
|
|
for i, line in enumerate(lines, 1):
|
|
stripped = line.strip()
|
|
if "claude-cli/" in stripped and ("User-Agent" in stripped or "user-agent" in stripped):
|
|
pytest.fail(
|
|
f"Line {i}: claude-cli/ still used in User-Agent header: {stripped}"
|
|
)
|
|
|
|
def test_token_exchange_ua_prefix(self):
|
|
"""run_hermes_oauth_login_pure must not send claude-cli/ UA."""
|
|
import inspect
|
|
import agent.anthropic_adapter as mod
|
|
|
|
# Get the source of the exchange function
|
|
try:
|
|
source = inspect.getsource(mod.run_hermes_oauth_login_pure)
|
|
except AttributeError:
|
|
pytest.skip("run_hermes_oauth_login_pure not found")
|
|
|
|
# Only fail on claude-cli/ in an actual User-Agent header line — a
|
|
# comment that references the old behavior (e.g. "Anthropic blocks
|
|
# claude-cli/ on the OAuth endpoint") is allowed. Mirrors the
|
|
# header-scoped check in test_no_claude_cli_in_source.
|
|
for i, line in enumerate(source.split("\n"), 1):
|
|
stripped = line.strip()
|
|
if "claude-cli/" in stripped and ("User-Agent" in stripped or "user-agent" in stripped):
|
|
pytest.fail(
|
|
f"Line {i}: run_hermes_oauth_login_pure still uses claude-cli/ UA header: {stripped}"
|
|
)
|
|
assert "claude-code/" in source, (
|
|
"run_hermes_oauth_login_pure should use claude-code/ UA"
|
|
)
|
|
|
|
def test_token_refresh_ua_prefix(self):
|
|
"""refresh_anthropic_oauth_pure must not send claude-cli/ UA."""
|
|
import inspect
|
|
import agent.anthropic_adapter as mod
|
|
|
|
func = getattr(mod, "refresh_anthropic_oauth_pure", None)
|
|
if func is None or not callable(func):
|
|
pytest.skip("refresh_anthropic_oauth_pure not found")
|
|
source = inspect.getsource(func)
|
|
|
|
# Header-scoped check (comments referencing claude-cli/ are allowed).
|
|
for i, line in enumerate(source.split("\n"), 1):
|
|
stripped = line.strip()
|
|
if "claude-cli/" in stripped and ("User-Agent" in stripped or "user-agent" in stripped):
|
|
pytest.fail(
|
|
f"Line {i}: refresh_anthropic_oauth_pure still uses claude-cli/ UA header: {stripped}"
|
|
)
|
|
assert "claude-code/" in source, (
|
|
"refresh_anthropic_oauth_pure should use claude-code/ UA"
|
|
)
|