mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-10 13:31:38 +00:00
e40175f069
On macOS Tahoe (Darwin 25+), a nonzero titleBarOverlay height makes setWindowButtonPosition() miscalculate the native traffic-light position (electron#49183), shoving the lights into the left titlebar tools. Pass height 0 there so the lights land at the configured inset; the renderer paints its own drag strips, so nothing is lost. Pre-Tahoe is unchanged. Gate on the truthful Darwin kernel major (25 = Tahoe) rather than the product version, which macOS reports as 16 or 26 depending on build SDK.
54 lines
2.3 KiB
JavaScript
54 lines
2.3 KiB
JavaScript
const assert = require('node:assert/strict')
|
|
const test = require('node:test')
|
|
|
|
const {
|
|
MACOS_TAHOE_DARWIN_MAJOR,
|
|
OVERLAY_FALLBACK_WIDTH,
|
|
macTitleBarOverlayHeight,
|
|
nativeOverlayWidth
|
|
} = require('./titlebar-overlay-width.cjs')
|
|
|
|
// This static reservation is only the pre-layout FALLBACK. Once laid out the
|
|
// renderer reads the exact width from navigator.windowControlsOverlay
|
|
// (use-window-controls-overlay-width.ts) and uses these values only when the WCO
|
|
// API is unavailable.
|
|
|
|
test('Windows reserves the overlay fallback width', () => {
|
|
assert.equal(nativeOverlayWidth({ isWindows: true }), OVERLAY_FALLBACK_WIDTH)
|
|
})
|
|
|
|
test('WSLg paints the same WCO, so it reserves the same fallback width', () => {
|
|
// The original bug: WSL fell through to 0, so the right tools sat under the
|
|
// controls and the title overran into them.
|
|
assert.equal(nativeOverlayWidth({ isWsl: true }), OVERLAY_FALLBACK_WIDTH)
|
|
})
|
|
|
|
test('plain Linux paints the WCO too, so it reserves the fallback width', () => {
|
|
// Regression #53185: re-enabling the overlay on plain Linux (KDE/GNOME)
|
|
// without reserving its width left the native min/max/close buttons painting
|
|
// on top of the app's right-edge titlebar tools.
|
|
assert.equal(nativeOverlayWidth({ isWindows: false, isWsl: false }), OVERLAY_FALLBACK_WIDTH)
|
|
assert.equal(nativeOverlayWidth(), OVERLAY_FALLBACK_WIDTH)
|
|
assert.equal(nativeOverlayWidth({}), OVERLAY_FALLBACK_WIDTH)
|
|
})
|
|
|
|
test('macOS uses traffic lights, not a WCO overlay, so it reserves nothing', () => {
|
|
assert.equal(nativeOverlayWidth({ isMac: true }), 0)
|
|
})
|
|
|
|
test('the fallback width is a sane positive pixel value', () => {
|
|
assert.ok(Number.isInteger(OVERLAY_FALLBACK_WIDTH) && OVERLAY_FALLBACK_WIDTH > 0)
|
|
})
|
|
|
|
test('pre-Tahoe keeps the full titlebar overlay height', () => {
|
|
assert.equal(macTitleBarOverlayHeight({ darwinMajor: MACOS_TAHOE_DARWIN_MAJOR - 1, titlebarHeight: 34 }), 34)
|
|
})
|
|
|
|
test('Tahoe (Darwin 25+) drops the overlay height to 0 to avoid electron#49183', () => {
|
|
assert.equal(macTitleBarOverlayHeight({ darwinMajor: MACOS_TAHOE_DARWIN_MAJOR, titlebarHeight: 34 }), 0)
|
|
assert.equal(macTitleBarOverlayHeight({ darwinMajor: MACOS_TAHOE_DARWIN_MAJOR + 1, titlebarHeight: 34 }), 0)
|
|
})
|
|
|
|
test('macTitleBarOverlayHeight tolerates missing args (unknown platform → 0)', () => {
|
|
assert.equal(macTitleBarOverlayHeight(), 0)
|
|
})
|