mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
Plugin slash commands now surface as first-class commands in every gateway
enumerator — Discord native slash picker, Telegram BotCommand menu, Slack
/hermes subcommand map — without a separate per-platform plugin API.
The existing 'command:<name>' gateway hook gains a decision protocol via
HookRegistry.emit_collect(): handlers that return a dict with
{'decision': 'deny'|'handled'|'rewrite'|'allow'} can intercept slash
command dispatch before core handling runs, unifying what would otherwise
have been a parallel 'pre_gateway_command' hook surface.
Changes:
- gateway/hooks.py: add HookRegistry.emit_collect() that fires the same
handler set as emit() but collects non-None return values. Backward
compatible — fire-and-forget telemetry hooks still work via emit().
- hermes_cli/plugins.py: add optional 'args_hint' param to
register_command() so plugins can opt into argument-aware native UI
registration (Discord arg picker, future platforms).
- hermes_cli/commands.py: add _iter_plugin_command_entries() helper and
merge plugin commands into telegram_bot_commands() and
slack_subcommand_map(). New is_gateway_known_command() recognizes both
built-in and plugin commands so the gateway hook fires for either.
- gateway/platforms/discord.py: extract _build_auto_slash_command helper
from the COMMAND_REGISTRY auto-register loop and reuse it for
plugin-registered commands. Built-in name conflicts are skipped.
- gateway/run.py: before normal slash dispatch, call emit_collect on
command:<canonical> and honor deny/handled/rewrite/allow decisions.
Hook now fires for plugin commands too.
- scripts/release.py: AUTHOR_MAP entry for @Magaav.
- Tests: emit_collect semantics, plugin command surfacing per platform,
decision protocol (deny/handled/rewrite/allow + non-dict tolerance),
Discord plugin auto-registration + conflict skipping, is_gateway_known_command.
Salvaged from #14131 (@Magaav). Original PR added a parallel
'pre_gateway_command' hook and a platform-keyed plugin command
registry; this re-implementation reuses the existing 'command:<name>'
hook and treats plugin commands as platform-agnostic so the same
capability reaches Telegram and Slack without new API surface.
Co-authored-by: Magaav <73175452+Magaav@users.noreply.github.com>
203 lines
7.5 KiB
Python
203 lines
7.5 KiB
Python
"""
|
|
Event Hook System
|
|
|
|
A lightweight event-driven system that fires handlers at key lifecycle points.
|
|
Hooks are discovered from ~/.hermes/hooks/ directories, each containing:
|
|
- HOOK.yaml (metadata: name, description, events list)
|
|
- handler.py (Python handler with async def handle(event_type, context))
|
|
|
|
Events:
|
|
- gateway:startup -- Gateway process starts
|
|
- session:start -- New session created (first message of a new session)
|
|
- session:end -- Session ends (user ran /new or /reset)
|
|
- session:reset -- Session reset completed (new session entry created)
|
|
- agent:start -- Agent begins processing a message
|
|
- agent:step -- Each turn in the tool-calling loop
|
|
- agent:end -- Agent finishes processing
|
|
- command:* -- Any slash command executed (wildcard match)
|
|
|
|
Errors in hooks are caught and logged but never block the main pipeline.
|
|
"""
|
|
|
|
import asyncio
|
|
import importlib.util
|
|
from typing import Any, Callable, Dict, List, Optional
|
|
|
|
import yaml
|
|
|
|
from hermes_cli.config import get_hermes_home
|
|
|
|
|
|
HOOKS_DIR = get_hermes_home() / "hooks"
|
|
|
|
|
|
class HookRegistry:
|
|
"""
|
|
Discovers, loads, and fires event hooks.
|
|
|
|
Usage:
|
|
registry = HookRegistry()
|
|
registry.discover_and_load()
|
|
await registry.emit("agent:start", {"platform": "telegram", ...})
|
|
"""
|
|
|
|
def __init__(self):
|
|
# event_type -> [handler_fn, ...]
|
|
self._handlers: Dict[str, List[Callable]] = {}
|
|
self._loaded_hooks: List[dict] = [] # metadata for listing
|
|
|
|
@property
|
|
def loaded_hooks(self) -> List[dict]:
|
|
"""Return metadata about all loaded hooks."""
|
|
return list(self._loaded_hooks)
|
|
|
|
def _register_builtin_hooks(self) -> None:
|
|
"""Register built-in hooks that are always active."""
|
|
try:
|
|
from gateway.builtin_hooks.boot_md import handle as boot_md_handle
|
|
|
|
self._handlers.setdefault("gateway:startup", []).append(boot_md_handle)
|
|
self._loaded_hooks.append({
|
|
"name": "boot-md",
|
|
"description": "Run ~/.hermes/BOOT.md on gateway startup",
|
|
"events": ["gateway:startup"],
|
|
"path": "(builtin)",
|
|
})
|
|
except Exception as e:
|
|
print(f"[hooks] Could not load built-in boot-md hook: {e}", flush=True)
|
|
|
|
def discover_and_load(self) -> None:
|
|
"""
|
|
Scan the hooks directory for hook directories and load their handlers.
|
|
|
|
Also registers built-in hooks that are always active.
|
|
|
|
Each hook directory must contain:
|
|
- HOOK.yaml with at least 'name' and 'events' keys
|
|
- handler.py with a top-level 'handle' function (sync or async)
|
|
"""
|
|
self._register_builtin_hooks()
|
|
|
|
if not HOOKS_DIR.exists():
|
|
return
|
|
|
|
for hook_dir in sorted(HOOKS_DIR.iterdir()):
|
|
if not hook_dir.is_dir():
|
|
continue
|
|
|
|
manifest_path = hook_dir / "HOOK.yaml"
|
|
handler_path = hook_dir / "handler.py"
|
|
|
|
if not manifest_path.exists() or not handler_path.exists():
|
|
continue
|
|
|
|
try:
|
|
manifest = yaml.safe_load(manifest_path.read_text(encoding="utf-8"))
|
|
if not manifest or not isinstance(manifest, dict):
|
|
print(f"[hooks] Skipping {hook_dir.name}: invalid HOOK.yaml", flush=True)
|
|
continue
|
|
|
|
hook_name = manifest.get("name", hook_dir.name)
|
|
events = manifest.get("events", [])
|
|
if not events:
|
|
print(f"[hooks] Skipping {hook_name}: no events declared", flush=True)
|
|
continue
|
|
|
|
# Dynamically load the handler module
|
|
spec = importlib.util.spec_from_file_location(
|
|
f"hermes_hook_{hook_name}", handler_path
|
|
)
|
|
if spec is None or spec.loader is None:
|
|
print(f"[hooks] Skipping {hook_name}: could not load handler.py", flush=True)
|
|
continue
|
|
|
|
module = importlib.util.module_from_spec(spec)
|
|
spec.loader.exec_module(module)
|
|
|
|
handle_fn = getattr(module, "handle", None)
|
|
if handle_fn is None:
|
|
print(f"[hooks] Skipping {hook_name}: no 'handle' function found", flush=True)
|
|
continue
|
|
|
|
# Register the handler for each declared event
|
|
for event in events:
|
|
self._handlers.setdefault(event, []).append(handle_fn)
|
|
|
|
self._loaded_hooks.append({
|
|
"name": hook_name,
|
|
"description": manifest.get("description", ""),
|
|
"events": events,
|
|
"path": str(hook_dir),
|
|
})
|
|
|
|
print(f"[hooks] Loaded hook '{hook_name}' for events: {events}", flush=True)
|
|
|
|
except Exception as e:
|
|
print(f"[hooks] Error loading hook {hook_dir.name}: {e}", flush=True)
|
|
|
|
def _resolve_handlers(self, event_type: str) -> List[Callable]:
|
|
"""Return all handlers that should fire for ``event_type``.
|
|
|
|
Exact matches fire first, followed by wildcard matches (e.g.
|
|
``command:*`` matches ``command:reset``).
|
|
"""
|
|
handlers = list(self._handlers.get(event_type, []))
|
|
if ":" in event_type:
|
|
base = event_type.split(":")[0]
|
|
wildcard_key = f"{base}:*"
|
|
handlers.extend(self._handlers.get(wildcard_key, []))
|
|
return handlers
|
|
|
|
async def emit(self, event_type: str, context: Optional[Dict[str, Any]] = None) -> None:
|
|
"""
|
|
Fire all handlers registered for an event, discarding return values.
|
|
|
|
Supports wildcard matching: handlers registered for "command:*" will
|
|
fire for any "command:..." event. Handlers registered for a base type
|
|
like "agent" won't fire for "agent:start" -- only exact matches and
|
|
explicit wildcards.
|
|
|
|
Args:
|
|
event_type: The event identifier (e.g. "agent:start").
|
|
context: Optional dict with event-specific data.
|
|
"""
|
|
if context is None:
|
|
context = {}
|
|
|
|
for fn in self._resolve_handlers(event_type):
|
|
try:
|
|
result = fn(event_type, context)
|
|
# Support both sync and async handlers
|
|
if asyncio.iscoroutine(result):
|
|
await result
|
|
except Exception as e:
|
|
print(f"[hooks] Error in handler for '{event_type}': {e}", flush=True)
|
|
|
|
async def emit_collect(
|
|
self,
|
|
event_type: str,
|
|
context: Optional[Dict[str, Any]] = None,
|
|
) -> List[Any]:
|
|
"""Fire handlers and return their non-None return values in order.
|
|
|
|
Like :meth:`emit` but captures each handler's return value. Used for
|
|
decision-style hooks (e.g. ``command:<name>`` policies that want to
|
|
allow/deny/rewrite the command before normal dispatch).
|
|
|
|
Exceptions from individual handlers are logged but do not abort the
|
|
remaining handlers.
|
|
"""
|
|
if context is None:
|
|
context = {}
|
|
|
|
results: List[Any] = []
|
|
for fn in self._resolve_handlers(event_type):
|
|
try:
|
|
result = fn(event_type, context)
|
|
if asyncio.iscoroutine(result):
|
|
result = await result
|
|
if result is not None:
|
|
results.append(result)
|
|
except Exception as e:
|
|
print(f"[hooks] Error in handler for '{event_type}': {e}", flush=True)
|
|
return results
|