mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-30 06:41:51 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
280 lines
10 KiB
Python
280 lines
10 KiB
Python
"""Tests for per-profile subprocess HOME isolation (#4426).
|
|
|
|
Verifies that subprocesses (terminal, execute_code, background processes)
|
|
receive a per-profile HOME directory while the Python process's own HOME
|
|
and Path.home() remain unchanged.
|
|
|
|
See: https://github.com/NousResearch/hermes-agent/issues/4426
|
|
"""
|
|
|
|
import os
|
|
import threading
|
|
from pathlib import Path
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# get_subprocess_home()
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestGetSubprocessHome:
|
|
"""Unit tests for hermes_constants.get_subprocess_home()."""
|
|
|
|
def test_returns_none_when_hermes_home_unset(self, monkeypatch):
|
|
monkeypatch.delenv("HERMES_HOME", raising=False)
|
|
from hermes_constants import get_subprocess_home
|
|
assert get_subprocess_home() is None
|
|
|
|
def test_returns_none_when_home_dir_missing(self, tmp_path, monkeypatch):
|
|
hermes_home = tmp_path / ".hermes"
|
|
hermes_home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
# No home/ subdirectory created
|
|
from hermes_constants import get_subprocess_home
|
|
assert get_subprocess_home() is None
|
|
|
|
def test_returns_path_when_home_dir_exists(self, tmp_path, monkeypatch):
|
|
hermes_home = tmp_path / ".hermes"
|
|
hermes_home.mkdir()
|
|
profile_home = hermes_home / "home"
|
|
profile_home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
from hermes_constants import get_subprocess_home
|
|
assert get_subprocess_home() == str(profile_home)
|
|
|
|
def test_returns_profile_specific_path(self, tmp_path, monkeypatch):
|
|
"""Named profiles get their own isolated HOME."""
|
|
profile_dir = tmp_path / ".hermes" / "profiles" / "coder"
|
|
profile_dir.mkdir(parents=True)
|
|
profile_home = profile_dir / "home"
|
|
profile_home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(profile_dir))
|
|
from hermes_constants import get_subprocess_home
|
|
assert get_subprocess_home() == str(profile_home)
|
|
|
|
def test_two_profiles_get_different_homes(self, tmp_path, monkeypatch):
|
|
base = tmp_path / ".hermes" / "profiles"
|
|
for name in ("alpha", "beta"):
|
|
p = base / name
|
|
p.mkdir(parents=True)
|
|
(p / "home").mkdir()
|
|
|
|
from hermes_constants import get_subprocess_home
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(base / "alpha"))
|
|
home_a = get_subprocess_home()
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(base / "beta"))
|
|
home_b = get_subprocess_home()
|
|
|
|
assert home_a is not None
|
|
assert home_b is not None
|
|
assert home_a != home_b
|
|
assert home_a.endswith("alpha/home")
|
|
assert home_b.endswith("beta/home")
|
|
|
|
def test_context_override_is_thread_local(self, tmp_path, monkeypatch):
|
|
root = tmp_path / "root"
|
|
profile = tmp_path / "profile"
|
|
root.mkdir()
|
|
profile.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(root))
|
|
|
|
from hermes_constants import (
|
|
get_hermes_home,
|
|
reset_hermes_home_override,
|
|
set_hermes_home_override,
|
|
)
|
|
|
|
ready = threading.Event()
|
|
release = threading.Event()
|
|
seen: list[str] = []
|
|
|
|
def read_from_other_thread():
|
|
ready.set()
|
|
release.wait(timeout=5)
|
|
seen.append(str(get_hermes_home()))
|
|
|
|
thread = threading.Thread(target=read_from_other_thread)
|
|
thread.start()
|
|
assert ready.wait(timeout=5)
|
|
|
|
token = set_hermes_home_override(profile)
|
|
try:
|
|
assert get_hermes_home() == profile
|
|
release.set()
|
|
thread.join(timeout=5)
|
|
finally:
|
|
reset_hermes_home_override(token)
|
|
release.set()
|
|
|
|
assert seen == [str(root)]
|
|
assert get_hermes_home() == root
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _make_run_env() injection
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestMakeRunEnvHomeInjection:
|
|
"""Verify _make_run_env() injects HOME into subprocess envs."""
|
|
|
|
def test_injects_home_when_profile_home_exists(self, tmp_path, monkeypatch):
|
|
hermes_home = tmp_path / "hermes"
|
|
hermes_home.mkdir()
|
|
(hermes_home / "home").mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
monkeypatch.setenv("HOME", "/root")
|
|
monkeypatch.setenv("PATH", "/usr/bin:/bin")
|
|
|
|
from tools.environments.local import _make_run_env
|
|
result = _make_run_env({})
|
|
|
|
assert result["HOME"] == str(hermes_home / "home")
|
|
|
|
def test_no_injection_when_home_dir_missing(self, tmp_path, monkeypatch):
|
|
hermes_home = tmp_path / "hermes"
|
|
hermes_home.mkdir()
|
|
# No home/ subdirectory
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
monkeypatch.setenv("HOME", "/root")
|
|
monkeypatch.setenv("PATH", "/usr/bin:/bin")
|
|
|
|
from tools.environments.local import _make_run_env
|
|
result = _make_run_env({})
|
|
|
|
assert result["HOME"] == "/root"
|
|
|
|
def test_no_injection_when_hermes_home_unset(self, monkeypatch):
|
|
monkeypatch.delenv("HERMES_HOME", raising=False)
|
|
monkeypatch.setenv("HOME", "/home/user")
|
|
monkeypatch.setenv("PATH", "/usr/bin:/bin")
|
|
|
|
from tools.environments.local import _make_run_env
|
|
result = _make_run_env({})
|
|
|
|
assert result["HOME"] == "/home/user"
|
|
|
|
def test_context_override_bridges_to_subprocess_env(self, tmp_path, monkeypatch):
|
|
root = tmp_path / "root"
|
|
profile = tmp_path / "profile"
|
|
root.mkdir()
|
|
profile.mkdir()
|
|
(profile / "home").mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(root))
|
|
monkeypatch.setenv("HOME", "/root")
|
|
monkeypatch.setenv("PATH", "/usr/bin:/bin")
|
|
|
|
from hermes_constants import reset_hermes_home_override, set_hermes_home_override
|
|
from tools.environments.local import _make_run_env
|
|
|
|
token = set_hermes_home_override(profile)
|
|
try:
|
|
result = _make_run_env({})
|
|
finally:
|
|
reset_hermes_home_override(token)
|
|
|
|
assert result["HERMES_HOME"] == str(profile)
|
|
assert result["HOME"] == str(profile / "home")
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _sanitize_subprocess_env() injection
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestSanitizeSubprocessEnvHomeInjection:
|
|
"""Verify _sanitize_subprocess_env() injects HOME for background procs."""
|
|
|
|
def test_injects_home_when_profile_home_exists(self, tmp_path, monkeypatch):
|
|
hermes_home = tmp_path / "hermes"
|
|
hermes_home.mkdir()
|
|
(hermes_home / "home").mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
|
|
base_env = {"HOME": "/root", "PATH": "/usr/bin", "USER": "root"}
|
|
from tools.environments.local import _sanitize_subprocess_env
|
|
result = _sanitize_subprocess_env(base_env)
|
|
|
|
assert result["HOME"] == str(hermes_home / "home")
|
|
|
|
def test_no_injection_when_home_dir_missing(self, tmp_path, monkeypatch):
|
|
hermes_home = tmp_path / "hermes"
|
|
hermes_home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
|
|
base_env = {"HOME": "/root", "PATH": "/usr/bin"}
|
|
from tools.environments.local import _sanitize_subprocess_env
|
|
result = _sanitize_subprocess_env(base_env)
|
|
|
|
assert result["HOME"] == "/root"
|
|
|
|
def test_context_override_bridges_to_background_env(self, tmp_path, monkeypatch):
|
|
root = tmp_path / "root"
|
|
profile = tmp_path / "profile"
|
|
root.mkdir()
|
|
profile.mkdir()
|
|
(profile / "home").mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(root))
|
|
|
|
base_env = {"HOME": "/root", "PATH": "/usr/bin"}
|
|
from hermes_constants import reset_hermes_home_override, set_hermes_home_override
|
|
from tools.environments.local import _sanitize_subprocess_env
|
|
|
|
token = set_hermes_home_override(profile)
|
|
try:
|
|
result = _sanitize_subprocess_env(base_env)
|
|
finally:
|
|
reset_hermes_home_override(token)
|
|
|
|
assert result["HERMES_HOME"] == str(profile)
|
|
assert result["HOME"] == str(profile / "home")
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Profile bootstrap
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestProfileBootstrap:
|
|
"""Verify new profiles get a home/ subdirectory."""
|
|
|
|
def test_profile_dirs_includes_home(self):
|
|
from hermes_cli.profiles import _PROFILE_DIRS
|
|
assert "home" in _PROFILE_DIRS
|
|
|
|
def test_create_profile_bootstraps_home_dir(self, tmp_path, monkeypatch):
|
|
"""create_profile() should create home/ inside the profile dir."""
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
|
|
from hermes_cli.profiles import create_profile
|
|
profile_dir = create_profile("testbot", no_alias=True)
|
|
assert (profile_dir / "home").is_dir()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Python process HOME unchanged
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestPythonProcessUnchanged:
|
|
"""Confirm the Python process's own HOME is never modified."""
|
|
|
|
def test_path_home_unchanged_after_subprocess_home_resolved(
|
|
self, tmp_path, monkeypatch
|
|
):
|
|
hermes_home = tmp_path / "hermes"
|
|
hermes_home.mkdir()
|
|
(hermes_home / "home").mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
|
|
original_home = os.environ.get("HOME")
|
|
original_path_home = str(Path.home())
|
|
|
|
from hermes_constants import get_subprocess_home
|
|
sub_home = get_subprocess_home()
|
|
|
|
# Subprocess home is set but Python HOME stays the same
|
|
assert sub_home is not None
|
|
assert os.environ.get("HOME") == original_home
|
|
assert str(Path.home()) == original_path_home
|