mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-02 07:11:49 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
101 lines
3.7 KiB
Python
101 lines
3.7 KiB
Python
"""Regression test: google-workspace SKILL.md must declare required_credential_files.
|
|
|
|
PR #9931 accidentally removed the required_credential_files header, which broke
|
|
credential file mounting in Docker/Modal remote backends (#16452). This test
|
|
prevents the regression from silently reappearing.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
|
|
SKILL_MD = (
|
|
Path(__file__).resolve().parents[2]
|
|
/ "skills/productivity/google-workspace/SKILL.md"
|
|
)
|
|
|
|
_EXPECTED_PATHS = {"google_token.json", "google_client_secret.json"}
|
|
|
|
|
|
def _parse_frontmatter(content: str) -> dict:
|
|
from agent.skill_utils import parse_frontmatter
|
|
|
|
fm, _ = parse_frontmatter(content)
|
|
return fm
|
|
|
|
|
|
class TestGoogleWorkspaceCredentialFiles:
|
|
def test_required_credential_files_present_in_skill_md(self):
|
|
content = SKILL_MD.read_text(encoding="utf-8")
|
|
fm = _parse_frontmatter(content)
|
|
entries = fm.get("required_credential_files")
|
|
assert entries, "required_credential_files missing from google-workspace SKILL.md"
|
|
assert isinstance(entries, list), "required_credential_files must be a list"
|
|
paths = {
|
|
(e["path"] if isinstance(e, dict) else e)
|
|
for e in entries
|
|
}
|
|
assert _EXPECTED_PATHS <= paths, (
|
|
f"Missing entries in required_credential_files: {_EXPECTED_PATHS - paths}"
|
|
)
|
|
|
|
def test_entries_are_registered_when_files_exist(self, tmp_path):
|
|
hermes_home = tmp_path / ".hermes"
|
|
hermes_home.mkdir()
|
|
(hermes_home / "google_token.json").write_text("{}")
|
|
(hermes_home / "google_client_secret.json").write_text("{}")
|
|
|
|
from tools.credential_files import (
|
|
clear_credential_files,
|
|
get_credential_file_mounts,
|
|
register_credential_files,
|
|
)
|
|
|
|
clear_credential_files()
|
|
try:
|
|
content = SKILL_MD.read_text(encoding="utf-8")
|
|
fm = _parse_frontmatter(content)
|
|
entries = fm.get("required_credential_files", [])
|
|
|
|
with patch.dict(os.environ, {"HERMES_HOME": str(hermes_home)}):
|
|
missing = register_credential_files(entries)
|
|
|
|
assert missing == [], f"Unexpected missing files: {missing}"
|
|
mounts = get_credential_file_mounts()
|
|
container_paths = {m["container_path"] for m in mounts}
|
|
assert "/root/.hermes/google_token.json" in container_paths
|
|
assert "/root/.hermes/google_client_secret.json" in container_paths
|
|
finally:
|
|
clear_credential_files()
|
|
|
|
def test_missing_token_is_reported(self, tmp_path):
|
|
"""google_token.json absent (first-time setup) — reported as missing, client secret still mounts."""
|
|
hermes_home = tmp_path / ".hermes"
|
|
hermes_home.mkdir()
|
|
(hermes_home / "google_client_secret.json").write_text("{}")
|
|
|
|
from tools.credential_files import (
|
|
clear_credential_files,
|
|
get_credential_file_mounts,
|
|
register_credential_files,
|
|
)
|
|
|
|
clear_credential_files()
|
|
try:
|
|
content = SKILL_MD.read_text(encoding="utf-8")
|
|
fm = _parse_frontmatter(content)
|
|
entries = fm.get("required_credential_files", [])
|
|
|
|
with patch.dict(os.environ, {"HERMES_HOME": str(hermes_home)}):
|
|
missing = register_credential_files(entries)
|
|
|
|
assert "google_token.json" in missing
|
|
mounts = get_credential_file_mounts()
|
|
container_paths = {m["container_path"] for m in mounts}
|
|
assert "/root/.hermes/google_client_secret.json" in container_paths
|
|
assert "/root/.hermes/google_token.json" not in container_paths
|
|
finally:
|
|
clear_credential_files()
|