mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-31 06:51:29 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
74 lines
2.7 KiB
Python
74 lines
2.7 KiB
Python
"""Tests for _clear_stale_openai_base_url() cleanup after provider switch (#5161)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
from hermes_cli.config import load_config, save_config, save_env_value, get_env_value
|
|
|
|
|
|
def _write_provider(provider: str, model: str = "test-model"):
|
|
"""Helper: write a provider + model to config.yaml."""
|
|
cfg = load_config()
|
|
model_cfg = cfg.get("model", {})
|
|
if not isinstance(model_cfg, dict):
|
|
model_cfg = {}
|
|
model_cfg["provider"] = provider
|
|
model_cfg["default"] = model
|
|
cfg["model"] = model_cfg
|
|
save_config(cfg)
|
|
|
|
|
|
class TestClearStaleOpenaiBaseUrl:
|
|
"""_clear_stale_openai_base_url() removes OPENAI_BASE_URL when provider is not custom."""
|
|
|
|
def test_clears_when_provider_is_named(self, monkeypatch):
|
|
"""OPENAI_BASE_URL is cleared when config provider is a named provider."""
|
|
from hermes_cli.main import _clear_stale_openai_base_url
|
|
|
|
_write_provider("openrouter")
|
|
save_env_value("OPENAI_BASE_URL", "http://localhost:11434/v1")
|
|
|
|
_clear_stale_openai_base_url()
|
|
|
|
result = get_env_value("OPENAI_BASE_URL")
|
|
assert not result, f"Expected OPENAI_BASE_URL to be cleared, got: {result!r}"
|
|
|
|
def test_preserves_when_provider_is_custom(self, monkeypatch):
|
|
"""OPENAI_BASE_URL is NOT cleared when config provider is 'custom'."""
|
|
from hermes_cli.main import _clear_stale_openai_base_url
|
|
|
|
_write_provider("custom")
|
|
save_env_value("OPENAI_BASE_URL", "http://localhost:11434/v1")
|
|
|
|
_clear_stale_openai_base_url()
|
|
|
|
result = get_env_value("OPENAI_BASE_URL")
|
|
assert result == "http://localhost:11434/v1", \
|
|
f"Expected OPENAI_BASE_URL to be preserved, got: {result!r}"
|
|
|
|
def test_noop_when_no_openai_base_url(self, monkeypatch):
|
|
"""No error when OPENAI_BASE_URL is not set."""
|
|
from hermes_cli.main import _clear_stale_openai_base_url
|
|
|
|
_write_provider("openrouter")
|
|
# Ensure it's not set
|
|
save_env_value("OPENAI_BASE_URL", "")
|
|
monkeypatch.delenv("OPENAI_BASE_URL", raising=False)
|
|
|
|
# Should not raise
|
|
_clear_stale_openai_base_url()
|
|
|
|
def test_noop_when_provider_empty(self, monkeypatch):
|
|
"""No cleanup when provider is not set in config."""
|
|
from hermes_cli.main import _clear_stale_openai_base_url
|
|
|
|
cfg = load_config()
|
|
cfg.pop("model", None)
|
|
save_config(cfg)
|
|
save_env_value("OPENAI_BASE_URL", "http://localhost:11434/v1")
|
|
|
|
_clear_stale_openai_base_url()
|
|
|
|
result = get_env_value("OPENAI_BASE_URL")
|
|
assert result == "http://localhost:11434/v1", \
|
|
"Should not clear when provider is not configured"
|