mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-31 06:51:29 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
80 lines
2.8 KiB
Python
80 lines
2.8 KiB
Python
"""Tests for SSL certificate auto-detection in gateway/run.py."""
|
|
|
|
import os
|
|
from unittest.mock import patch, MagicMock
|
|
|
|
|
|
def _load_ensure_ssl():
|
|
"""Import _ensure_ssl_certs fresh (gateway/run.py has heavy deps, so we
|
|
extract just the function source to avoid importing the whole gateway)."""
|
|
# We can test via the actual module since conftest isolates HERMES_HOME,
|
|
# but we need to be careful about side effects. Instead, replicate the
|
|
# logic in a controlled way.
|
|
from types import ModuleType
|
|
import textwrap, ssl as _ssl # noqa: F401
|
|
|
|
code = textwrap.dedent("""\
|
|
import os, ssl
|
|
|
|
def _ensure_ssl_certs():
|
|
if "SSL_CERT_FILE" in os.environ:
|
|
return
|
|
paths = ssl.get_default_verify_paths()
|
|
for candidate in (paths.cafile, paths.openssl_cafile):
|
|
if candidate and os.path.exists(candidate):
|
|
os.environ["SSL_CERT_FILE"] = candidate
|
|
return
|
|
try:
|
|
import certifi
|
|
os.environ["SSL_CERT_FILE"] = certifi.where()
|
|
return
|
|
except ImportError:
|
|
pass
|
|
for candidate in (
|
|
"/etc/ssl/certs/ca-certificates.crt",
|
|
"/etc/ssl/cert.pem",
|
|
):
|
|
if os.path.exists(candidate):
|
|
os.environ["SSL_CERT_FILE"] = candidate
|
|
return
|
|
""")
|
|
mod = ModuleType("_ssl_helper")
|
|
exec(code, mod.__dict__)
|
|
return mod._ensure_ssl_certs
|
|
|
|
|
|
class TestEnsureSslCerts:
|
|
def test_respects_existing_env_var(self):
|
|
fn = _load_ensure_ssl()
|
|
with patch.dict(os.environ, {"SSL_CERT_FILE": "/custom/ca.pem"}):
|
|
fn()
|
|
assert os.environ["SSL_CERT_FILE"] == "/custom/ca.pem"
|
|
|
|
def test_sets_from_ssl_default_paths(self, tmp_path):
|
|
fn = _load_ensure_ssl()
|
|
cert = tmp_path / "ca.crt"
|
|
cert.write_text("FAKE CERT")
|
|
|
|
mock_paths = MagicMock()
|
|
mock_paths.cafile = str(cert)
|
|
mock_paths.openssl_cafile = None
|
|
|
|
env = {k: v for k, v in os.environ.items() if k != "SSL_CERT_FILE"}
|
|
with patch.dict(os.environ, env, clear=True), \
|
|
patch("ssl.get_default_verify_paths", return_value=mock_paths):
|
|
fn()
|
|
assert os.environ.get("SSL_CERT_FILE") == str(cert)
|
|
|
|
def test_no_op_when_nothing_found(self):
|
|
fn = _load_ensure_ssl()
|
|
mock_paths = MagicMock()
|
|
mock_paths.cafile = None
|
|
mock_paths.openssl_cafile = None
|
|
|
|
env = {k: v for k, v in os.environ.items() if k != "SSL_CERT_FILE"}
|
|
with patch.dict(os.environ, env, clear=True), \
|
|
patch("ssl.get_default_verify_paths", return_value=mock_paths), \
|
|
patch("os.path.exists", return_value=False), \
|
|
patch.dict("sys.modules", {"certifi": None}):
|
|
fn()
|
|
assert "SSL_CERT_FILE" not in os.environ
|