mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
Replace dual execution model (PersistentShellMixin + per-backend oneshot) with spawn-per-call + session snapshot for all backends except ManagedModal. Core changes: - Every command spawns a fresh bash process; session snapshot (env vars, functions, aliases) captured at init and re-sourced before each command - CWD persists via file-based read (local) or in-band stdout markers (remote) - ProcessHandle protocol + _ThreadedProcessHandle adapter for SDK backends - cancel_fn wired for Modal (sandbox.terminate) and Daytona (sandbox.stop) - Shared utilities extracted: _pipe_stdin, _popen_bash, _load_json_store, _save_json_store, _file_mtime_key, _SYNC_INTERVAL_SECONDS - Rate-limited file sync unified in base _before_execute() with _sync_files() hook - execute_oneshot() removed; all 11 call sites in code_execution_tool.py migrated to execute() - Daytona timeout wrapper replaced with SDK-native timeout parameter - persistent_shell.py deleted (291 lines) Backend-specific: - Local: process-group kill via os.killpg, file-based CWD read - Docker: -e env flags only on init_session, not per-command - SSH: shlex.quote transport, ControlMaster connection reuse - Singularity: apptainer exec with instance://, no forced --pwd - Modal: _AsyncWorker + _ThreadedProcessHandle, cancel_fn -> sandbox.terminate - Daytona: SDK-level timeout (not shell wrapper), cancel_fn -> sandbox.stop - ManagedModal: unchanged (gateway owns execution); docstring added explaining why
186 lines
5.9 KiB
Python
186 lines
5.9 KiB
Python
"""Shared Hermes-side execution flow for Modal transports.
|
|
|
|
This module deliberately stops at the Hermes boundary:
|
|
- command preparation
|
|
- cwd/timeout normalization
|
|
- stdin/sudo shell wrapping
|
|
- common result shape
|
|
- interrupt/cancel polling
|
|
|
|
Direct Modal and managed Modal keep separate transport logic, persistence, and
|
|
trust-boundary decisions in their own modules.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import shlex
|
|
import time
|
|
import uuid
|
|
from abc import abstractmethod
|
|
from dataclasses import dataclass
|
|
from typing import Any
|
|
|
|
from tools.environments.base import BaseEnvironment
|
|
from tools.interrupt import is_interrupted
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class PreparedModalExec:
|
|
"""Normalized command data passed to a transport-specific exec runner."""
|
|
|
|
command: str
|
|
cwd: str
|
|
timeout: int
|
|
stdin_data: str | None = None
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class ModalExecStart:
|
|
"""Transport response after starting an exec."""
|
|
|
|
handle: Any | None = None
|
|
immediate_result: dict | None = None
|
|
|
|
|
|
def wrap_modal_stdin_heredoc(command: str, stdin_data: str) -> str:
|
|
"""Append stdin as a shell heredoc for transports without stdin piping."""
|
|
marker = f"HERMES_EOF_{uuid.uuid4().hex[:8]}"
|
|
while marker in stdin_data:
|
|
marker = f"HERMES_EOF_{uuid.uuid4().hex[:8]}"
|
|
return f"{command} << '{marker}'\n{stdin_data}\n{marker}"
|
|
|
|
|
|
def wrap_modal_sudo_pipe(command: str, sudo_stdin: str) -> str:
|
|
"""Feed sudo via a shell pipe for transports without direct stdin piping."""
|
|
return f"printf '%s\\n' {shlex.quote(sudo_stdin.rstrip())} | {command}"
|
|
|
|
|
|
class BaseModalExecutionEnvironment(BaseEnvironment):
|
|
"""Execution flow for the *managed* Modal transport (gateway-owned sandbox).
|
|
|
|
This deliberately overrides :meth:`BaseEnvironment.execute` because the
|
|
tool-gateway handles command preparation, CWD tracking, and env-snapshot
|
|
management on the server side. The base class's ``_wrap_command`` /
|
|
``_wait_for_process`` / snapshot machinery does not apply here — the
|
|
gateway owns that responsibility. See ``ManagedModalEnvironment`` for the
|
|
concrete subclass.
|
|
"""
|
|
|
|
_stdin_mode = "payload"
|
|
_poll_interval_seconds = 0.25
|
|
_client_timeout_grace_seconds: float | None = None
|
|
_interrupt_output = "[Command interrupted]"
|
|
_unexpected_error_prefix = "Modal execution error"
|
|
|
|
def execute(
|
|
self,
|
|
command: str,
|
|
cwd: str = "",
|
|
*,
|
|
timeout: int | None = None,
|
|
stdin_data: str | None = None,
|
|
) -> dict:
|
|
self._before_execute()
|
|
prepared = self._prepare_modal_exec(
|
|
command,
|
|
cwd=cwd,
|
|
timeout=timeout,
|
|
stdin_data=stdin_data,
|
|
)
|
|
|
|
try:
|
|
start = self._start_modal_exec(prepared)
|
|
except Exception as exc:
|
|
return self._error_result(f"{self._unexpected_error_prefix}: {exc}")
|
|
|
|
if start.immediate_result is not None:
|
|
return start.immediate_result
|
|
|
|
if start.handle is None:
|
|
return self._error_result(
|
|
f"{self._unexpected_error_prefix}: transport did not return an exec handle"
|
|
)
|
|
|
|
deadline = None
|
|
if self._client_timeout_grace_seconds is not None:
|
|
deadline = time.monotonic() + prepared.timeout + self._client_timeout_grace_seconds
|
|
|
|
while True:
|
|
if is_interrupted():
|
|
try:
|
|
self._cancel_modal_exec(start.handle)
|
|
except Exception:
|
|
pass
|
|
return self._result(self._interrupt_output, 130)
|
|
|
|
try:
|
|
result = self._poll_modal_exec(start.handle)
|
|
except Exception as exc:
|
|
return self._error_result(f"{self._unexpected_error_prefix}: {exc}")
|
|
|
|
if result is not None:
|
|
return result
|
|
|
|
if deadline is not None and time.monotonic() >= deadline:
|
|
try:
|
|
self._cancel_modal_exec(start.handle)
|
|
except Exception:
|
|
pass
|
|
return self._timeout_result_for_modal(prepared.timeout)
|
|
|
|
time.sleep(self._poll_interval_seconds)
|
|
|
|
def _before_execute(self) -> None:
|
|
"""Hook for backends that need pre-exec sync or validation."""
|
|
pass
|
|
|
|
def _prepare_modal_exec(
|
|
self,
|
|
command: str,
|
|
*,
|
|
cwd: str = "",
|
|
timeout: int | None = None,
|
|
stdin_data: str | None = None,
|
|
) -> PreparedModalExec:
|
|
effective_cwd = cwd or self.cwd
|
|
effective_timeout = timeout or self.timeout
|
|
|
|
exec_command = command
|
|
exec_stdin = stdin_data if self._stdin_mode == "payload" else None
|
|
if stdin_data is not None and self._stdin_mode == "heredoc":
|
|
exec_command = wrap_modal_stdin_heredoc(exec_command, stdin_data)
|
|
|
|
exec_command, sudo_stdin = self._prepare_command(exec_command)
|
|
if sudo_stdin is not None:
|
|
exec_command = wrap_modal_sudo_pipe(exec_command, sudo_stdin)
|
|
|
|
return PreparedModalExec(
|
|
command=exec_command,
|
|
cwd=effective_cwd,
|
|
timeout=effective_timeout,
|
|
stdin_data=exec_stdin,
|
|
)
|
|
|
|
def _result(self, output: str, returncode: int) -> dict:
|
|
return {
|
|
"output": output,
|
|
"returncode": returncode,
|
|
}
|
|
|
|
def _error_result(self, output: str) -> dict:
|
|
return self._result(output, 1)
|
|
|
|
def _timeout_result_for_modal(self, timeout: int) -> dict:
|
|
return self._result(f"Command timed out after {timeout}s", 124)
|
|
|
|
@abstractmethod
|
|
def _start_modal_exec(self, prepared: PreparedModalExec) -> ModalExecStart:
|
|
"""Begin a transport-specific exec."""
|
|
|
|
@abstractmethod
|
|
def _poll_modal_exec(self, handle: Any) -> dict | None:
|
|
"""Return a final result dict when complete, else ``None``."""
|
|
|
|
@abstractmethod
|
|
def _cancel_modal_exec(self, handle: Any) -> None:
|
|
"""Cancel or terminate the active transport exec."""
|