mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-21 05:11:26 +00:00
e164a9c1ed
When the first streamed message exceeds the platform length limit and gets split into chunks, _send_new_chunk was called with self._message_id (which is None on first send), dropping thread routing entirely. Fallback to self._initial_reply_to_id so overflow chunks land in the correct topic/thread. Also fix a fragile test assertion that could be silently skipped.
221 lines
8.2 KiB
Python
221 lines
8.2 KiB
Python
"""Regression tests for stream consumer thread/topic routing fix.
|
|
|
|
Verifies that GatewayStreamConsumer correctly passes reply_to on the first
|
|
message send, ensuring messages land in the correct topic/thread instead of
|
|
the main group chat.
|
|
|
|
Covers: #6969, #9916, #7355
|
|
"""
|
|
import asyncio
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
from gateway.stream_consumer import (
|
|
GatewayStreamConsumer,
|
|
StreamConsumerConfig,
|
|
)
|
|
|
|
|
|
def _make_adapter(send_result=None, edit_result=None, max_length=4096):
|
|
adapter = MagicMock()
|
|
adapter.send = AsyncMock(
|
|
return_value=send_result or SimpleNamespace(success=True, message_id="msg_1")
|
|
)
|
|
adapter.edit_message = AsyncMock(
|
|
return_value=edit_result or SimpleNamespace(success=True)
|
|
)
|
|
adapter.MAX_MESSAGE_LENGTH = max_length
|
|
return adapter
|
|
|
|
|
|
class TestInitialReplyToId:
|
|
"""Verify initial_reply_to_id is passed as reply_to on first send."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_first_send_uses_initial_reply_to_id(self):
|
|
"""When initial_reply_to_id is set, first adapter.send() should
|
|
include reply_to=initial_reply_to_id."""
|
|
adapter = _make_adapter()
|
|
consumer = GatewayStreamConsumer(
|
|
adapter,
|
|
"chat_123",
|
|
metadata={"thread_id": "omt_topic123"},
|
|
initial_reply_to_id="om_user_msg_456",
|
|
)
|
|
await consumer._send_or_edit("Hello world")
|
|
|
|
adapter.send.assert_called_once()
|
|
call_kwargs = adapter.send.call_args[1]
|
|
assert call_kwargs["reply_to"] == "om_user_msg_456", (
|
|
"First send should pass initial_reply_to_id as reply_to"
|
|
)
|
|
assert call_kwargs["chat_id"] == "chat_123"
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_first_send_without_initial_reply_to_id(self):
|
|
"""When initial_reply_to_id is None, first send should have
|
|
reply_to=None (backward compatible)."""
|
|
adapter = _make_adapter()
|
|
consumer = GatewayStreamConsumer(
|
|
adapter,
|
|
"chat_123",
|
|
)
|
|
await consumer._send_or_edit("Hello world")
|
|
|
|
adapter.send.assert_called_once()
|
|
call_kwargs = adapter.send.call_args[1]
|
|
assert call_kwargs.get("reply_to") is None
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_subsequent_edits_ignore_initial_reply_to_id(self):
|
|
"""After first send, edits should use message_id, not initial_reply_to_id."""
|
|
adapter = _make_adapter()
|
|
consumer = GatewayStreamConsumer(
|
|
adapter,
|
|
"chat_123",
|
|
metadata={"thread_id": "omt_topic123"},
|
|
initial_reply_to_id="om_user_msg_456",
|
|
)
|
|
|
|
# First send
|
|
await consumer._send_or_edit("Hello world")
|
|
assert adapter.send.call_count == 1
|
|
|
|
# Second call should edit, not send
|
|
await consumer._send_or_edit("Hello world updated")
|
|
assert adapter.send.call_count == 1, "Should edit, not send again"
|
|
adapter.edit_message.assert_called_once()
|
|
edit_kwargs = adapter.edit_message.call_args[1]
|
|
assert edit_kwargs["message_id"] == "msg_1"
|
|
assert edit_kwargs["chat_id"] == "chat_123"
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_metadata_passed_on_first_send(self):
|
|
"""Metadata (containing thread_id) should be forwarded on first send."""
|
|
adapter = _make_adapter()
|
|
metadata = {"thread_id": "omt_topic789"}
|
|
consumer = GatewayStreamConsumer(
|
|
adapter,
|
|
"chat_123",
|
|
metadata=metadata,
|
|
initial_reply_to_id="om_msg_000",
|
|
)
|
|
await consumer._send_or_edit("Test")
|
|
|
|
call_kwargs = adapter.send.call_args[1]
|
|
assert call_kwargs["metadata"] == metadata
|
|
|
|
|
|
class TestOverflowFirstMessage:
|
|
"""Verify thread routing is preserved when the first message overflows."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_overflow_first_send_uses_initial_reply_to_id(self):
|
|
"""When first message exceeds platform limit and is split into chunks,
|
|
each chunk should be threaded to initial_reply_to_id, not None."""
|
|
adapter = _make_adapter(max_length=10)
|
|
adapter.truncate_message = MagicMock(
|
|
return_value=["chunk_1", "chunk_2"]
|
|
)
|
|
consumer = GatewayStreamConsumer(
|
|
adapter,
|
|
"chat_123",
|
|
metadata={"thread_id": "omt_topic123"},
|
|
initial_reply_to_id="om_user_msg_789",
|
|
)
|
|
|
|
# Inject oversized accumulated text to trigger overflow path
|
|
consumer._accumulated = "A" * 100
|
|
consumer._current_edit_interval = 999
|
|
await consumer._send_new_chunk("chunk_1", consumer._message_id or consumer._initial_reply_to_id)
|
|
|
|
adapter.send.assert_called_once()
|
|
call_kwargs = adapter.send.call_args[1]
|
|
assert call_kwargs["reply_to"] == "om_user_msg_789", (
|
|
"Overflow first chunk should use initial_reply_to_id"
|
|
)
|
|
|
|
|
|
class TestFeishuFallbackThreadRouting:
|
|
"""Verify FeishuAdapter._send_raw_message routes to topic on fallback."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_uses_thread_id_when_available(self):
|
|
"""When reply_to=None and metadata has thread_id, message.create
|
|
should use receive_id_type='thread_id'."""
|
|
from gateway.platforms.feishu import FeishuAdapter
|
|
|
|
# We test the _send_raw_message method directly by mocking the client
|
|
adapter = MagicMock(spec=FeishuAdapter)
|
|
|
|
# Set up the real _send_raw_message logic manually
|
|
mock_client = MagicMock()
|
|
mock_create_response = SimpleNamespace(
|
|
success=lambda: True,
|
|
data=SimpleNamespace(message_id="new_msg_1"),
|
|
)
|
|
mock_client.im.v1.message.create = MagicMock(return_value=mock_create_response)
|
|
|
|
# Use the real implementation path
|
|
adapter._client = mock_client
|
|
adapter._build_create_message_body = FeishuAdapter._build_create_message_body
|
|
adapter._build_create_message_request = FeishuAdapter._build_create_message_request
|
|
|
|
# Call _send_raw_message with reply_to=None and thread_id in metadata
|
|
import json
|
|
result = await FeishuAdapter._send_raw_message(
|
|
adapter,
|
|
chat_id="oc_main_chat",
|
|
msg_type="text",
|
|
payload=json.dumps({"text": "hello"}),
|
|
reply_to=None,
|
|
metadata={"thread_id": "omt_topic_abc"},
|
|
)
|
|
|
|
# Verify message.create was called (not message.reply)
|
|
mock_client.im.v1.message.create.assert_called_once()
|
|
|
|
# The request should have receive_id_type="thread_id"
|
|
call_args = mock_client.im.v1.message.create.call_args[0][0]
|
|
body = call_args.body
|
|
# receive_id should be the thread_id, not the chat_id
|
|
import json as _json
|
|
body_dict = _json.loads(body) if isinstance(body, str) else body
|
|
assert hasattr(body, 'receive_id'), (
|
|
"CreateMessageRequestBody missing receive_id attribute"
|
|
)
|
|
assert body.receive_id == "omt_topic_abc", (
|
|
f"Expected receive_id='omt_topic_abc', got '{body.receive_id}'"
|
|
)
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_uses_chat_id_when_no_thread(self):
|
|
"""When reply_to=None and metadata has no thread_id, message.create
|
|
should use receive_id_type='chat_id' (original behavior)."""
|
|
from gateway.platforms.feishu import FeishuAdapter
|
|
|
|
mock_client = MagicMock()
|
|
mock_create_response = SimpleNamespace(
|
|
success=lambda: True,
|
|
data=SimpleNamespace(message_id="new_msg_1"),
|
|
)
|
|
mock_client.im.v1.message.create = MagicMock(return_value=mock_create_response)
|
|
|
|
adapter = MagicMock(spec=FeishuAdapter)
|
|
adapter._client = mock_client
|
|
adapter._build_create_message_body = FeishuAdapter._build_create_message_body
|
|
adapter._build_create_message_request = FeishuAdapter._build_create_message_request
|
|
|
|
import json
|
|
result = await FeishuAdapter._send_raw_message(
|
|
adapter,
|
|
chat_id="oc_main_chat",
|
|
msg_type="text",
|
|
payload=json.dumps({"text": "hello"}),
|
|
reply_to=None,
|
|
metadata=None,
|
|
)
|
|
|
|
mock_client.im.v1.message.create.assert_called_once()
|