mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-23 16:36:23 +00:00
Consolidated defensive layer for the invalid_blocks / msg_too_long bug class (#56615, #62054, #53693): one malformed or oversized block fails the ENTIRE chat.postMessage / chat.update call, so approval cards never update and messages silently drop. New block_kit.sanitize_blocks() is applied at every call site that attaches blocks (send/edit via _maybe_blocks, send_exec_approval, send_slash_confirm, and the approval/slash-confirm chat.update button handlers). It: - truncates section/context text to the 3000-char cap with an ellipsis (covers interaction payloads where Slack's HTML-escaping of < > & inflates text past the limit budgeted at send time) - truncates header text to its 150-char cap - drops empty blocks (no text / elements / rows) - replaces null table column_settings entries with {} and trims default trailing entries (Slack requires every entry be an object) - caps the payload at Slack's 50-block maximum - returns None when nothing valid remains so callers fall back to the plain-text payload; never raises Also registers contributor mappings for the salvaged PRs in this cluster (tw0316, kamonspecial, sowork-skills). |
||
|---|---|---|
| .. | ||
| emails | ||
| README.md | ||
Contributor email → GitHub login mappings
This directory replaces appending entries to AUTHOR_MAP in
scripts/release.py. The old dict caused constant merge conflicts when
several salvage PRs landed at once — every PR edited the same lines of the
same file. Here, each mapping is its own file, and file additions never
conflict.
Adding a mapping
One file per commit-author email, under emails/:
python3 scripts/add_contributor.py <email> <github-login>
# or by hand:
echo "<github-login>" > contributors/emails/<email>
- File name = the exact commit-author email (as shown by
git log --format='%ae'). - File content = the GitHub login on the first non-comment line.
Lines starting with
#are comments (use them for the PR reference).
Example — contributors/emails/jane.doe@example.com:
janedoe
# PR #12345 salvage (gateway: fix session key routing)
Rules
- Do NOT add new entries to
AUTHOR_MAPinscripts/release.py. That dict is frozen legacy data; the release tooling merges it with this directory (directory entries win on duplicates). - GitHub noreply emails (
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.com) auto-resolve — no file needed. - The
Contributor Attribution CheckCI job fails a PR whose commits carry an unmapped email; the failure message prints the exact command to run.