mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
64 lines
2.2 KiB
Python
64 lines
2.2 KiB
Python
"""Unit tests for _print_loopback_ssh_hint() in hermes_cli/auth.py.
|
|
|
|
The helper warns users that loopback OAuth flows (Spotify) don't work over
|
|
SSH unless they set up an `ssh -L` port forward between their laptop's
|
|
browser and the remote host's loopback listener.
|
|
|
|
xAI Grok OAuth no longer uses this helper — its login is device-code-only —
|
|
but the Spotify integration still relies on it.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import io
|
|
import contextlib
|
|
import socket
|
|
|
|
|
|
from hermes_cli import auth as auth_mod
|
|
|
|
|
|
def _cap(fn):
|
|
buf = io.StringIO()
|
|
with contextlib.redirect_stdout(buf):
|
|
fn()
|
|
return buf.getvalue()
|
|
|
|
|
|
def test_loopback_ssh_hint_silent_when_not_remote(monkeypatch):
|
|
monkeypatch.setattr(auth_mod, "_is_remote_session", lambda: False)
|
|
out = _cap(lambda: auth_mod._print_loopback_ssh_hint(
|
|
"http://127.0.0.1:43827/spotify/callback", docs_url=auth_mod.SPOTIFY_DOCS_URL
|
|
))
|
|
assert out == ""
|
|
|
|
|
|
def test_loopback_ssh_hint_has_visual_header(monkeypatch):
|
|
"""The hint should print a divider and header so it stands out in noisy output."""
|
|
monkeypatch.setattr(auth_mod, "_is_remote_session", lambda: True)
|
|
out = _cap(lambda: auth_mod._print_loopback_ssh_hint(
|
|
"http://127.0.0.1:43827/callback"
|
|
))
|
|
assert "Remote session detected" in out
|
|
assert "---" in out # divider is present
|
|
|
|
|
|
class TestSshUserAtHost:
|
|
def test_resolves_user_and_hostname(self, monkeypatch):
|
|
monkeypatch.setenv("USER", "alice")
|
|
monkeypatch.delenv("LOGNAME", raising=False)
|
|
monkeypatch.setattr(socket, "gethostname", lambda: "myserver")
|
|
assert auth_mod._ssh_user_at_host() == "alice@myserver"
|
|
|
|
|
|
def test_placeholder_when_no_env_vars(self, monkeypatch):
|
|
monkeypatch.delenv("USER", raising=False)
|
|
monkeypatch.delenv("LOGNAME", raising=False)
|
|
monkeypatch.setattr(socket, "gethostname", lambda: "host1")
|
|
assert auth_mod._ssh_user_at_host() == "<user>@host1"
|
|
|
|
|
|
def test_placeholder_when_empty_hostname(self, monkeypatch):
|
|
monkeypatch.setenv("USER", "dave")
|
|
monkeypatch.setattr(socket, "gethostname", lambda: "")
|
|
assert auth_mod._ssh_user_at_host() == "dave@<this-host>"
|