mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-30 06:41:51 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
45 lines
1.8 KiB
Python
45 lines
1.8 KiB
Python
"""Tests for composite toolset expansion in delegate_task intersection."""
|
|
|
|
import unittest
|
|
|
|
from tools.delegate_tool import _expand_parent_toolsets
|
|
|
|
|
|
class TestExpandParentToolsets(unittest.TestCase):
|
|
"""Verify _expand_parent_toolsets recognises individual toolsets within composites."""
|
|
|
|
def test_composite_hermes_cli_expands_web(self):
|
|
"""hermes-cli includes web_search/web_extract → 'web' should be in expansion."""
|
|
expanded = _expand_parent_toolsets({"hermes-cli"})
|
|
self.assertIn("web", expanded)
|
|
self.assertIn("terminal", expanded)
|
|
self.assertIn("browser", expanded)
|
|
# Original composite is preserved
|
|
self.assertIn("hermes-cli", expanded)
|
|
|
|
def test_individual_toolset_unchanged(self):
|
|
"""When parent already uses individual toolsets, expansion keeps them."""
|
|
expanded = _expand_parent_toolsets({"web", "terminal"})
|
|
self.assertIn("web", expanded)
|
|
self.assertIn("terminal", expanded)
|
|
|
|
def test_empty_parent_toolsets(self):
|
|
expanded = _expand_parent_toolsets(set())
|
|
self.assertEqual(expanded, set())
|
|
|
|
def test_unknown_toolset_passthrough(self):
|
|
"""Unknown toolset names pass through without error."""
|
|
expanded = _expand_parent_toolsets({"nonexistent-toolset-xyz"})
|
|
self.assertIn("nonexistent-toolset-xyz", expanded)
|
|
|
|
def test_intersection_with_expanded_composite(self):
|
|
"""End-to-end: requesting ['web'] from parent with ['hermes-cli'] yields ['web']."""
|
|
parent_toolsets = {"hermes-cli"}
|
|
expanded = _expand_parent_toolsets(parent_toolsets)
|
|
toolsets = ["web"]
|
|
child_toolsets = [t for t in toolsets if t in expanded]
|
|
self.assertEqual(child_toolsets, ["web"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|