mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-30 06:41:51 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
71 lines
2.4 KiB
Python
71 lines
2.4 KiB
Python
"""Tests for hermes_cli/tips.py — random tip display at session start."""
|
|
|
|
from hermes_cli.tips import TIPS, get_random_tip
|
|
|
|
|
|
class TestTipsCorpus:
|
|
"""Validate the tip corpus itself."""
|
|
|
|
def test_has_at_least_200_tips(self):
|
|
assert len(TIPS) >= 200, f"Expected 200+ tips, got {len(TIPS)}"
|
|
|
|
def test_no_duplicates(self):
|
|
assert len(TIPS) == len(set(TIPS)), "Duplicate tips found"
|
|
|
|
def test_all_tips_are_strings(self):
|
|
for i, tip in enumerate(TIPS):
|
|
assert isinstance(tip, str), f"Tip {i} is not a string: {type(tip)}"
|
|
|
|
def test_no_empty_tips(self):
|
|
for i, tip in enumerate(TIPS):
|
|
assert tip.strip(), f"Tip {i} is empty or whitespace-only"
|
|
|
|
def test_max_length_reasonable(self):
|
|
"""Tips should fit on a single terminal line (~120 chars max)."""
|
|
for i, tip in enumerate(TIPS):
|
|
assert len(tip) <= 150, (
|
|
f"Tip {i} too long ({len(tip)} chars): {tip[:60]}..."
|
|
)
|
|
|
|
def test_no_leading_trailing_whitespace(self):
|
|
for i, tip in enumerate(TIPS):
|
|
assert tip == tip.strip(), f"Tip {i} has leading/trailing whitespace"
|
|
|
|
|
|
class TestGetRandomTip:
|
|
"""Validate the get_random_tip() function."""
|
|
|
|
def test_returns_string(self):
|
|
tip = get_random_tip()
|
|
assert isinstance(tip, str)
|
|
assert len(tip) > 0
|
|
|
|
def test_returns_tip_from_corpus(self):
|
|
tip = get_random_tip()
|
|
assert tip in TIPS
|
|
|
|
def test_randomness(self):
|
|
"""Multiple calls should eventually return different tips."""
|
|
seen = set()
|
|
for _ in range(50):
|
|
seen.add(get_random_tip())
|
|
# With 200+ tips and 50 draws, we should see at least 10 unique
|
|
assert len(seen) >= 10, f"Only got {len(seen)} unique tips in 50 draws"
|
|
|
|
|
|
class TestTipIntegrationInCLI:
|
|
"""Test that the tip display code in cli.py works correctly."""
|
|
|
|
def test_tip_import_works(self):
|
|
"""The import used in cli.py must succeed."""
|
|
from hermes_cli.tips import get_random_tip
|
|
assert callable(get_random_tip)
|
|
|
|
def test_tip_display_format(self):
|
|
"""Verify the Rich markup format doesn't break."""
|
|
tip = get_random_tip()
|
|
color = "#B8860B"
|
|
markup = f"[dim {color}]✦ Tip: {tip}[/]"
|
|
# Should not contain nested/broken Rich tags
|
|
assert markup.count("[/]") == 1
|
|
assert "[dim #B8860B]" in markup
|