mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-01 01:51:44 +00:00
Full codebase pass using the /clean doctrine (KISS/DRY, no one-off
helpers, no variables-used-once, pure functional where natural,
inlined obvious one-liners, killed dead exports, narrowed types,
spaced JSX). All contracts preserved — no RPC method, event name,
or exported type shape changed.
app/ — 15 files, -134 LOC
- inlined 4 one-off helpers (titleCase, isLong, statusToneFrom,
focusOutside predicate)
- stores to arrow-const style (buildUiState, buildTurnState,
buildOverlayState plus get/patch/reset triplets)
- functional slash/registry byName map (flatMap over for-loops)
- dropped dead param `live` in cancelOverlayFromCtrlC
- DRY'd duplicate shift() call in scrollWithSelection
- consolidated sections.push calls in /help
components/ — 12 files, -40 LOC
- extracted inline prop types to interfaces at file bottom (13×)
- inlined 6 one-off vars (pctLabel, logoW, heroW, cwd, title, hint)
- promoted HEART_COLORS + OPTS/LABELS to module scope
- JSX sibling spacing across 9 files
- un-shadowed `raw` in textInput
- components/thinking.tsx + components/markdown.tsx untouched
(structurally load-bearing / edge-case-heavy)
config content domain protocol/ — 8 files, -77 LOC
- tightened 3 regexes (MOUSE_TRACKING, looksLikeSlashCommand,
hasInterpolation — dropped stateful lastIndex dance)
- dead export ParsedSlashCommand removed
- MODES narrowed to `as const`, `.find(m => m === s)` replaces
`.includes() ? (as cast) : null`
- fortunes.ts hash via reduce
- fmtDuration ternary chain
- inlined aboveViewport predicate in viewport.ts
hooks/ + lib/ — 9 files, -38 LOC
- ANSI_RE via String.fromCharCode(27) + WS_RE lifted to module
scope (no more eslint-disable no-control-regex)
- compactPreview/edgePreview/thinkingPreview → ternary arrows
- useCompletion: hoisted pathReplace, moved stale-ref guard earlier
- useInputHistory: dropped useCallback wrapper (append is stable)
- useVirtualHistory: replaced 4× any with unknown + narrow
MeasuredNode interface + one cast site
root TS — 3 files, -63 LOC
- banner.ts: parseRichMarkup via matchAll instead of exec/lastIndex,
artWidth via reduce
- gatewayClient.ts: resolvePython candidate list collapse, inlined
one-branch guards in dispatch/pushLog/drain/request
- types.ts: alpha-sorted ActiveTool / Msg / SudoReq / SecretReq
members
eslint config
- disabled react-hooks/exhaustive-deps on packages/hermes-ink/**
(compiled by react/compiler, deps live in $[N] memo arrays that
eslint can't introspect) and removed the now-orphan in-file
disable directive in ScrollBox.tsx
fixes (not from the cleaner pass)
- useComposerState: unlinkSync(file) + try/catch → rmSync(file,
{ force: true }) — kills the no-empty lint error and is more
idiomatic
- useConfigSync: added setBellOnComplete + setVoiceEnabled to the
two useEffect dep arrays (they're stable React setState setters;
adding is safe and silences exhaustive-deps)
verification
- npx eslint src/ packages/ → 0 errors, 0 warnings
- npm run type-check → clean
- npm test → 50/50
- npm run build → 394.8kb ink-bundle.js, 11ms esbuild
- pytest tests/tui_gateway/ tests/test_tui_gateway_server.py
tests/hermes_cli/test_tui_resume_flow.py
tests/hermes_cli/test_tui_npm_install.py → 57/57
89 lines
2.3 KiB
TypeScript
89 lines
2.3 KiB
TypeScript
import { useEffect, useRef, useState } from 'react'
|
|
|
|
import type { CompletionItem } from '../app/interfaces.js'
|
|
import type { GatewayClient } from '../gatewayClient.js'
|
|
import type { CompletionResponse } from '../gatewayTypes.js'
|
|
import { asRpcResult } from '../lib/rpc.js'
|
|
|
|
const TAB_PATH_RE = /((?:["']?(?:[A-Za-z]:[\\/]|\.{1,2}\/|~\/|\/|@|[^"'`\s]+\/))[^\s]*)$/
|
|
|
|
export function useCompletion(input: string, blocked: boolean, gw: GatewayClient) {
|
|
const [completions, setCompletions] = useState<CompletionItem[]>([])
|
|
const [compIdx, setCompIdx] = useState(0)
|
|
const [compReplace, setCompReplace] = useState(0)
|
|
const ref = useRef('')
|
|
|
|
useEffect(() => {
|
|
const clear = () => {
|
|
setCompletions(prev => (prev.length ? [] : prev))
|
|
setCompIdx(prev => (prev ? 0 : prev))
|
|
setCompReplace(prev => (prev ? 0 : prev))
|
|
}
|
|
|
|
if (blocked) {
|
|
ref.current = ''
|
|
clear()
|
|
|
|
return
|
|
}
|
|
|
|
if (input === ref.current) {
|
|
return
|
|
}
|
|
|
|
ref.current = input
|
|
|
|
const isSlash = input.startsWith('/')
|
|
const pathWord = isSlash ? null : (input.match(TAB_PATH_RE)?.[1] ?? null)
|
|
|
|
if (!isSlash && !pathWord) {
|
|
clear()
|
|
|
|
return
|
|
}
|
|
|
|
const pathReplace = input.length - (pathWord?.length ?? 0)
|
|
|
|
const t = setTimeout(() => {
|
|
if (ref.current !== input) {
|
|
return
|
|
}
|
|
|
|
const req = isSlash
|
|
? gw.request<CompletionResponse>('complete.slash', { text: input })
|
|
: gw.request<CompletionResponse>('complete.path', { word: pathWord })
|
|
|
|
req
|
|
.then(raw => {
|
|
if (ref.current !== input) {
|
|
return
|
|
}
|
|
|
|
const r = asRpcResult<CompletionResponse>(raw)
|
|
|
|
setCompletions(r?.items ?? [])
|
|
setCompIdx(0)
|
|
setCompReplace(isSlash ? (r?.replace_from ?? 1) : pathReplace)
|
|
})
|
|
.catch((e: unknown) => {
|
|
if (ref.current !== input) {
|
|
return
|
|
}
|
|
|
|
setCompletions([
|
|
{
|
|
text: '',
|
|
display: 'completion unavailable',
|
|
meta: e instanceof Error && e.message ? e.message : 'unavailable'
|
|
}
|
|
])
|
|
setCompIdx(0)
|
|
setCompReplace(isSlash ? 1 : pathReplace)
|
|
})
|
|
}, 60)
|
|
|
|
return () => clearTimeout(t)
|
|
}, [blocked, gw, input])
|
|
|
|
return { completions, compIdx, setCompIdx, compReplace }
|
|
}
|