mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-12 08:51:53 +00:00
4717989c10
* fix(matrix): isolate room context and inbound dispatch * test(matrix): cover room isolation and dispatch regressions * docs(matrix): document room isolation and session scope * fix(matrix): stabilize CI requirement checks * test(matrix): isolate mautrix stubs in requirements tests * fix(matrix): port room-scoped status and resume to slash commands mixin Move Matrix /status scope output and /resume same-room guards from the pre-refactor gateway/run.py into gateway/slash_commands.py so PR #18505 foundation behavior survives the upstream god-file decomposition. Uses i18n keys for Matrix resume/status messages. Preserves upstream session.py fixes (role_authorized, DM user_id isolation). * docs(matrix): explain inbound dispatch via handle_sync loop Document why Hermes uses an explicit sync loop with handle_sync() rather than client.start(), aligning with upstream #7914 diagnostics while preserving Hermes background maintenance tasks. * fix(i18n): add Matrix resume/status keys to all locale catalogs The Matrix /resume and /status slash-command keys added in the foundation PR must exist in every supported locale file. tests/agent/test_i18n.py asserts key and placeholder parity across catalogs. Non-English locales use English strings as interim placeholders until community translators can localize them. * fix(matrix): restore gateway authz for allowed_users; honor config require_mention Revert the early MATRIX_ALLOWED_USERS gate in _on_room_message so inbound sender authorization stays in gateway authz like main. Parse require_mention from config.extra (platforms.matrix / top-level matrix yaml) with env fallback, matching thread_require_mention and fixing Forge when require_mention is set only in profile config.yaml. * fix(matrix): harden status scope and allowlisted DMs * fix(matrix): use session store lookup for resume scope
60 lines
2.6 KiB
Python
60 lines
2.6 KiB
Python
import types
|
|
|
|
import pytest
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
from gateway.config import PlatformConfig
|
|
|
|
|
|
class TestMatrixExecApprovalReactions:
|
|
@pytest.mark.asyncio
|
|
async def test_send_exec_approval_registers_prompt_and_seeds_reactions(self, monkeypatch):
|
|
monkeypatch.setenv("MATRIX_ALLOWED_USERS", "@liizfq:liizfq.top")
|
|
from gateway.platforms.matrix import MatrixAdapter
|
|
|
|
adapter = MatrixAdapter(PlatformConfig(enabled=True, token="tok", extra={"homeserver": "https://matrix.example.org"}))
|
|
adapter._client = types.SimpleNamespace()
|
|
adapter.send = AsyncMock(return_value=types.SimpleNamespace(success=True, message_id="$evt1"))
|
|
adapter._send_reaction = AsyncMock(return_value="$r")
|
|
|
|
result = await adapter.send_exec_approval(
|
|
chat_id="!room:example.org",
|
|
command="rm -rf /tmp/test",
|
|
session_key="sess-1",
|
|
description="dangerous",
|
|
)
|
|
|
|
assert result.success is True
|
|
assert adapter._approval_prompt_by_session["sess-1"] == "$evt1"
|
|
assert adapter._approval_prompts_by_event["$evt1"].session_key == "sess-1"
|
|
assert adapter._send_reaction.await_count == 3
|
|
emojis = [call.args[2] for call in adapter._send_reaction.await_args_list]
|
|
assert emojis == ["✅", "♾️", "❌"]
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_reaction_resolves_pending_approval(self, monkeypatch):
|
|
monkeypatch.setenv("MATRIX_ALLOWED_USERS", "@liizfq:liizfq.top")
|
|
from gateway.platforms.matrix import MatrixAdapter, _MatrixApprovalPrompt
|
|
|
|
adapter = MatrixAdapter(PlatformConfig(enabled=True, token="tok", extra={"homeserver": "https://matrix.example.org"}))
|
|
# Resolve user_id so _is_self_sender doesn't defensively drop all traffic (#15763).
|
|
adapter._user_id = "@bot:example.org"
|
|
adapter._approval_prompts_by_event["$target"] = _MatrixApprovalPrompt(
|
|
session_key="sess-1", chat_id="!room:example.org", message_id="$target"
|
|
)
|
|
adapter._approval_prompt_by_session["sess-1"] = "$target"
|
|
|
|
content = {"m.relates_to": {"event_id": "$target", "key": "✅"}}
|
|
event = types.SimpleNamespace(
|
|
sender="@liizfq:liizfq.top",
|
|
event_id="$react1",
|
|
room_id="!room:example.org",
|
|
content=content,
|
|
)
|
|
|
|
with patch("tools.approval.resolve_gateway_approval", return_value=1) as mock_resolve:
|
|
await adapter._on_reaction(event)
|
|
|
|
mock_resolve.assert_called_once_with("sess-1", "once")
|
|
assert "$target" not in adapter._approval_prompts_by_event
|
|
assert "sess-1" not in adapter._approval_prompt_by_session
|