mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-24 16:54:43 +00:00
Verification follow-up for the #51226 salvage: the host call site guarded select_context with hasattr(), but the ABC defines a default on every engine, so the built-in ContextCompressor (and any non-implementing engine) still paid per-request shallow copies of the conversation history plus a hook call on every provider request. Identity-check the bound method against ContextEngine.select_context and return the request untouched — mirroring the existing base-method short-circuit in _notify_context_engine_turn_complete — so the default path does zero work, not just produces an identical result. Adds two pins: the base no-op is never invoked (patched-to-raise base stays silent), and ContextCompressor.__dict__ contains neither new verb. Also registers the contributor email mapping for @chaos-xxl. |
||
|---|---|---|
| .. | ||
| emails | ||
| README.md | ||
Contributor email → GitHub login mappings
This directory replaces appending entries to AUTHOR_MAP in
scripts/release.py. The old dict caused constant merge conflicts when
several salvage PRs landed at once — every PR edited the same lines of the
same file. Here, each mapping is its own file, and file additions never
conflict.
Adding a mapping
One file per commit-author email, under emails/:
python3 scripts/add_contributor.py <email> <github-login>
# or by hand:
echo "<github-login>" > contributors/emails/<email>
- File name = the exact commit-author email (as shown by
git log --format='%ae'). - File content = the GitHub login on the first non-comment line.
Lines starting with
#are comments (use them for the PR reference).
Example — contributors/emails/jane.doe@example.com:
janedoe
# PR #12345 salvage (gateway: fix session key routing)
Rules
- Do NOT add new entries to
AUTHOR_MAPinscripts/release.py. That dict is frozen legacy data; the release tooling merges it with this directory (directory entries win on duplicates). - GitHub noreply emails (
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.com) auto-resolve — no file needed. - The
Contributor Attribution CheckCI job fails a PR whose commits carry an unmapped email; the failure message prints the exact command to run.