mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
f4724803b4
When proxy env vars (HTTP_PROXY, HTTPS_PROXY, ALL_PROXY) contain malformed URLs — e.g. 'http://127.0.0.1:6153export' from a broken shell config — the OpenAI/httpx client throws a cryptic 'Invalid port' error that doesn't identify the offending variable. Add _validate_proxy_env_urls() and _validate_base_url() in auxiliary_client.py, called from resolve_provider_client() and _create_openai_client() to fail fast with a clear, actionable error message naming the broken env var or URL. Closes #6360 Co-authored-by: MestreY0d4-Uninter <MestreY0d4-Uninter@users.noreply.github.com>
60 lines
2 KiB
Python
60 lines
2 KiB
Python
"""Tests for malformed proxy env var and base URL validation.
|
|
|
|
Salvaged from PR #6403 by MestreY0d4-Uninter — validates that the agent
|
|
surfaces clear errors instead of cryptic httpx ``Invalid port`` exceptions
|
|
when proxy env vars or custom endpoint URLs are malformed.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from agent.auxiliary_client import _validate_base_url, _validate_proxy_env_urls
|
|
|
|
|
|
# -- proxy env validation ------------------------------------------------
|
|
|
|
|
|
def test_proxy_env_accepts_normal_values(monkeypatch):
|
|
monkeypatch.setenv("HTTP_PROXY", "http://127.0.0.1:6153")
|
|
monkeypatch.setenv("HTTPS_PROXY", "https://proxy.example.com:8443")
|
|
monkeypatch.setenv("ALL_PROXY", "socks5://127.0.0.1:1080")
|
|
_validate_proxy_env_urls() # should not raise
|
|
|
|
|
|
def test_proxy_env_accepts_empty(monkeypatch):
|
|
monkeypatch.delenv("HTTP_PROXY", raising=False)
|
|
monkeypatch.delenv("HTTPS_PROXY", raising=False)
|
|
monkeypatch.delenv("ALL_PROXY", raising=False)
|
|
monkeypatch.delenv("http_proxy", raising=False)
|
|
monkeypatch.delenv("https_proxy", raising=False)
|
|
monkeypatch.delenv("all_proxy", raising=False)
|
|
_validate_proxy_env_urls() # should not raise
|
|
|
|
|
|
@pytest.mark.parametrize("key", [
|
|
"HTTP_PROXY", "HTTPS_PROXY", "ALL_PROXY",
|
|
"http_proxy", "https_proxy", "all_proxy",
|
|
])
|
|
def test_proxy_env_rejects_malformed_port(monkeypatch, key):
|
|
monkeypatch.setenv(key, "http://127.0.0.1:6153export")
|
|
with pytest.raises(RuntimeError, match=rf"Malformed proxy environment variable {key}=.*6153export"):
|
|
_validate_proxy_env_urls()
|
|
|
|
|
|
# -- base URL validation -------------------------------------------------
|
|
|
|
|
|
@pytest.mark.parametrize("url", [
|
|
"https://api.example.com/v1",
|
|
"http://127.0.0.1:6153/v1",
|
|
"acp://copilot",
|
|
"",
|
|
None,
|
|
])
|
|
def test_base_url_accepts_valid(url):
|
|
_validate_base_url(url) # should not raise
|
|
|
|
|
|
def test_base_url_rejects_malformed_port():
|
|
with pytest.raises(RuntimeError, match="Malformed custom endpoint URL"):
|
|
_validate_base_url("http://127.0.0.1:6153export")
|