mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-18 09:51:59 +00:00
f3b32e9f52
electron-builder 26.8.x can stage an Electron.app without its
Contents/MacOS/Electron binary, then fail renaming it to Hermes:
ENOENT: no such file or directory, rename .../MacOS/Electron -> .../MacOS/Hermes
This breaks `npm run pack` and the installer desktop stage before a
launchable Hermes.app exists.
- Point build.electronDist at the already-installed Electron dist so
electron-builder reuses it instead of re-unpacking from cache.
- Add a darwin-only prebuilder patch that restores the missing main
binary from the runtime dist before the rename. Idempotent (marker
guard), soft-fails on shape mismatch, survives node_modules reinstall.
Co-authored-by: ChasLui <chaslui@outlook.com>
59 lines
2.8 KiB
JavaScript
59 lines
2.8 KiB
JavaScript
const fs = require('node:fs')
|
|
const path = require('node:path')
|
|
|
|
if (process.platform !== 'darwin') {
|
|
process.exit(0)
|
|
}
|
|
|
|
const desktopRoot = path.resolve(__dirname, '..')
|
|
const repoRoot = path.resolve(desktopRoot, '..', '..')
|
|
const electronMacPath = path.join(repoRoot, 'node_modules', 'app-builder-lib', 'out', 'electron', 'electronMac.js')
|
|
|
|
const marker = 'hermes-macos-electron-binary-fallback'
|
|
const needle = ` await Promise.all([
|
|
doRename(path.join(contentsPath, "MacOS"), electronBranding.productName, appPlist.CFBundleExecutable),
|
|
(0, builder_util_1.unlinkIfExists)(path.join(appOutDir, "LICENSE")),
|
|
(0, builder_util_1.unlinkIfExists)(path.join(appOutDir, "LICENSES.chromium.html")),
|
|
]);`
|
|
const replacement = ` // ${marker}: electron-builder 26.8.x can sometimes copy
|
|
// Electron.app without its main MacOS/Electron binary before this rename.
|
|
// Restore it from the installed Electron runtime so local desktop installs
|
|
// do not fail with ENOENT during macOS arm64 packaging.
|
|
const macosDir = path.join(contentsPath, "MacOS");
|
|
const bundledElectronBinary = path.join(macosDir, electronBranding.productName);
|
|
if (!fs.existsSync(bundledElectronBinary)) {
|
|
const candidates = [
|
|
path.join(packager.info.framework.distMacOsAppName, "Contents", "MacOS", electronBranding.productName),
|
|
path.join(process.cwd(), "..", "..", "node_modules", "electron", "dist", "Electron.app", "Contents", "MacOS", electronBranding.productName),
|
|
];
|
|
const sourceBinary = candidates.find(candidate => fs.existsSync(candidate));
|
|
if (sourceBinary == null) {
|
|
throw new Error("Electron binary missing from packaged app and Electron runtime: " + bundledElectronBinary);
|
|
}
|
|
await (0, promises_1.copyFile)(sourceBinary, bundledElectronBinary);
|
|
await (0, promises_1.chmod)(bundledElectronBinary, 0o755);
|
|
}
|
|
await Promise.all([
|
|
doRename(macosDir, electronBranding.productName, appPlist.CFBundleExecutable),
|
|
(0, builder_util_1.unlinkIfExists)(path.join(appOutDir, "LICENSE")),
|
|
(0, builder_util_1.unlinkIfExists)(path.join(appOutDir, "LICENSES.chromium.html")),
|
|
]);`
|
|
|
|
if (!fs.existsSync(electronMacPath)) {
|
|
console.warn(`[patch-electron-builder] skipped: ${electronMacPath} not found`)
|
|
process.exit(0)
|
|
}
|
|
|
|
const source = fs.readFileSync(electronMacPath, 'utf8')
|
|
if (source.includes(marker)) {
|
|
console.log('[patch-electron-builder] macOS Electron binary fallback already applied')
|
|
process.exit(0)
|
|
}
|
|
|
|
if (!source.includes(needle)) {
|
|
console.warn('[patch-electron-builder] skipped: expected electronMac.js shape not found')
|
|
process.exit(0)
|
|
}
|
|
|
|
fs.writeFileSync(electronMacPath, source.replace(needle, replacement))
|
|
console.log('[patch-electron-builder] applied macOS Electron binary fallback')
|